Skip to contentSkip to conversation

tegra: Add a delay in clock_start_periph_pll()

PATCH New Simon Glass 2 participants 12 messages Apr 1, 2019 – Apr 24, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/7 tegra: Correct tegra124 clock name

The first clock type appears to have and incorrect setting for out of the mux outputs. It should be CLK_M, not OSC. Fix it and its only user.

---

Changes in v2: None

 arch/arm/mach-tegra/tegra124/clock.c | 2 +-
 board/nvidia/nyan-big/nyan-big.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-tegra/tegra124/clock.c
index 3bd6cf2afff..70916ea3c18 100644

arch/arm/mach-tegra/tegra124/clock.c +1 -1
@@ -71,7 +71,7 @@ enum {
  */
 #define CLK(x) CLOCK_ID_ ## x
 static enum clock_id clock_source[CLOCK_TYPE_COUNT][CLOCK_MAX_MUX+1] = {
-	{ CLK(AUDIO),	CLK(XCPU),	CLK(PERIPH),	CLK(OSC),
+	{ CLK(AUDIO),	CLK(XCPU),	CLK(PERIPH),	CLK(CLK_M),
 		CLK(NONE),	CLK(NONE),	CLK(NONE),	CLK(NONE),
 		MASK_BITS_31_30},
 	{ CLK(MEMORY),	CLK(CGENERAL),	CLK(PERIPH),	CLK(AUDIO),
board/nvidia/nyan-big/nyan-big.c +1 -1
index ff5c67de985..3c7bfead249 100644
@@ -121,7 +121,7 @@ static void enable_required_clocks(void)
 int nvidia_board_init(void)
 {
 	clock_start_periph_pll(PERIPH_ID_EXTPERIPH1, CLOCK_ID_OSC, 12000000);
-	clock_start_periph_pll(PERIPH_ID_I2S1, CLOCK_ID_OSC, 1500000);
+	clock_start_periph_pll(PERIPH_ID_I2S1, CLOCK_ID_CLK_M, 1500000);
 
 	/* For external MAX98090 audio codec */
 	clock_external_output(1);
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
#2 lore raw

PATCH v2 2/7 tegra: Add a delay in clock_start_periph_pll()

In reply to a message not in the archive

This function enables a peripheral clock and then immediately sets its divider. Add a delay to allow the clock to settle first. This matches the delay in other places which do a similar thing.

Without this, the I2S device on Nyan does not init properly.

---

Changes in v2: None

 arch/arm/mach-tegra/clock.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-tegra/clock.c +1 -0
index 096330748f2..dc5f16b41b6 100644
@@ -477,6 +477,7 @@ unsigned clock_start_periph_pll(enum periph_id periph_id,
 
 	reset_set_enable(periph_id, 1);
 	clock_enable(periph_id);
+	udelay(2);
 
 	effective_rate = clock_adjust_periph_pll_div(periph_id, parent, rate,
 						 NULL);
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
#3 lore raw

PATCH v2 3/7 tegra: sound: Add an audio hub driver

In reply to a message not in the archive

Add a driver for the audio hub. This is modelled as a misc device which supports writing audio data from I2S.

---

Changes in v2:
- Fix 'I2C' typo

 arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 +++++++++++++++++++
 drivers/sound/Kconfig                        |   9 +
 drivers/sound/Makefile                       |   1 +
 drivers/sound/tegra_ahub.c                   | 256 ++++++++++
 4 files changed, 741 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h
 create mode 100644 drivers/sound/tegra_ahub.c
(quoted diff) +0 -0

b/arch/arm/include/asm/arch-tegra/tegra_ahub.h
new file mode 100644
index 00000000000..96d542a91ca

arch/arm/include/asm/arch-tegra/tegra_ahub.h new file +475 -0

475 lines not on this page · raw message

drivers/sound/Kconfig +9 -0
index 6e9dcefcb90..4ebc719be2b 100644
@@ -71,6 +71,15 @@ config SOUND_IVYBRIDGE
 	  sometimes called Azalia. The audio codec is detected using a
 	  semi-automatic mechanism.
 
+config I2S_TEGRA
+	bool "Enable I2S support for Nvidia Tegra SoCs"
+	depends on I2S
+	select TEGRA124_DMA
+	help
+	  Nvidia Tegra SoCs support several I2S interfaces for sending audio
+	  data to an audio codec. This option enables support for this,
+	  using one of the available audio codec drivers.
+
 config SOUND_MAX98088
 	bool "Support Maxim max98088 audio codec"
 	depends on I2S
drivers/sound/Makefile +1 -0
index e155041ff5f..077012f8a61 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_I2S_SAMSUNG)	+= samsung-i2s.o
 obj-$(CONFIG_SOUND_SANDBOX)	+= sandbox.o
 obj-$(CONFIG_I2S_ROCKCHIP)	+= rockchip_i2s.o rockchip_sound.o
 obj-$(CONFIG_I2S_SAMSUNG)	+= samsung_sound.o
+obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o
 obj-$(CONFIG_SOUND_WM8994)	+= wm8994.o
 obj-$(CONFIG_SOUND_MAX98088)	+= max98088.o maxim_codec.o
 obj-$(CONFIG_SOUND_MAX98090)	+= max98090.o maxim_codec.o
drivers/sound/tegra_ahub.c new file +194 -0

194 lines not on this page · raw message

fifo_threshold=%d, id=%d\n",
+ uc_priv->channels, uc_priv->bitspersample, cif_ctrl,
+ fifo_threshold, uc_priv->id);
+
+ return 0;
+}
+
+static int tegra_ahub_ioctl(struct udevice *dev, unsigned long request,
+ void *buf)
+{
+ struct tegra_ahub_priv *priv = dev_get_priv(dev);
+
+ if (request != AHUB_MISCOP_SET_I2S)
+ return -ENOSYS;
+
+ priv->i2s = *(struct udevice **)buf;
+ log_debug("i2s set to '%s'\n", priv->i2s->name);
+
+ return tegra_ahub_enable(dev);
+}
+
+static int tegra_ahub_probe(struct udevice *dev)
+{
+ struct tegra_ahub_priv *priv = dev_get_priv(dev);
+ ulong addr;
+
+ addr = dev_read_addr_index(dev, 0);
+ if (addr == FDT_ADDR_T_NONE) {
+ log_debug("Invalid apbif address\n");
+ return -EINVAL;
+ }
+ priv->apbif_regs = (struct apbif_regs *)addr;
+
+ addr = dev_read_addr_index(dev, 1);
+ if (addr == FDT_ADDR_T_NONE) {
+ log_debug("Invalid xbar address\n");
+ return -EINVAL;
+ }
+ priv->xbar_regs = (struct xbar_regs *)addr;
+ log_debug("ahub apbif_regs=%p, xbar_regs=%p\n", priv->apbif_regs,
+ priv->xbar_regs);
+
+ return 0;
+}
+
+static struct misc_ops tegra_ahub_ops = {
+ .write = tegra_ahub_apbif_send,
+ .ioctl = tegra_ahub_ioctl,
+};
+
+static const struct udevice_id tegra_ahub_ids[] = {
+ { .compatible = "nvidia,tegra124-ahub" },
+ { }
+};
+
+U_BOOT_DRIVER(tegra_ahub) = {
+ .name = "tegra_ahub",
+ .id = UCLASS_MISC,
+ .of_match = tegra_ahub_ids,
+ .ops = &tegra_ahub_ops,
+ .probe = tegra_ahub_probe,
+ .priv_auto_alloc_size = sizeof(struct tegra_ahub_priv),
+};

Signature · 1 line
2.21.0.392.gf8f6787159e-goog
maintainer
#4 lore raw

PATCH v2 3/7 tegra: sound: Add an audio hub driver

Quoted 24 lines · Simon Glass

Add a driver for the audio hub. This is modelled as a misc device which supports writing audio data from I2S.

---

Changes in v2:
- Fix 'I2C' typo

 arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 +++++++++++++++++++
 drivers/sound/Kconfig                        |   9 +
 drivers/sound/Makefile                       |   1 +
 drivers/sound/tegra_ahub.c                   | 256 ++++++++++
 4 files changed, 741 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h
 create mode 100644 drivers/sound/tegra_ahub.c
arch/arm/include/asm/arch-tegra/tegra_ahub.h new file +0 -0
new file mode 100644
index 00000000000..96d542a91ca

arch/arm/include/asm/arch-tegra/tegra_ahub.h line 8

Quoted 8 lines
arch/arm/include/asm/arch-tegra/tegra_ahub.h new file +8 -0
@@ -0,0 +1,475 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * tegra_ahub.h - Definitions for Tegra124 audio hub driver
+ * Taken from dc tegra_ahub.h
+ *
+ * Copyright 2018 Google LLC
+ * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
+ */

Looks fine to me, although you may wish to update your copyright date now ;-)

Cheers
Jon

Signature · 1 line
nvpublic
#5 lore raw

PATCH v2 3/7 tegra: sound: Add an audio hub driver

Hi Jon,

Quoted 39 lines · Jon Hunter
Quoted 24 lines · Simon Glass

Add a driver for the audio hub. This is modelled as a misc device which supports writing audio data from I2S.

---

Changes in v2:
- Fix 'I2C' typo

 arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 +++++++++++++++++++
 drivers/sound/Kconfig                        |   9 +
 drivers/sound/Makefile                       |   1 +
 drivers/sound/tegra_ahub.c                   | 256 ++++++++++
 4 files changed, 741 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h
 create mode 100644 drivers/sound/tegra_ahub.c
arch/arm/include/asm/arch-tegra/tegra_ahub.h new file +0 -0
new file mode 100644
index 00000000000..96d542a91ca

arch/arm/include/asm/arch-tegra/tegra_ahub.h line 8

Quoted 8 lines
arch/arm/include/asm/arch-tegra/tegra_ahub.h new file +8 -0
@@ -0,0 +1,475 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * tegra_ahub.h - Definitions for Tegra124 audio hub driver
+ * Taken from dc tegra_ahub.h
+ *
+ * Copyright 2018 Google LLC
+ * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
+ */

Looks fine to me, although you may wish to update your copyright date now ;-)

Quoted 1 line

Feel free to update it when applying, but I'm OK with it. It's been sitting around for a while!

Regards,
Simon

#6 lore raw

PATCH v2 4/7 tegra: sound: Add an I2S driver

In reply to a message not in the archive

Add a driver which supports transmitting digital sound to an audio codec. This uses fixed parameters as a device-tree binding is not currently defined.

---

Changes in v2:
- Drop setting of slot_ctrl from i2s_tx_init()

 arch/arm/include/asm/arch-tegra/tegra_i2s.h | 206 ++++++++++++++++++++
 drivers/sound/Makefile                      |   2 +-
 drivers/sound/tegra_i2s.c                   | 123 ++++++++++++
 drivers/sound/tegra_i2s_priv.h              |  29 +++
 4 files changed, 359 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/include/asm/arch-tegra/tegra_i2s.h
 create mode 100644 drivers/sound/tegra_i2s.c
 create mode 100644 drivers/sound/tegra_i2s_priv.h
(quoted diff) +0 -0

b/arch/arm/include/asm/arch-tegra/tegra_i2s.h
new file mode 100644
index 00000000000..9319383f7c1

arch/arm/include/asm/arch-tegra/tegra_i2s.h new file +206 -0

206 lines not on this page · raw message

drivers/sound/Makefile +1 -1
index 077012f8a61..358d5f920b2 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_I2S_SAMSUNG)	+= samsung-i2s.o
 obj-$(CONFIG_SOUND_SANDBOX)	+= sandbox.o
 obj-$(CONFIG_I2S_ROCKCHIP)	+= rockchip_i2s.o rockchip_sound.o
 obj-$(CONFIG_I2S_SAMSUNG)	+= samsung_sound.o
-obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o
+obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o tegra_i2s.o
 obj-$(CONFIG_SOUND_WM8994)	+= wm8994.o
 obj-$(CONFIG_SOUND_MAX98088)	+= max98088.o maxim_codec.o
 obj-$(CONFIG_SOUND_MAX98090)	+= max98090.o maxim_codec.o
drivers/sound/tegra_i2s.c new file +123 -0

123 lines not on this page · raw message

drivers/sound/tegra_i2s_priv.h new file +29 -0
new file mode 100644
index 00000000000..7cd3fc808c8
@@ -0,0 +1,29 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2018 Google LLC
+ * Written by Simon Glass <[email protected]>
+ */
+
+#ifndef __TEGRA_I2S_PRIV_H
+#define __TEGRA_I2S_PRIV_H
+
+enum {
+	/* Set i2s device (in buf) */
+	AHUB_MISCOP_SET_I2S,
+};
+
+/*
+ * tegra_i2s_set_cif_tx_ctrl() - Set the I2C port to send to
+ *
+ * The CIF is not really part of I2S -- it's for Audio Hub to control
+ * the interface between I2S and Audio Hub.  However since it's put in
+ * the I2S registers domain instead of the Audio Hub, we need to export
+ * this as a function.
+ *
+ * @dev: I2S device
+ * @value: Value to write to CIF_TX_CTRL register
+ * @return 0
+ */
+int tegra_i2s_set_cif_tx_ctrl(struct udevice *dev, u32 value);
+
+#endif
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
#8 lore raw

PATCH v2 5/7 sound: tegra: Add a sound driver

In reply to a message not in the archive

Add a sound driver for tegra devices. This connects the audio hub, I2S controller and audio codec to allow sound output.

---

Changes in v2: None

 drivers/sound/Makefile      |   2 +-
 drivers/sound/tegra_sound.c | 100 ++++++++++++++++++++++++++++++++++++
 2 files changed, 101 insertions(+), 1 deletion(-)
 create mode 100644 drivers/sound/tegra_sound.c
drivers/sound/Makefile +1 -1
index 358d5f920b2..73ed7fe53c3 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_I2S_SAMSUNG)	+= samsung-i2s.o
 obj-$(CONFIG_SOUND_SANDBOX)	+= sandbox.o
 obj-$(CONFIG_I2S_ROCKCHIP)	+= rockchip_i2s.o rockchip_sound.o
 obj-$(CONFIG_I2S_SAMSUNG)	+= samsung_sound.o
-obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o tegra_i2s.o
+obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o tegra_i2s.o tegra_sound.o
 obj-$(CONFIG_SOUND_WM8994)	+= wm8994.o
 obj-$(CONFIG_SOUND_MAX98088)	+= max98088.o maxim_codec.o
 obj-$(CONFIG_SOUND_MAX98090)	+= max98090.o maxim_codec.o
drivers/sound/tegra_sound.c new file +100 -0

100 lines not on this page · raw message

Signature · 1 line
2.21.0.392.gf8f6787159e-goog
maintainer
#9 lore raw

PATCH v2 5/7 sound: tegra: Add a sound driver

Quoted 75 lines · Simon Glass

Add a sound driver for tegra devices. This connects the audio hub, I2S controller and audio codec to allow sound output.

---

Changes in v2: None

 drivers/sound/Makefile      |   2 +-
 drivers/sound/tegra_sound.c | 100 ++++++++++++++++++++++++++++++++++++
 2 files changed, 101 insertions(+), 1 deletion(-)
 create mode 100644 drivers/sound/tegra_sound.c
drivers/sound/Makefile +1 -1
index 358d5f920b2..73ed7fe53c3 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_I2S_SAMSUNG)	+= samsung-i2s.o
 obj-$(CONFIG_SOUND_SANDBOX)	+= sandbox.o
 obj-$(CONFIG_I2S_ROCKCHIP)	+= rockchip_i2s.o rockchip_sound.o
 obj-$(CONFIG_I2S_SAMSUNG)	+= samsung_sound.o
-obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o tegra_i2s.o
+obj-$(CONFIG_I2S_TEGRA)		+= tegra_ahub.o tegra_i2s.o tegra_sound.o
 obj-$(CONFIG_SOUND_WM8994)	+= wm8994.o
 obj-$(CONFIG_SOUND_MAX98088)	+= max98088.o maxim_codec.o
 obj-$(CONFIG_SOUND_MAX98090)	+= max98090.o maxim_codec.o
drivers/sound/tegra_sound.c new file +43 -0
new file mode 100644
index 00000000000..7c2ed53f5a7
@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2018 Google, LLC
+ * Written by Simon Glass <[email protected]>
+ */
+
+#define LOG_CATEGORY UCLASS_I2S
+
+#include <common.h>
+#include <audio_codec.h>
+#include <dm.h>
+#include <i2s.h>
+#include <misc.h>
+#include <sound.h>
+#include <asm/gpio.h>
+#include "tegra_i2s_priv.h"
+
+static int tegra_sound_setup(struct udevice *dev)
+{
+	struct sound_uc_priv *uc_priv = dev_get_uclass_priv(dev);
+	struct i2s_uc_priv *i2c_priv = dev_get_uclass_priv(uc_priv->i2s);
+	int ret;
+
+	if (uc_priv->setup_done)
+		return -EALREADY;
+	ret = audio_codec_set_params(uc_priv->codec, i2c_priv->id,
+				     i2c_priv->samplingrate,
+				     i2c_priv->samplingrate * i2c_priv->rfs,
+				     i2c_priv->bitspersample,
+				     i2c_priv->channels);
+	if (ret)
+		return ret;
+	uc_priv->setup_done = true;
+
+	return 0;
+}
+
+static int tegra_sound_play(struct udevice *dev, void *data, uint data_size)
+{
+	struct sound_uc_priv *uc_priv = dev_get_uclass_priv(dev);
+
+	return i2s_tx_data(uc_priv->i2s, data, data_size);
+}

drivers/sound/tegra_sound.c line 53

Quoted 10 lines
drivers/sound/tegra_sound.c new file +10 -0
+
+static int tegra_sound_probe(struct udevice *dev)
+{
+	struct sound_uc_priv *uc_priv = dev_get_uclass_priv(dev);
+	struct gpio_desc en_gpio;
+	struct udevice *ahub;
+	int ret;
+
+	ret = gpio_request_by_name(dev, "codec-enable-gpio", 0, &en_gpio,
+				   GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);

This looks a bit odd. I am not sure if this is supposed to be optional or not, but there is no checking of the return value although you store it.

Is there DT binding documentation that does along with this that describes these properties?

Cheers
Jon

Signature · 1 line
nvpublic
#10 lore raw

PATCH v2 5/7 sound: tegra: Add a sound driver

Hi Jon,

Quoted 84 lines · Jon Hunter
Quoted 81 lines · Simon Glass

Add a sound driver for tegra devices. This connects the audio hub, I2S controller and audio codec to allow sound output.

---

Changes in v2: None

 drivers/sound/Makefile      |   2 +-
 drivers/sound/tegra_sound.c | 100 ++++++++++++++++++++++++++++++++++++
 2 files changed, 101 insertions(+), 1 deletion(-)
 create mode 100644 drivers/sound/tegra_sound.c
drivers/sound/Makefile +1 -1
index 358d5f920b2..73ed7fe53c3 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_I2S_SAMSUNG)   += samsung-i2s.o
 obj-$(CONFIG_SOUND_SANDBOX)  += sandbox.o
 obj-$(CONFIG_I2S_ROCKCHIP)   += rockchip_i2s.o rockchip_sound.o
 obj-$(CONFIG_I2S_SAMSUNG)    += samsung_sound.o
-obj-$(CONFIG_I2S_TEGRA)              += tegra_ahub.o tegra_i2s.o
+obj-$(CONFIG_I2S_TEGRA)              += tegra_ahub.o tegra_i2s.o tegra_sound.o
 obj-$(CONFIG_SOUND_WM8994)   += wm8994.o
 obj-$(CONFIG_SOUND_MAX98088) += max98088.o maxim_codec.o
 obj-$(CONFIG_SOUND_MAX98090) += max98090.o maxim_codec.o
drivers/sound/tegra_sound.c new file +49 -0
new file mode 100644
index 00000000000..7c2ed53f5a7
@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2018 Google, LLC
+ * Written by Simon Glass <[email protected]>
+ */
+
+#define LOG_CATEGORY UCLASS_I2S
+
+#include <common.h>
+#include <audio_codec.h>
+#include <dm.h>
+#include <i2s.h>
+#include <misc.h>
+#include <sound.h>
+#include <asm/gpio.h>
+#include "tegra_i2s_priv.h"
+
+static int tegra_sound_setup(struct udevice *dev)
+{
+     struct sound_uc_priv *uc_priv = dev_get_uclass_priv(dev);
+     struct i2s_uc_priv *i2c_priv = dev_get_uclass_priv(uc_priv->i2s);
+     int ret;
+
+     if (uc_priv->setup_done)
+             return -EALREADY;
+     ret = audio_codec_set_params(uc_priv->codec, i2c_priv->id,
+                                  i2c_priv->samplingrate,
+                                  i2c_priv->samplingrate * i2c_priv->rfs,
+                                  i2c_priv->bitspersample,
+                                  i2c_priv->channels);
+     if (ret)
+             return ret;
+     uc_priv->setup_done = true;
+
+     return 0;
+}
+
+static int tegra_sound_play(struct udevice *dev, void *data, uint data_size)
+{
+     struct sound_uc_priv *uc_priv = dev_get_uclass_priv(dev);
+
+     return i2s_tx_data(uc_priv->i2s, data, data_size);
+}
+
+static int tegra_sound_probe(struct udevice *dev)
+{
+     struct sound_uc_priv *uc_priv = dev_get_uclass_priv(dev);
+     struct gpio_desc en_gpio;
+     struct udevice *ahub;
Quoted 8 lines

drivers/sound/tegra_sound.c line 53

Quoted 4 lines
drivers/sound/tegra_sound.c new file +4 -0
+     int ret;
+
+     ret = gpio_request_by_name(dev, "codec-enable-gpio", 0, &en_gpio,
+                                GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);

This looks a bit odd. I am not sure if this is supposed to be optional or not, but there is no checking of the return value although you store it.

Yes. If there is an error then en_gpio will not be set up. Then later on we won't set the GPIO when enabling the codec.

Quoted 3 lines

Is there DT binding documentation that does along with this that describes these properties?

Unfortunately not. The binding is actually board-specific in many cases. I'll do a little series to in these files for all boards including nyan.

Regards,
Simon

#11 lore raw

PATCH v2 6/7 tegra: nyan-big: Enable sound

In reply to a message not in the archive

Enable sound output. With this, 'sound play 1000 400' emits a simple beep.

---

Changes in v2: None

 configs/nyan-big_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)
configs/nyan-big_defconfig +7 -0
index ff574975cdc..009aebe5647 100644
@@ -15,6 +15,7 @@ CONFIG_SPL_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_STASH=y
 CONFIG_BOOTSTAGE_STASH_ADDR=0x83000000
 CONFIG_SYS_STDIO_DEREGISTER=y
+CONFIG_LOG_DEFAULT_LEVEL=7
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SYS_PROMPT="Tegra124 (Nyan-big) # "
 # CONFIG_CMD_IMI is not set
@@ -31,6 +32,8 @@ CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_NFS is not set
 CONFIG_CMD_BMP=y
 CONFIG_CMD_CACHE=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_SOUND=y
 CONFIG_CMD_BOOTSTAGE=y
 CONFIG_CMD_PMIC=y
 CONFIG_CMD_REGULATOR=y
@@ -61,6 +64,10 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_TEGRA=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
+CONFIG_SOUND=y
+CONFIG_I2S=y
+CONFIG_I2S_TEGRA=y
+CONFIG_SOUND_MAX98090=y
 CONFIG_TEGRA114_SPI=y
 CONFIG_TPM_TIS_INFINEON=y
 CONFIG_USB=y
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
#12 lore raw

PATCH v2 7/7 tegra: nyan: Add a README

In reply to a message not in the archive

Add a short note about how to boot U-Boot on Nyan-big using tegrarcm.

---

Changes in v2: None

 board/nvidia/nyan-big/README | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 board/nvidia/nyan-big/README
board/nvidia/nyan-big/README new file +15 -0
new file mode 100644
index 00000000000..0e53d8d92fe
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright 2018 Google LLC
+# Written by Simon Glass <[email protected]>
+
+U-Boot on Nyan
+==============
+
+Nyan-big is supported by mainline U-Boot. This device is based on Tegra124.
+To build it, use the nyan-big config.
+
+To boot it, connect a USB A-A cable from your computer to the back USB port.
+Connect a servo board. Then with t20_rec and warn_rst held down:
+
+   sudo tegrarcm --bct

cbootimage-configs/tegra124/nvidia/norrin/PM370_Hynix_2GB_H5TC4G63AFR_PBA_924MHz_01212014.bct
+ --bootloader u-boot-dtb-tegra.bin --loadaddr 0x80108000
+
+The norrin config is close enough that it works well with Nyan.

Signature · 1 line
2.21.0.392.gf8f6787159e-goog