Skip to contentSkip to conversation

Fix build warning and errors

PATCH In review Dilip Kota 4 participants 7 messages Nov 28, 2019 – Dec 6, 2019

Subsystems (2)
lore
Share & tools
lore

Dilip Kota

author
#0 lore raw

cover Fix build warning and errors

Mark Intel PCIe driver depends on MSI IRQ Domain to fix the below warnings and respective build errors.

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])

Dilip Kota (1):
PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain

 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 1/1 PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain

Kernel compilation fails for i386 architecture as PCI_MSI_IRQ_DOMAIN is not set.

Synopsys DesignWare framework depends on the PCI_MSI_IRQ_DOMAIN. So mark the Intel PCIe controller driver dependency on PCI_MSI_IRQ_DOMAIN as it uses the Synopsys DesignWare framework.

---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/Kconfig +1 -0
index e580ae036d77..d8116ed7f3a4 100644
@@ -212,6 +212,7 @@ config PCIE_ARTPEC6_EP
 config PCIE_INTEL_GW
 	bool "Intel Gateway PCIe host controller support"
 	depends on OF && (X86 || COMPILE_TEST)
+	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	help
 	  Say 'Y' here to enable PCIe Host controller support on Intel
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH v1 1/1] PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain

Quoted 9 lines · Dilip Kota

Kernel compilation fails for i386 architecture as PCI_MSI_IRQ_DOMAIN is not set.

Synopsys DesignWare framework depends on the PCI_MSI_IRQ_DOMAIN. So mark the Intel PCIe controller driver dependency on PCI_MSI_IRQ_DOMAIN as it uses the Synopsys DesignWare framework.

Passes my previously failing kernel configs. Thanks.

Quoted 17 lines
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/Kconfig +1 -0
index e580ae036d77..d8116ed7f3a4 100644
@@ -212,6 +212,7 @@ config PCIE_ARTPEC6_EP
 config PCIE_INTEL_GW
 	bool "Intel Gateway PCIe host controller support"
 	depends on OF && (X86 || COMPILE_TEST)
+	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	help
 	  Say 'Y' here to enable PCIe Host controller support on Intel
Signature · 2 lines
~Randy
Reported-by: Randy Dunlap <[email protected]>
#3 lore raw
In reply to Dilip Kota

[+Bjorn]

Quoted 7 lines · Dilip Kota

Mark Intel PCIe driver depends on MSI IRQ Domain to fix the below warnings and respective build errors.

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])

I don't know yet if we fix it up or I drop the series, given how late this is in the release cycle and very short time this code has been in -next.

Lorenzo

#4 lore raw
Quoted 6 lines · Lorenzo Pieralisi

[+Bjorn]

Quoted 3 lines · Dilip Kota

Mark Intel PCIe driver depends on MSI IRQ Domain to fix the below warnings and respective build errors.

Quoted 8 lines
Quoted 4 lines

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])

I don't know yet if we fix it up or I drop the series, given how late this is in the release cycle and very short time this code has been in -next.

I think given the timing and the holiday we need to drop it for now.

#5 lore raw
In reply to Dilip Kota
Quoted 8 lines · Dilip Kota

Mark Intel PCIe driver depends on MSI IRQ Domain to fix the below warnings and respective build errors.

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])

Quoted 5 lines

Dilip Kota (1):
PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain

 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Hi Dilip,

would you mind squashing this patch into the initial series and repost it (rebase it against current mainline) straight away ? I will rebase it to -rc1 and push it out next week (I am asking since then I am afk for a month so I would like to get your code queued asap, it is ready).

Thanks,
Lorenzo

author
#6 lore raw
Quoted 14 lines · Lorenzo Pieralisi
Quoted 8 lines · Dilip Kota

Mark Intel PCIe driver depends on MSI IRQ Domain to fix the below warnings and respective build errors.

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])

Quoted 5 lines

Dilip Kota (1):
PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain

  drivers/pci/controller/dwc/Kconfig | 1 +
  1 file changed, 1 insertion(+)
Quoted 7 lines

Hi Dilip,

would you mind squashing this patch into the initial series and repost it (rebase it against current mainline) straight away ? I will rebase it to -rc1 and push it out next week (I am asking since then I am afk for a month so I would like to get your code queued asap, it is ready).

Sure, i will do it.
Thanks for prioritizing.

Regards,
Dilip

Quoted 3 lines

Thanks,
Lorenzo