drm/amdgpu: Free user pages if kvmalloc_array fails
Subsystems (2)
PATCH 1/1 drm/amdgpu: Free user pages if kvmalloc_array fails
To cleanup the BOs of bo_list which have got user pages.
Signed-off-by Philip Yang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2 -1
@@ -543,7 +543,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, GFP_KERNEL | __GFP_ZERO);if (!e->user_pages) {DRM_ERROR ("kvmalloc_array failure\n" ); -return -ENOMEM ; + r = -ENOMEM ; + goto out_free_user_pages; } r =amdgpu_ttm_tt_get_user_pages (bo, e->user_pages);
Signature · 1 line
2.35.1
Am 29.04.22 um 02:29 schrieb Philip Yang:
Quoted 3 lines
To cleanup the BOs of
bo_listwhich have got user pages.Signed-off-by Philip Yang <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2
-1@@ -543,7 +543,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, GFP_KERNEL | __GFP_ZERO);if (!e->user_pages) {DRM_ERROR ("kvmalloc_array failure\n" ); -return -ENOMEM ; + r = -ENOMEM ; + goto out_free_user_pages; } r =amdgpu_ttm_tt_get_user_pages (bo, e->user_pages);
Am 2022-04-28 um 20:29 schrieb Philip Yang:
Quoted 3 lines
To cleanup the BOs of
bo_listwhich have got user pages.Signed-off-by Philip Yang <[email protected]>
Reviewed-by Felix Kuehling <[email protected]>
Thanks,
Felix
Quoted 18 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2
-1@@ -543,7 +543,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, GFP_KERNEL | __GFP_ZERO);if (!e->user_pages) {DRM_ERROR ("kvmalloc_array failure\n" ); -return -ENOMEM ; + r = -ENOMEM ; + goto out_free_user_pages; } r =amdgpu_ttm_tt_get_user_pages (bo, e->user_pages);