Skip to contentSkip to conversation

net/ice: fix SCTP RSS configuration

PATCH Applied Junyu Jiang 3 participants 3 messages Oct 20, 2020 – Oct 23, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ice: fix SCTP RSS configuration

This patch configured RSS for sctp with IP address and port as input set.

Fixes 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
---
 drivers/net/ice/ice_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
index 0056da78a..63138d3b9 100644
@@ -2987,7 +2987,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	/* Configure RSS for sctp4 with src/dst addr and port as input set */
 	if (rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) {
-		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_FLOW_HASH_IPV4,
+		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_HASH_SCTP_IPV4,
 				      ICE_FLOW_SEG_HDR_SCTP |
 				      ICE_FLOW_SEG_HDR_IPV4 |
 				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0);
@@ -2998,7 +2998,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	/* Configure RSS for sctp6 with src/dst addr and port as input set */
 	if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {
-		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_FLOW_HASH_IPV6,
+		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_HASH_SCTP_IPV6,
 				      ICE_FLOW_SEG_HDR_SCTP |
 				      ICE_FLOW_SEG_HDR_IPV6 |
 				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0);
Signature · 1 line
2.17.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Junyu Jiang
Sent: Tuesday, October 20, 2020 4:51 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Su, Simei <[email protected]>; Jiang, JunyuX <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration

Quoted 6 lines

This patch configured RSS for sctp with IP address and port as input set.

Fixes 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")

Applied to dpdk-next-net-intel.

Thanks
Qi

Tested-by on v1 1/1
#2 lore raw
In reply to Junyu Jiang

Regards,
Xie Wei

Quoted 46 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Junyu Jiang
Sent: Tuesday, October 20, 2020 4:51 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Su, Simei <[email protected]>; Jiang, JunyuX <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration

This patch configured RSS for sctp with IP address and port as input set.

Fixes 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
---
 drivers/net/ice/ice_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +1 -1
index 0056da78a..63138d3b9 100644
@@ -2987,7 +2987,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	/* Configure RSS for sctp4 with src/dst addr and port as input set */
 	if (rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) {
-		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,
 ICE_FLOW_HASH_IPV4,
+		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,
 ICE_HASH_SCTP_IPV4,
 				      ICE_FLOW_SEG_HDR_SCTP |
drivers/net/ice/ice_ethdev.c +0 -2
 				      ICE_FLOW_SEG_HDR_IPV4 |
 				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0); @@
-2998,7 +2998,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	/* Configure RSS for sctp6 with src/dst addr and port as input set */
 	if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {
-		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,

ICE_FLOW_HASH_IPV6,

drivers/net/ice/ice_ethdev.c +1 -0
+		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,

ICE_HASH_SCTP_IPV6,

drivers/net/ice/ice_ethdev.c +0 -1
 				      ICE_FLOW_SEG_HDR_SCTP |
 				      ICE_FLOW_SEG_HDR_IPV6 |
 				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0);
--

2.17.1