Skip to contentSkip to conversation

extcon: Add EXTCON_DISP_CVBS and EXTCON_DISP_EDP

PATCH Applied Michael Wu 2 participants 4 messages Jul 8, 2022 – Jul 11, 2022 External connector subsystem (extcon)

lore
Share & tools
lore

Michael Wu

author
#0 lore raw

PATCH 1/1 extcon: Add EXTCON_DISP_CVBS and EXTCON_DISP_EDP

Add EXTCON_DISP_CVBS for Composite Video Broadcast Signal. Add EXTCON_DISP_EDP for Embedded Display Port

[1] https://en.wikipedia.org/wiki/Composite_video
[2] https://en.wikipedia.org/wiki/DisplayPort#eDP

---
 drivers/extcon/extcon.c | 10 ++++++++++
 include/linux/extcon.h  |  2 ++
 2 files changed, 12 insertions(+)
drivers/extcon/extcon.c +10 -0
index d3a32b8064994..774607a616f7b 100644
@@ -167,6 +167,16 @@ static const struct __extcon_info {
 		.id = EXTCON_DISP_HMD,
 		.name = "HMD",
 	},
+	[EXTCON_DISP_CVBS] = {
+		.type = EXTCON_TYPE_DISP,
+		.id = EXTCON_DISP_CVBS,
+		.name = "CVBS",
+	},
+	[EXTCON_DISP_EDP] = {
+		.type = EXTCON_TYPE_DISP,
+		.id = EXTCON_DISP_EDP,
+		.name = "EDP",
+	},
 
 	/* Miscellaneous external connector */
 	[EXTCON_DOCK] = {
include/linux/extcon.h +2 -0
index 685401d94d398..3c45c3846fe94 100644
@@ -76,6 +76,8 @@
 #define EXTCON_DISP_VGA		43	/* Video Graphics Array */
 #define EXTCON_DISP_DP		44	/* Display Port */
 #define EXTCON_DISP_HMD		45	/* Head-Mounted Display */
+#define EXTCON_DISP_CVBS	46	/* Composite Video Broadcast Signal */
+#define EXTCON_DISP_EDP		47	/* Embedded Display Port */
 
 /* Miscellaneous external connector */
 #define EXTCON_DOCK		60
Signature · 1 line
2.29.0
Applied
#1 lore raw
Quoted 38 lines · Michael Wu

Add EXTCON_DISP_CVBS for Composite Video Broadcast Signal. Add EXTCON_DISP_EDP for Embedded Display Port

[1] https://en.wikipedia.org/wiki/Composite_video
[2] https://en.wikipedia.org/wiki/DisplayPort#eDP

---
 drivers/extcon/extcon.c | 10 ++++++++++
 include/linux/extcon.h  |  2 ++
 2 files changed, 12 insertions(+)
drivers/extcon/extcon.c +10 -0
index d3a32b8064994..774607a616f7b 100644
@@ -167,6 +167,16 @@ static const struct __extcon_info {
 		.id = EXTCON_DISP_HMD,
 		.name = "HMD",
 	},
+	[EXTCON_DISP_CVBS] = {
+		.type = EXTCON_TYPE_DISP,
+		.id = EXTCON_DISP_CVBS,
+		.name = "CVBS",
+	},
+	[EXTCON_DISP_EDP] = {
+		.type = EXTCON_TYPE_DISP,
+		.id = EXTCON_DISP_EDP,
+		.name = "EDP",
+	},
 
 	/* Miscellaneous external connector */
 	[EXTCON_DOCK] = {
include/linux/extcon.h +0 -0
index 685401d94d398..3c45c3846fe94 100644

include/linux/extcon.h line 83

Quoted 8 lines
include/linux/extcon.h +2 -0
@@ -76,6 +76,8 @@
 #define EXTCON_DISP_VGA		43	/* Video Graphics Array */
 #define EXTCON_DISP_DP		44	/* Display Port */
 #define EXTCON_DISP_HMD		45	/* Head-Mounted Display */
+#define EXTCON_DISP_CVBS	46	/* Composite Video Broadcast Signal */
+#define EXTCON_DISP_EDP		47	/* Embedded Display Port */
 
 /* Miscellaneous external connector */
 #define EXTCON_DOCK		60

Applied it. Thanks.

Do you have a plan to send extcon driver with newly added connector type?

Signature · 3 lines
Best Regards,
Samsung Electronics
Chanwoo Choi
author
#2 lore raw
Quoted 45 lines · Chanwoo Choi
Quoted 44 lines · Michael Wu

Add EXTCON_DISP_CVBS for Composite Video Broadcast Signal. Add EXTCON_DISP_EDP for Embedded Display Port

[1] https://en.wikipedia.org/wiki/Composite_video
[2] https://en.wikipedia.org/wiki/DisplayPort#eDP

---
  drivers/extcon/extcon.c | 10 ++++++++++
  include/linux/extcon.h  |  2 ++
  2 files changed, 12 insertions(+)
drivers/extcon/extcon.c +10 -0
index d3a32b8064994..774607a616f7b 100644
@@ -167,6 +167,16 @@ static const struct __extcon_info {
  		.id = EXTCON_DISP_HMD,
  		.name = "HMD",
  	},
+	[EXTCON_DISP_CVBS] = {
+		.type = EXTCON_TYPE_DISP,
+		.id = EXTCON_DISP_CVBS,
+		.name = "CVBS",
+	},
+	[EXTCON_DISP_EDP] = {
+		.type = EXTCON_TYPE_DISP,
+		.id = EXTCON_DISP_EDP,
+		.name = "EDP",
+	},
 
  	/* Miscellaneous external connector */
  	[EXTCON_DOCK] = {
include/linux/extcon.h +2 -0
index 685401d94d398..3c45c3846fe94 100644
@@ -76,6 +76,8 @@
  #define EXTCON_DISP_VGA		43	/* Video Graphics Array */
  #define EXTCON_DISP_DP		44	/* Display Port */
  #define EXTCON_DISP_HMD		45	/* Head-Mounted Display */
+#define EXTCON_DISP_CVBS	46	/* Composite Video Broadcast Signal */
+#define EXTCON_DISP_EDP		47	/* Embedded Display Port */
 
Quoted 7 lines

include/linux/extcon.h line 83

Quoted 2 lines
include/linux/extcon.h +0 -0
  /* Miscellaneous external connector */
  #define EXTCON_DOCK		60

Applied it. Thanks.

Do you have a plan to send extcon driver with newly added connector type?

Hi Chanwoo,
Thank you for the inviting. I'd like to send more patches for extcon, unfortunately the SoCs I'm using only covers CVBS and EDP among the new connector types. Once I had a chance to verify a new type, I'll surely send it here. BTW, should I send a patch-v2 with 'Reviewed-by Chanwoo Choi <[email protected]>' or 'Acked-by Chanwoo Choi <[email protected]>', or should I just wait?
Thanks again.

Signature · 2 lines
Regards,
Michael Wu
#3 lore raw
Quoted 55 lines · Michael Wu
Quoted 45 lines · Chanwoo Choi
Quoted 44 lines · Michael Wu

Add EXTCON_DISP_CVBS for Composite Video Broadcast Signal. Add EXTCON_DISP_EDP for Embedded Display Port

[1] https://en.wikipedia.org/wiki/Composite_video
[2] https://en.wikipedia.org/wiki/DisplayPort#eDP

---
  drivers/extcon/extcon.c | 10 ++++++++++
  include/linux/extcon.h  |  2 ++
  2 files changed, 12 insertions(+)
drivers/extcon/extcon.c +10 -0
index d3a32b8064994..774607a616f7b 100644
@@ -167,6 +167,16 @@ static const struct __extcon_info {
             .id = EXTCON_DISP_HMD,
             .name = "HMD",
     },
+    [EXTCON_DISP_CVBS] = {
+            .type = EXTCON_TYPE_DISP,
+            .id = EXTCON_DISP_CVBS,
+            .name = "CVBS",
+    },
+    [EXTCON_DISP_EDP] = {
+            .type = EXTCON_TYPE_DISP,
+            .id = EXTCON_DISP_EDP,
+            .name = "EDP",
+    },
 
     /* Miscellaneous external connector */
     [EXTCON_DOCK] = {
include/linux/extcon.h +2 -0
index 685401d94d398..3c45c3846fe94 100644
@@ -76,6 +76,8 @@
  #define EXTCON_DISP_VGA            43      /* Video Graphics Array */
  #define EXTCON_DISP_DP             44      /* Display Port */
  #define EXTCON_DISP_HMD            45      /* Head-Mounted Display */
+#define EXTCON_DISP_CVBS    46      /* Composite Video Broadcast Signal */
+#define EXTCON_DISP_EDP             47      /* Embedded Display Port */
 
Quoted 7 lines

include/linux/extcon.h line 83

Quoted 2 lines
include/linux/extcon.h +0 -0
  /* Miscellaneous external connector */
  #define EXTCON_DOCK                60

Applied it. Thanks.

Do you have a plan to send extcon driver with newly added connector type?

Quoted 8 lines

Hi Chanwoo,
Thank you for the inviting. I'd like to send more patches for extcon, unfortunately the SoCs I'm using only covers CVBS and EDP among the new connector types. Once I had a chance to verify a new type, I'll surely send it here.
BTW, should I send a patch-v2 with 'Reviewed-by Chanwoo Choi <[email protected]>' or 'Acked-by Chanwoo Choi <[email protected]>', or should I just wait?

No, I already applied this patch to extcon-next branch[1]. [1]https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next

Your patch will be merged into v5.20-rc1.

Thanks.

Signature · 2 lines
Best Regards,
Chanwoo Choi