configure: updated m4 macro check in configure.ac
PATCH 1/1 configure: updated m4 macro check in configure.ac
Added m4 check for XORG_DRIVER_CHECK_EXT macro definition. Updated m4 fatal messages to give better hint on how to resolve error when xorg macros are missing. Previously, configure would continue in spite of the missing macros and the build would fail for syntax errors.
--- configure.ac | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
configure.ac +7 -1
@@ -36,10 +36,16 @@ AM_MAINTAINER_MODE # Require X.Org macros 1.8 or later for MAN_SUBSTS set by XORG_MANPAGE_SECTIONS m4_ifndef([XORG_MACROS_VERSION], - [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen])]) + [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen. + Try "apt-get install xutils-dev" or "yum install xorg-x11-util-macros"])]) XORG_MACROS_VERSION(1.8) XORG_DEFAULT_OPTIONS +# Require X.Org server macros (i.e. XORG_DRIVER_CHECK_EXT) to check for required modules +m4_ifndef([XORG_DRIVER_CHECK_EXT], + [m4_fatal([must install xorg-server macros before running autoconf/autogen. + Try "apt-get install xserver-xorg-dev" or "yum install xorg-x11-server-devel"])]) + # Initialize libtool AC_DISABLE_STATIC AC_PROG_LIBTOOL
Signature · 1 line
1.7.3.3
Quoted 4 lines · U. Artie Eoff
Added m4 check for
XORG_DRIVER_CHECK_EXTmacro definition. Updated m4 fatal messages to give better hint on how to resolve error when xorg macros are missing. Previously, configure would continue in spite of the missing macros and the build would fail for syntax errors.
Thanks so much, Artie!
I've now pushed this change out.
Only just after pushing it did I notice that the commit message is all one long line. No big deal for this commit, but in future commits, if you wrap that paragraph to fit within 80 columns then some tools will display the commit message more cleanly.
Thanks again,
-Carl
Signature · 1 line
[email protected]
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Carl Worth
Quoted 4 lines · U. Artie Eoff
Added m4 check for
XORG_DRIVER_CHECK_EXTmacro definition. Updated m4 fatal messages to give better hint on how to resolve error when xorg macros are missing. Previously, configure would continue in spite of the missing macros and the build would fail for syntax errors.
Quoted 8 lines
Thanks so much, Artie!
I've now pushed this change out.
Only just after pushing it did I notice that the commit message is all one long line. No big deal for this commit, but in future commits, if you wrap that paragraph to fit within 80 columns then some tools will display the commit message more cleanly.
And the duplicated string without mentioning the upstream source... -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Dear Artie,
Am Dienstag, den 21.12.2010, 15:10 -0700 schrieb U. Artie Eoff:
Quoted 13 lines
Added m4 check for
XORG_DRIVER_CHECK_EXTmacro definition. Updated m4 fatal messages to give better hint on how to resolve error when xorg macros are missing. Previously, configure would continue in spite of the missing macros and the build would fail for syntax errors.--- configure.ac | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)configure.ac +0
-0
configure.ac AM_MAINTAINER_MODE · line 40
Quoted 6 lines
configure.ac +2
-1@@ -36,10 +36,16 @@ AM_MAINTAINER_MODE # Require X.Org macros 1.8 or later for MAN_SUBSTS set by XORG_MANPAGE_SECTIONS m4_ifndef([XORG_MACROS_VERSION], - [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen])]) + [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen. + Try "apt-get install xutils-dev" or "yum install xorg-x11-util-macros"])])
aptitude is the recommended package manager for Debian [1].
configure.ac AM_MAINTAINER_MODE · line 51
Quoted 11 lines
configure.ac +5
-0XORG_MACROS_VERSION(1.8) XORG_DEFAULT_OPTIONS +# Require X.Org server macros (i.e. XORG_DRIVER_CHECK_EXT) to check for required modules +m4_ifndef([XORG_DRIVER_CHECK_EXT], + [m4_fatal([must install xorg-server macros before running autoconf/autogen. + Try "apt-get install xserver-xorg-dev" or "yum install xorg-x11-server-devel"])]) + # Initialize libtool AC_DISABLE_STATIC AC_PROG_LIBTOOL
Thanks,
Paul
[1] http://www.debian.org/doc/manuals/debian-faq/ch-uptodate.en.html (9.1.1)
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Paul Menzel
aptitudeis the recommended package manager for Debian [1].
I don't believe that's true. But it's kind of irrelevant anyway, it should be enough to give the name of the package to install.
Cheers,
Julien
Quoted 18 lines
-----Original Message-----
From: intel-gfx-bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org [mailto:intel-gfx- [email protected]] On Behalf Of Julien Cristau
Sent: Tuesday, December 21, 2010 3:54 PM
To: Paul Menzel
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] configure: updated m4 macro check in configure.acQuoted 1 line · Paul Menzel
aptitudeis the recommended package manager for Debian [1].I don't believe that's true. But it's kind of irrelevant anyway, it should be enough to give the name of the package to install.
Quoted 6 lines
Cheers,
Julien
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
I agree, it is irrelevant... I'll remove the package manager references and mention the upstream source, too.
Thanks,
U. Artie Eoff