mmc: block: Change MMC_IOC_MAX_BYTES

PATCH Applied Jeremy Kim 3 participants 3 messages Oct 19, 2016 – Oct 21, 2016 MMC, SD and SDIO

lore

Share & tools

lore

Jeremy Kim

author

2016-10-19 15:42 UTC #0 lore raw

PATCH 1/1 mmc: block: Change MMC_IOC_MAX_BYTES

Quoted 1 line

From 27d46f5697434542ad9cafbc6a9630dc14915f91 Mon Sep 17 00:00:00 2001

From: Jeonghan Kim <[email protected]>
Date: Wed, 19 Oct 2016 19:48:02 +0900
Subject: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES

It is used for limitation of buffer size during IOCTL such as FFU. However, eMMC FW size is bigger than (512L*256).
(For instance, currently, Samsung eMMC FW size is over 300KB.) So, it needs to increase to execute FFU.

Signed-off-by Jeonghan Kim <[email protected]>

---
 include/uapi/linux/mmc/ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/uapi/linux/mmc/ioctl.h +1 -1

index 7e385b8..700a551 100644
@@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
  * is enforced per ioctl call.  For larger data transfers, use the normal
  * block device operations.
  */
-#define MMC_IOC_MAX_BYTES  (512L * 256)
+#define MMC_IOC_MAX_BYTES  (512L * 1024)
 #define MMC_IOC_MAX_CMDS    255
 #endif /* LINUX_MMC_IOCTL_H */

--
1.9.1

Jaehoon Chung

Acked-by on v1 1/1

2016-10-21 06:38 UTC #1 lore raw

Hi,

Quoted 11 lines · Jeremy Kim

Quoted 1 line
From 27d46f5697434542ad9cafbc6a9630dc14915f91 Mon Sep 17 00:00:00 2001
From: Jeonghan Kim <[email protected]>
Date: Wed, 19 Oct 2016 19:48:02 +0900
Subject: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
It is used for limitation of buffer size during IOCTL such as FFU. However, eMMC FW size is bigger than (512L*256).
(For instance, currently, Samsung eMMC FW size is over 300KB.) So, it needs to increase to execute FFU.
Signed-off-by Jeonghan Kim <[email protected]>

Looks good to me.

Acked-by Jaehoon Chung <[email protected]>

Best Regards,
Jaehoon Chung

Quoted 22 lines

---
 include/uapi/linux/mmc/ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/uapi/linux/mmc/ioctl.h +1 -2

index 7e385b8..700a551 100644
@@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
  * is enforced per ioctl call.  For larger data transfers, use the normal
  * block device operations.
  */
-#define MMC_IOC_MAX_BYTES  (512L * 256)
+#define MMC_IOC_MAX_BYTES  (512L * 1024)
 #define MMC_IOC_MAX_CMDS    255
 #endif /* LINUX_MMC_IOCTL_H */
--

1.9.1

Ulf Hansson

Applied

2016-10-21 08:21 UTC #2 lore raw

In reply to Jeremy Kim

Quoted 11 lines · Jeremy Kim

From 27d46f5697434542ad9cafbc6a9630dc14915f91 Mon Sep 17 00:00:00 2001
From: Jeonghan Kim <[email protected]>
Date: Wed, 19 Oct 2016 19:48:02 +0900
Subject: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
It is used for limitation of buffer size during IOCTL such as FFU. However, eMMC FW size is bigger than (512L*256).
(For instance, currently, Samsung eMMC FW size is over 300KB.) So, it needs to increase to execute FFU.
Signed-off-by Jeonghan Kim <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

Quoted 20 lines

---
 include/uapi/linux/mmc/ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/uapi/linux/mmc/ioctl.h +1 -2

index 7e385b8..700a551 100644
@@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
  * is enforced per ioctl call.  For larger data transfers, use the normal
  * block device operations.
  */
-#define MMC_IOC_MAX_BYTES  (512L * 256)
+#define MMC_IOC_MAX_BYTES  (512L * 1024)
 #define MMC_IOC_MAX_CMDS    255
 #endif /* LINUX_MMC_IOCTL_H */
--

1.9.1