Skip to contentSkip to conversation

media: ipu6: Remove duplicated include in ipu6-dma.h

PATCH In review Yang Li 2 participants 3 messages Nov 11, 2024

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 media: ipu6: Remove duplicated include in ipu6-dma.h

The header files linux/iova.h is included twice in ipu6-dma.h, so one inclusion of each can be removed.

./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more than once.

---
 drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
 1 file changed, 1 deletion(-)
drivers/media/pci/intel/ipu6/ipu6-dma.h +0 -1
index b51244add9e6..a902eec5c07a 100644
@@ -7,7 +7,6 @@
 #include <linux/dma-map-ops.h>
 #include <linux/dma-mapping.h>
 #include <linux/iova.h>
-#include <linux/iova.h>
 #include <linux/scatterlist.h>
 #include <linux/types.h>
 
Signature · 1 line
2.32.0.3.g01195cf9f
Reviewed-by on v1 1/1
#1 lore raw

Li,

Thanks for the patch.

Quoted 8 lines · Yang Li

The header files linux/iova.h is included twice in ipu6-dma.h, so one inclusion of each can be removed.

./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more than once.

It'd better to add:

Fixes 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")
Quoted 11 lines
---
 drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
 1 file changed, 1 deletion(-)
drivers/media/pci/intel/ipu6/ipu6-dma.h +0 -0
index b51244add9e6..a902eec5c07a 100644

drivers/media/pci/intel/ipu6/ipu6-dma.h line 12

Quoted 7 lines
drivers/media/pci/intel/ipu6/ipu6-dma.h +0 -1
@@ -7,7 +7,6 @@
 #include <linux/dma-map-ops.h>
 #include <linux/dma-mapping.h>
 #include <linux/iova.h>
-#include <linux/iova.h>
 #include <linux/scatterlist.h>
 #include <linux/types.h>
 
Signature · 2 lines
Best regards,
Bingbu Cao
#2 lore raw
Quoted 8 lines · Bingbu Cao

Li,

Thanks for the patch.

Quoted 3 lines · Yang Li

The header files linux/iova.h is included twice in ipu6-dma.h, so one inclusion of each can be removed.

Quoted 8 lines
Quoted 5 lines

./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more than once.

It'd better to add:

Fixes 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")

Oops, I just noticed the commit above is on the road... You can correct the hash after it is applied.

Quoted 23 lines
Quoted 12 lines
---
 drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
 1 file changed, 1 deletion(-)
drivers/media/pci/intel/ipu6/ipu6-dma.h +0 -0
index b51244add9e6..a902eec5c07a 100644

drivers/media/pci/intel/ipu6/ipu6-dma.h line 12

Quoted 7 lines
drivers/media/pci/intel/ipu6/ipu6-dma.h +0 -1
@@ -7,7 +7,6 @@
 #include <linux/dma-map-ops.h>
 #include <linux/dma-mapping.h>
 #include <linux/iova.h>
-#include <linux/iova.h>
 #include <linux/scatterlist.h>
 #include <linux/types.h>
 
Signature · 2 lines
Best regards,
Bingbu Cao