Skip to contentSkip to conversation

kbuild: dummy-tools: support make MPROFILE_KERNEL checks work on BE

PATCH In review Jiri Slaby (SUSE) 2 participants 3 messages Aug 29, 2023 – Aug 30, 2023 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: dummy-tools: support make MPROFILE_KERNEL checks work on BE

From: Jiri Slaby <[email protected]>

Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL checks for ppc") added support for ppc64le's checks for -mprofile-kernel.

Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big endian ELFv2 kernels") added support for -mprofile-kernel even on big-endian ppc.

So lift the check in gcc-check-mprofile-kernel.sh to support big-endian too.

Cc Masahiro Yamada <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Nicolas Schier <[email protected]>
Cc Naveen N. Rao <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Michal Kubecek <[email protected]>
---
 scripts/dummy-tools/gcc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
scripts/dummy-tools/gcc +1 -2
index 1db1889f6d81..07f6dc4c5cf6 100755
@@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
 	fi
 
 	# For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
-	if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
-		arg_contain -mprofile-kernel "$@"; then
+	if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; then
 		if ! test -t 0 && ! grep -q notrace; then
 			echo "_mcount"
 		fi
Signature · 1 line
2.42.0
author
#1 lore raw

I deleted too few: the subject should read:
kbuild: dummy-tools: make MPROFILE_KERNEL checks work on BE

I will submit v2 if there are no other objections.

Quoted 40 lines · Jiri Slaby (SUSE)

From: Jiri Slaby <[email protected]>

Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL checks for ppc") added support for ppc64le's checks for -mprofile-kernel.

Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big endian ELFv2 kernels") added support for -mprofile-kernel even on big-endian ppc.

So lift the check in gcc-check-mprofile-kernel.sh to support big-endian too.

Cc Masahiro Yamada <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Nicolas Schier <[email protected]>
Cc Naveen N. Rao <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Michal Kubecek <[email protected]>
---
  scripts/dummy-tools/gcc | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
scripts/dummy-tools/gcc +1 -2
index 1db1889f6d81..07f6dc4c5cf6 100755
@@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
  	fi
 
  	# For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
-	if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
-		arg_contain -mprofile-kernel "$@"; then
+	if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; then
  		if ! test -t 0 && ! grep -q notrace; then
  			echo "_mcount"
  		fi
Signature · 2 lines
js
suse labs
#2 lore raw
Quoted 5 lines · Jiri Slaby

I deleted too few: the subject should read:
kbuild: dummy-tools: make MPROFILE_KERNEL checks work on BE

I will submit v2 if there are no other objections.

I have no objection.

If there is nothing else to fix,
I will locally fix the subject, and apply.

I also see a similar patch from Michal Suchanek, but I like this one because the commit log has a good explanation.

Quoted 46 lines · Jiri Slaby (SUSE)
Quoted 31 lines

From: Jiri Slaby <[email protected]>

Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL checks for ppc") added support for ppc64le's checks for -mprofile-kernel.

Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big endian ELFv2 kernels") added support for -mprofile-kernel even on big-endian ppc.

So lift the check in gcc-check-mprofile-kernel.sh to support big-endian too.

Cc Masahiro Yamada <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Nicolas Schier <[email protected]>
Cc Naveen N. Rao <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Michal Kubecek <[email protected]>
---
  scripts/dummy-tools/gcc | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
scripts/dummy-tools/gcc +0 -0
index 1db1889f6d81..07f6dc4c5cf6 100755

scripts/dummy-tools/gcc if arg_contain -S "$@"; then · line 91

Quoted 9 lines
scripts/dummy-tools/gcc +1 -2
@@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
      fi
 
      # For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
-     if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
-             arg_contain -mprofile-kernel "$@"; then
+     if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; then
              if ! test -t 0 && ! grep -q notrace; then
                      echo "_mcount"
              fi

--
js
suse labs

Signature · 2 lines
Best Regards
Masahiro Yamada