crypto/sahara: Adjustments for sahara_probe()
Subsystems (2)
cover crypto/sahara: Adjustments for sahara_probe()
From: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:30:28 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation Improve a size determination
drivers/crypto/sahara.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.16.1
PATCH 1/2 crypto: sahara: Delete an error message for a failed memory allocation in sahara_probe()
From: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:10:03 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
--- drivers/crypto/sahara.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/crypto/sahara.c +1 -3
@@ -1398,10 +1398,8 @@ static int sahara_probe(struct platform_device *pdev)int i; dev =devm_kzalloc (&pdev->dev,sizeof (struct sahara_dev ),GFP_KERNEL ); -if (dev =NULL ) { -dev_err (&pdev->dev,"unable to alloc data struct.\n" ); +if (!dev)return -ENOMEM ; - } dev->device = &pdev->dev;platform_set_drvdata (pdev, dev);
Signature · 1 line
2.16.1
PATCH 2/2 crypto: sahara: Improve a size determination in sahara_probe()
In reply to SF Markus ElfringFrom: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:14:05 +0100
Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
--- drivers/crypto/sahara.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/sahara.c +1 -1
@@ -1397,7 +1397,7 @@ static int sahara_probe(struct platform_device *pdev)int err;int i; - dev =devm_kzalloc (&pdev->dev,sizeof (struct sahara_dev ),GFP_KERNEL ); + dev =devm_kzalloc (&pdev->dev,sizeof (*dev),GFP_KERNEL );if (!dev)return -ENOMEM ;
Signature · 1 line
2.16.1
Herbert Xu
maintainerQuoted 6 lines · SF Markus Elfring
From: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:30:28 +0100Two update suggestions were taken into account
from static source code analysis.
Quoted 6 lines
Markus Elfring (2):
Delete an error message for a failed memory allocation Improve a size determinationdrivers/crypto/sahara.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
All applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt