Skip to contentSkip to conversation

irqchip/wpcm450: Drop COMPILE_TEST

PATCH In review Marc Zyngier 2 participants 4 messages Apr 8, 2021 irqchip drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip/wpcm450: Drop COMPILE_TEST

This driver is (for now) ARM specific, and currently doesn't build with a variety of architectures (ia64, RISC-V, x86_64 at the very least).

Drop COMPILE_TEST from Kconfig until it gets sorted out.

---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/Kconfig +1 -1
index 38ad9dcf42c3..715eb4366e35 100644
@@ -579,7 +579,7 @@ config MST_IRQ
 
 config WPCM450_AIC
 	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
-	depends on ARCH_WPCM450 || COMPILE_TEST
+	depends on ARCH_WPCM450
 	help
 	  Support for the interrupt controller in the Nuvoton WPCM450 BMC SoC.
 
Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Marc Zyngier

This driver is (for now) ARM specific, and currently doesn't build with a variety of architectures (ia64, RISC-V, x86_64 at the very least).

Drop COMPILE_TEST from Kconfig until it gets sorted out.

---

drivers/irqchip/Kconfig config MST_IRQ · line 582

Quoted 13 lines
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/Kconfig +1 -1
index 38ad9dcf42c3..715eb4366e35 100644
@@ -579,7 +579,7 @@ config MST_IRQ
 
 config WPCM450_AIC
 	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
-	depends on ARCH_WPCM450 || COMPILE_TEST
+	depends on ARCH_WPCM450

I guess I could use (COMPILE_TEST && ARM) or something…

Thanks,
Jonathan

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 5 lines · Jonathan Neuschäfer
Quoted 4 lines · Marc Zyngier

This driver is (for now) ARM specific, and currently doesn't build with a variety of architectures (ia64, RISC-V, x86_64 at the very least).

Quoted 8 lines
Quoted 6 lines

Drop COMPILE_TEST from Kconfig until it gets sorted out.

---

Thanks for that.

Quoted 10 lines
Quoted 10 lines
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/Kconfig +0 -0
index 38ad9dcf42c3..715eb4366e35 100644
@@ -579,7 +579,7 @@ config MST_IRQ
 
Quoted 6 lines

drivers/irqchip/Kconfig config MST_IRQ · line 582

Quoted 4 lines
drivers/irqchip/Kconfig +1 -1
 config WPCM450_AIC
 	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
-	depends on ARCH_WPCM450 || COMPILE_TEST
+	depends on ARCH_WPCM450

I guess I could use (COMPILE_TEST && ARM) or something…

One of the major interest of COMPILE_TEST to be able to check code cross-architecture. For code that cannot compile cross-architecture, I'm not sure it matters much.

We can achieve the same result by enabling multi-platform builds (and this system should probably end-up in multi_v5_defconfig).

        M.
Signature · 6 lines
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw
Quoted 1 line · Marc Zyngier

On 2021-04-08 09:45, Jonathan Neuschäfer wrote:

[...]

Quoted 8 lines
Quoted 1 line

I guess I could use (COMPILE_TEST && ARM) or something…

One of the major interest of COMPILE_TEST to be able to check code cross-architecture. For code that cannot compile cross-architecture, I'm not sure it matters much.

We can achieve the same result by enabling multi-platform builds (and this system should probably end-up in multi_v5_defconfig).

Alright, thanks for the explanation.

Jonathan

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel