Skip to contentSkip to conversation

ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

PATCH Superseded Sachin Kamat 2 participants 4 messages Jul 24, 2013

Subsystems (2)
Arm (32-bit) Arm Samsung Exynos

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Sachin Kamat

author
#0 lore raw

PATCH v3 1/1 ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

With the recent cleanup in Exynos platform code notably commits 17859bec ("ARM: EXYNOS: Do not select legacy Kconfig symbols any more") and b9222210 ("ARM: EXYNOS: Remove mach/gpio.h"), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs like Exynos4412 which have more than the default number of GPIOs. Thus define this number in KConfig file which takes care of current SoC requirements and provides scope for GPIO expanders. Without this patch we get the following errors during boot:

gpiochip_add: gpios 251..258 (gpv0) failed to register samsung-pinctrl 106e0000.pinctrl: failed to register gpio_chip gpv0, error code: -22
samsung-pinctrl: probe of 106e0000.pinctrl failed with error -22

Signed-off-by Sachin Kamat <[email protected]>
Cc Tomasz Figa <[email protected]>

---
Changes since v2:
Changed the default number to 512 to accomodate GPIO exapnders.

---
 arch/arm/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +1 -0
index ccc388d..b3c4fa4 100644
@@ -1601,6 +1601,7 @@ config ARCH_NR_GPIO
 	int
 	default 1024 if ARCH_SHMOBILE || ARCH_TEGRA
 	default 512 if SOC_OMAP5
+	default 512 if ARCH_EXYNOS
 	default 512 if ARCH_KEYSTONE
 	default 392 if ARCH_U8500
 	default 352 if ARCH_VT8500
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v3 1/1 ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

Quoted 30 lines · Sachin Kamat

With the recent cleanup in Exynos platform code notably commits 17859bec ("ARM: EXYNOS: Do not select legacy Kconfig symbols any more") and b9222210 ("ARM: EXYNOS: Remove mach/gpio.h"), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs like Exynos4412 which have more than the default number of GPIOs. Thus define this number in KConfig file which takes care of current SoC requirements and provides scope for GPIO expanders. Without this patch we get the following
errors during boot:

gpiochip_add: gpios 251..258 (gpv0) failed to register samsung-pinctrl 106e0000.pinctrl: failed to register gpio_chip gpv0, error code: -22
samsung-pinctrl: probe of 106e0000.pinctrl failed with error -22

Signed-off-by Sachin Kamat <[email protected]>
Cc Tomasz Figa <[email protected]>

---
Changes since v2:
Changed the default number to 512 to accomodate GPIO exapnders.

---
 arch/arm/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index ccc388d..b3c4fa4 100644

arch/arm/Kconfig config ARCH_NR_GPIO · line 1605

Quoted 5 lines
arch/arm/Kconfig +1 -0
@@ -1601,6 +1601,7 @@ config ARCH_NR_GPIO
 	int
 	default 1024 if ARCH_SHMOBILE || ARCH_TEGRA
 	default 512 if SOC_OMAP5
+	default 512 if ARCH_EXYNOS
 	default 512 if ARCH_KEYSTONE

+ default 512 if ARCH_EXYNOS || ARCH_KEYSTONE || SOC_OMAP5 ?

Thanks,
Kukjin

Quoted 4 lines
arch/arm/Kconfig +0 -1
 	default 392 if ARCH_U8500
 	default 352 if ARCH_VT8500
--

1.7.9.5

author
#2 lore raw

PATCH v3 1/1 ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

Quoted 26 lines · Kukjin Kim
Quoted 25 lines · Sachin Kamat

With the recent cleanup in Exynos platform code notably commits 17859bec ("ARM: EXYNOS: Do not select legacy Kconfig symbols any more") and b9222210 ("ARM: EXYNOS: Remove mach/gpio.h"), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs like Exynos4412 which have more than the default number of GPIOs. Thus define this number in KConfig file which takes care of current SoC requirements and provides scope for GPIO expanders. Without this patch we get the following
errors during boot:

gpiochip_add: gpios 251..258 (gpv0) failed to register samsung-pinctrl 106e0000.pinctrl: failed to register gpio_chip gpv0, error code: -22
samsung-pinctrl: probe of 106e0000.pinctrl failed with error -22

Signed-off-by Sachin Kamat <[email protected]>
Cc Tomasz Figa <[email protected]>

---
Changes since v2:
Changed the default number to 512 to accomodate GPIO exapnders.

---
 arch/arm/Kconfig |    1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

arch/arm/Kconfig config ARCH_NR_GPIO · line 1605

Quoted 10 lines
arch/arm/Kconfig +1 -0
index ccc388d..b3c4fa4 100644
@@ -1601,6 +1601,7 @@ config ARCH_NR_GPIO
      int
      default 1024 if ARCH_SHMOBILE || ARCH_TEGRA
      default 512 if SOC_OMAP5
+     default 512 if ARCH_EXYNOS
      default 512 if ARCH_KEYSTONE

+ default 512 if ARCH_EXYNOS || ARCH_KEYSTONE || SOC_OMAP5 ?

Looks good. Do you want me to re-send this?

Signature · 2 lines
With warm regards,
Sachin
#3 lore raw

PATCH v3 1/1 ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

Quoted 44 lines · Sachin Kamat
Quoted 6 lines · Kukjin Kim
Quoted 5 lines · Sachin Kamat

With the recent cleanup in Exynos platform code notably commits 17859bec ("ARM: EXYNOS: Do not select legacy Kconfig symbols any more") and b9222210 ("ARM: EXYNOS: Remove mach/gpio.h"), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs

like

Quoted 1 line
Quoted 1 line

Exynos4412 which have more than the default number of GPIOs. Thus

define

Quoted 1 line
Quoted 1 line

this number in KConfig file which takes care of current SoC

requirements

Quoted 18 lines
Quoted 18 lines

and provides scope for GPIO expanders. Without this patch we get the following
errors during boot:

gpiochip_add: gpios 251..258 (gpv0) failed to register samsung-pinctrl 106e0000.pinctrl: failed to register gpio_chip gpv0, error code: -22
samsung-pinctrl: probe of 106e0000.pinctrl failed with error -22

Signed-off-by Sachin Kamat <[email protected]>
Cc Tomasz Figa <[email protected]>

---
Changes since v2:
Changed the default number to 512 to accomodate GPIO exapnders.

---
 arch/arm/Kconfig |    1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

arch/arm/Kconfig config ARCH_NR_GPIO · line 1605

Quoted 10 lines
arch/arm/Kconfig +1 -0
index ccc388d..b3c4fa4 100644
@@ -1601,6 +1601,7 @@ config ARCH_NR_GPIO
      int
      default 1024 if ARCH_SHMOBILE || ARCH_TEGRA
      default 512 if SOC_OMAP5
+     default 512 if ARCH_EXYNOS
      default 512 if ARCH_KEYSTONE

+ default 512 if ARCH_EXYNOS || ARCH_KEYSTONE || SOC_OMAP5 ?

Quoted 2 lines

Looks good. Do you want me to re-send this?

Yes, please.

- Kukjin