Skip to contentSkip to conversation

net: intel: ice: Use uintptr_t for casting data

PATCH In review Pujin Shi 2 participants 2 messages Oct 9, 2020

Subsystems (3)
lore
Share & tools
lore

Pujin Shi

author
#0 lore raw

PATCH 1/1 net: intel: ice: Use uintptr_t for casting data

Fix up a compiler error on 64bit architectures where pointers.

In file included from drivers/net/ethernet/intel/ice/ice_flex_pipe.c:6:0:
drivers/net/ethernet/intel/ice/ice_flex_pipe.c: In function 'ice_free_flow_profs':
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

 #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
                                 ^
drivers/net/ethernet/intel/ice/ice_flex_pipe.c:2882:9: note: in expansion of macro 'ICE_FLOW_ENTRY_HNDL'
         ICE_FLOW_ENTRY_HNDL(e));
         ^
In file included from drivers/net/ethernet/intel/ice/ice_flow.c:5:0:
drivers/net/ethernet/intel/ice/ice_flow.c: In function 'ice_flow_add_entry':
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
                                 ^
drivers/net/ethernet/intel/ice/ice_flow.c:946:13: note: in expansion of macro 'ICE_FLOW_ENTRY_HNDL'
  *entry_h = ICE_FLOW_ENTRY_HNDL(e);
             ^

2 warnings generated

---
 drivers/net/ethernet/intel/ice/ice_flow.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_flow.h +1 -1
index 3913da2116d2..b9a5c208e484 100644
@@ -194,7 +194,7 @@ struct ice_flow_entry {
 	u16 entry_sz;
 };
 
-#define ICE_FLOW_ENTRY_HNDL(e)	((u64)e)
+#define ICE_FLOW_ENTRY_HNDL(e)	((uintptr_t)e)
 #define ICE_FLOW_ENTRY_PTR(h)	((struct ice_flow_entry *)(h))
 
 struct ice_flow_prof {
Signature · 1 line
2.18.1
#1 lore raw
Quoted 26 lines · Pujin Shi

Fix up a compiler error on 64bit architectures where pointers.

In file included from drivers/net/ethernet/intel/ice/ice_flex_pipe.c:6:0:
drivers/net/ethernet/intel/ice/ice_flex_pipe.c: In function 'ice_free_flow_profs':
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

 #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
                                 ^
drivers/net/ethernet/intel/ice/ice_flex_pipe.c:2882:9: note: in
expansion of macro 'ICE_FLOW_ENTRY_HNDL'
         ICE_FLOW_ENTRY_HNDL(e));
         ^

In file included from drivers/net/ethernet/intel/ice/ice_flow.c:5:0:
drivers/net/ethernet/intel/ice/ice_flow.c: In function 'ice_flow_add_entry':
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

 #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
                                 ^
drivers/net/ethernet/intel/ice/ice_flow.c:946:13: note: in expansion
of macro 'ICE_FLOW_ENTRY_HNDL'
  *entry_h = ICE_FLOW_ENTRY_HNDL(e);
             ^
Quoted 3 lines

2 warnings generated

Thanks for the patch Pujin, however, Bixuan Cui has already submitted a patch to resolve this issue [1].

[1]
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/85dcea48-8b82-d806-0026-e6b371e6a092 at huawei.com/

Thanks,
Tony