scsi: mpt3sas: Add missing breaks in switch statements
Subsystems (2)
PATCH 1/1 scsi: mpt3sas: Add missing breaks in switch statements
Fix the following warnings by adding the proper missing breaks:
drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3566:3: note: here
case MPI2_MFGPAGE_DEVID_SAS2308_2:
^~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3567:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3601:3: note: here
case MPI25_MFGPAGE_DEVID_SAS3008:
^~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3735:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3745:3: note: here
case MPI2_MFGPAGE_DEVID_SAS2308_2:
^~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3746:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~drivers/scsi/mpt3sas/mpt3sas_base.c:3768:3: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/scsi/mpt3sas/mpt3sas_base.c +4 -0
@@ -3563,6 +3563,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) ioc->pdev->subsystem_device);break ; } +break ;case MPI2_MFGPAGE_DEVID_SAS2308_2 :switch (ioc->pdev->subsystem_device) {case MPT2SAS_INTEL_RS25GB008_SSDID :
@@ -3598,6 +3599,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) ioc->pdev->subsystem_device);break ; } +break ;case MPI25_MFGPAGE_DEVID_SAS3008 :switch (ioc->pdev->subsystem_device) {case MPT3SAS_INTEL_RMS3JC080_SSDID :
@@ -3742,6 +3744,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) ioc->pdev->subsystem_device);break ; } +break ;case MPI2_MFGPAGE_DEVID_SAS2308_2 :switch (ioc->pdev->subsystem_device) {case MPT2SAS_HP_2_4_INTERNAL_SSDID :
@@ -3765,6 +3768,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) ioc->pdev->subsystem_device);break ; } +break ;default :ioc_info (ioc,"HP SAS HBA: Subsystem ID: 0x%X\n" , ioc->pdev->subsystem_device);
Signature · 1 line
2.20.1
Martin K. Petersen
AppliedGustavo,
Quoted 4 lines
Fix the following warnings by adding the proper missing breaks:
drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall thr
Applied to 5.1/scsi-queue, thanks.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 10 lines · Martin K. Petersen
Gustavo,
Quoted 4 lines
Fix the following warnings by adding the proper missing breaks:
drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall thrApplied to 5.1/scsi-queue, thanks.
Thank you, Martin.
There many patches in this series:
https://lore.kernel.org/patchwork/project/lkml/list/?series=374317
that never were acked/reviewed even after I have
pinged twice.
I wonder if you could apply them.
Thanks
--
Gustavo