Skip to contentSkip to conversation

drm/msm: use dev_fwnode()

PATCH In review Jiri Slaby (SUSE) 2 participants 3 messages Jul 23, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm: use dev_fwnode()

irq_domain_create_simple() takes fwnode as the first argument. It can be extracted from the struct device using dev_fwnode() helper instead of using of_node with of_fwnode_handle().

So use the dev_fwnode() helper.

Cc Rob Clark <[email protected]>
Cc Abhinav Kumar <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marijn Suijten <[email protected]>
Cc David Airlie <[email protected]>
Cc Simona Vetter <[email protected]>

---

---
 drivers/gpu/drm/msm/msm_mdss.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_mdss.c +1 -2
index 1f5fe7811e01..ec7d83831b83 100644
@@ -154,8 +154,7 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss)
 
 	dev = msm_mdss->dev;
 
-	domain = irq_domain_create_linear(of_fwnode_handle(dev->of_node), 32,
-			&msm_mdss_irqdomain_ops, msm_mdss);
+	domain = irq_domain_create_linear(dev_fwnode(dev), 32, &msm_mdss_irqdomain_ops, msm_mdss);
 	if (!domain) {
 		dev_err(dev, "failed to add irq_domain\n");
 		return -EINVAL;
Signature · 1 line
2.50.1
author
#1 lore raw

Hmm, I got: "Dmitry Baryshkov no longer works for Linaro.". "To:" field fixed using @kernel.org address (was in Cc).

Quoted 38 lines · Jiri Slaby (SUSE)

irq_domain_create_simple() takes fwnode as the first argument. It can be extracted from the struct device using dev_fwnode() helper instead of using of_node with of_fwnode_handle().

So use the dev_fwnode() helper.

Cc Rob Clark <[email protected]>
Cc Abhinav Kumar <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marijn Suijten <[email protected]>
Cc David Airlie <[email protected]>
Cc Simona Vetter <[email protected]>

---

---
  drivers/gpu/drm/msm/msm_mdss.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_mdss.c +1 -2
index 1f5fe7811e01..ec7d83831b83 100644
@@ -154,8 +154,7 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss)
 
  	dev = msm_mdss->dev;
 
-	domain = irq_domain_create_linear(of_fwnode_handle(dev->of_node), 32,
-			&msm_mdss_irqdomain_ops, msm_mdss);
+	domain = irq_domain_create_linear(dev_fwnode(dev), 32, &msm_mdss_irqdomain_ops, msm_mdss);
  	if (!domain) {
  		dev_err(dev, "failed to add irq_domain\n");
  		return -EINVAL;
Signature · 2 lines
js
suse labs
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jiri Slaby (SUSE)
Quoted 15 lines · Jiri Slaby (SUSE)

irq_domain_create_simple() takes fwnode as the first argument. It can be extracted from the struct device using dev_fwnode() helper instead of using of_node with of_fwnode_handle().

So use the dev_fwnode() helper.

Cc Rob Clark <[email protected]>
Cc Abhinav Kumar <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marijn Suijten <[email protected]>
Cc David Airlie <[email protected]>
Cc Simona Vetter <[email protected]>
Quoted 9 lines

---

---
 drivers/gpu/drm/msm/msm_mdss.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 2 lines
With best wishes
Dmitry