Skip to contentSkip to conversation

cmd: ums: Enable by default for sunxi

PATCH In review Andre Przywara 4 participants 5 messages Jul 5, 2021 – Jul 6, 2021 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: ums: Enable by default for sunxi

The ums command (presenting a U-Boot block device as a USB mass storage device) is very useful for accessing eMMC devices via USB-OTG.

At the moment we enable USB fastboot by default for Allwinner devices, so it makes sense to do the same with USB mass storage, which is actually more versatile and can be accessed on any USB host easily.

---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +1 -0
index a9fb4eead29..7b1c96910a8 100644
@@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE
 	bool "UMS usb mass storage"
 	select USB_FUNCTION_MASS_STORAGE
 	depends on BLK && USB_GADGET
+	default y if ARCH_SUNXI && USB_MUSB_GADGET
 	help
 	  Enables the command "ums" and the USB mass storage support to the
 	  export a block device: U-Boot, the USB device, acts as a simple
Signature · 1 line
2.17.5
#1 lore raw
Quoted 18 lines · Andre Przywara

The ums command (presenting a U-Boot block device as a USB mass storage device) is very useful for accessing eMMC devices via USB-OTG.

At the moment we enable USB fastboot by default for Allwinner devices, so it makes sense to do the same with USB mass storage, which is actually more versatile and can be accessed on any USB host easily.

---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +0 -0
index a9fb4eead29..7b1c96910a8 100644

cmd/Kconfig config CMD_USB_MASS_STORAGE · line 1350

Quoted 4 lines
cmd/Kconfig +1 -0
@@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE
        bool "UMS usb mass storage"
        select USB_FUNCTION_MASS_STORAGE
        depends on BLK && USB_GADGET
+       default y if ARCH_SUNXI && USB_MUSB_GADGET

UMS or any secondary-emmc accessible are considered in production u-boot config instead of mainline u-boot since we have fastboot already available for this kind of purpose. This might be one of the reason not conisidered UMS by default till now, atleast on Allwinner.

Thanks,
Jagan.

#2 lore raw

On Tue, 6 Jul 2021 19:56:24 +0530
Jagan Teki <[email protected]> wrote:

Hi Jagan,

thanks for the response!

Quoted 14 lines · Andre Przywara
Quoted 13 lines

The ums command (presenting a U-Boot block device as a USB mass storage device) is very useful for accessing eMMC devices via USB-OTG.

At the moment we enable USB fastboot by default for Allwinner devices, so it makes sense to do the same with USB mass storage, which is actually more versatile and can be accessed on any USB host easily.

---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

cmd/Kconfig config CMD_USB_MASS_STORAGE · line 1350

Quoted 9 lines
cmd/Kconfig +1 -0
index a9fb4eead29..7b1c96910a8 100644
@@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE
        bool "UMS usb mass storage"
        select USB_FUNCTION_MASS_STORAGE
        depends on BLK && USB_GADGET
+       default y if ARCH_SUNXI && USB_MUSB_GADGET

UMS or any secondary-emmc accessible are considered in production u-boot config instead of mainline u-boot since we have fastboot already available for this kind of purpose. This might be one of the reason not conisidered UMS by default till now, atleast on Allwinner.

Well, I consider fastboot inferior to UMS. I understand that Android phone hackers use it all the time, but I think having a block device is far more versatile - you can partition it as you like, create and populate a filesystem, dd an image to it, extract or update firmware, etc. - most without extra software, even on Windows or Mac. I think fastboot offers a reboot command, but are there other killer reasons for it? And having the ums command in addition to fastboot does not hurt, both would still work.
So are there any real arguments for not adding ums as well? I am not sure many people tweak their config, so I would like to offer a decent out-of-the-box experience, even for casual users.

Thanks,
Andre

#3 lore raw
Quoted 36 lines · Andre Przywara

On Tue, 6 Jul 2021 19:56:24 +0530
Jagan Teki <[email protected]> wrote:

Hi Jagan,

thanks for the response!

Quoted 14 lines · Andre Przywara
Quoted 13 lines

The ums command (presenting a U-Boot block device as a USB mass storage device) is very useful for accessing eMMC devices via USB-OTG.

At the moment we enable USB fastboot by default for Allwinner devices, so it makes sense to do the same with USB mass storage, which is actually more versatile and can be accessed on any USB host easily.

---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

cmd/Kconfig config CMD_USB_MASS_STORAGE · line 1350

Quoted 9 lines
cmd/Kconfig +1 -0
index a9fb4eead29..7b1c96910a8 100644
@@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE
        bool "UMS usb mass storage"
        select USB_FUNCTION_MASS_STORAGE
        depends on BLK && USB_GADGET
+       default y if ARCH_SUNXI && USB_MUSB_GADGET

UMS or any secondary-emmc accessible are considered in production u-boot config instead of mainline u-boot since we have fastboot already available for this kind of purpose. This might be one of the reason not conisidered UMS by default till now, atleast on Allwinner.

Quoted 8 lines

Well, I consider fastboot inferior to UMS. I understand that Android phone hackers use it all the time, but I think having a block device is far more versatile - you can partition it as you like, create and populate a filesystem, dd an image to it, extract or update firmware, etc. - most without extra software, even on Windows or Mac. I think fastboot offers a reboot command, but are there other killer reasons for it? And having the ums command in addition to fastboot does not hurt, both would still work.

fastboot abstracts away the storage medium, whereas UMS doesn't. You cannot run UMS on a NAND or SPI-NOR, while this causes no issue at all to fastboot.

Similarly, UMS exposes the whole partition to the host. You then need to have a driver for that FS on that machine, otherwise you just can't access it.

Sure, it's convenient, but it's far from being ubiquitous and the silver bullet you claim it is.

Quoted 3 lines

So are there any real arguments for not adding ums as well? I am not sure many people tweak their config, so I would like to offer a decent out-of-the-box experience, even for casual users.

As usual, we also have to balance that with the size limit, but I'm not sure it's an issue these days?

Maxime

#4 lore raw
Quoted 37 lines · Maxime Ripard
Quoted 36 lines · Andre Przywara

On Tue, 6 Jul 2021 19:56:24 +0530
Jagan Teki <[email protected]> wrote:

Hi Jagan,

thanks for the response!

Quoted 28 lines · Andre Przywara
Quoted 18 lines

The ums command (presenting a U-Boot block device as a USB mass storage device) is very useful for accessing eMMC devices via USB-OTG.

At the moment we enable USB fastboot by default for Allwinner devices, so it makes sense to do the same with USB mass storage, which is actually more versatile and can be accessed on any USB host easily.

---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +0 -0
index a9fb4eead29..7b1c96910a8 100644

cmd/Kconfig config CMD_USB_MASS_STORAGE · line 1350

Quoted 4 lines
cmd/Kconfig +1 -0
@@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE
        bool "UMS usb mass storage"
        select USB_FUNCTION_MASS_STORAGE
        depends on BLK && USB_GADGET
+       default y if ARCH_SUNXI && USB_MUSB_GADGET

UMS or any secondary-emmc accessible are considered in production u-boot config instead of mainline u-boot since we have fastboot already available for this kind of purpose. This might be one of the reason not conisidered UMS by default till now, atleast on Allwinner.

Quoted 7 lines
Quoted 7 lines

Well, I consider fastboot inferior to UMS. I understand that Android phone hackers use it all the time, but I think having a block device is far more versatile - you can partition it as you like, create and populate a filesystem, dd an image to it, extract or update firmware, etc. - most without extra software, even on Windows or Mac. I think fastboot offers a reboot command, but are there other killer reasons for it?

During manufacturing it is very convenient to be able to run arbitrary commands with ACMD/UCMD, or particular commands like partconf. Fastboot also allows loading things directly to ram, which is nice for loading a ramdisk/kernel when you don't have network/mass storage.

There is also no way to stop UMS other than by yanking the cord or by hitting Ctrl-C (though I am working on this).

Quoted 10 lines

And having the ums command in addition to fastboot does

Quoted 1 line

not hurt, both would still work.

fastboot abstracts away the storage medium, whereas UMS doesn't. You cannot run UMS on a NAND or SPI-NOR, while this causes no issue at all to fastboot.

Similarly, UMS exposes the whole partition to the host. You then need to have a driver for that FS on that machine, otherwise you just can't access it.

You can expose just one partition like

ums 0 mmc 0:2

you can also expose multiple partitions like

ums 0 mmc 0:1,0:2,0.1,0.2

--Sean

Quoted 12 lines

Sure, it's convenient, but it's far from being ubiquitous and the silver bullet you claim it is.

Quoted 3 lines

So are there any real arguments for not adding ums as well? I am not sure many people tweak their config, so I would like to offer a decent out-of-the-box experience, even for casual users.

As usual, we also have to balance that with the size limit, but I'm not sure it's an issue these days?

Maxime