Skip to contentSkip to conversation

valgrind: Delete trailing whitespaces

PATCH In review Khem Raj 2 participants 5 messages Apr 14, 2021 – Apr 15, 2021

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v2 1/3 valgrind: Delete trailing whitespaces

---
 meta/recipes-devtools/valgrind/valgrind_3.17.0.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-devtools/valgrind/valgrind_3.17.0.bb +1 -2
index 2eea84c229..eb7b9d2383 100644
@@ -55,7 +55,6 @@ COMPATIBLE_HOST = '(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux'
 # argument. Change expected stderr files accordingly.
 do_patch_append() {
     bb.build.exec_func('do_sed_paths', d)
-    
 }
 
 do_sed_paths() {
@@ -157,7 +156,7 @@ do_install_ptest() {
     #
     # The regression tests require scripts and data files that are not
     # copied to the build directory.  They must be copied from the
-    # source directory. 
+    # source directory.
     saved_dir=$PWD
     for parent_dir in ${S} ${B} ; do
         cd $parent_dir
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v2 2/3 valgrind: Add glibc-src to ptest rdeps

gdbserver tests look for glibc sources ( rtld.c )
or else they are flagged as differences and tests marked as failures

---
 meta/recipes-devtools/valgrind/valgrind_3.17.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/valgrind/valgrind_3.17.0.bb +1 -1
index eb7b9d2383..d8324f1dc6 100644
@@ -136,7 +136,7 @@ RDEPENDS_${PN}-ptest += " bash coreutils file \
    perl-module-file-basename perl-module-file-glob perl-module-getopt-long \
    perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
    perl-module-carp perl-module-symbol \
-   procps sed ${PN}-dbg ${PN}-src"
+   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src"
 RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
 
 # One of the tests contains a bogus interpreter path on purpose.
Signature · 1 line
2.31.1
author
#2 lore raw

PATCH v2 3/3 valgrind: Add libstdc++ debug symbols for ptest

In reply to Khem Raj

new/delete symbols are needed by overloaded-new.post test

---
 meta/recipes-devtools/valgrind/valgrind_3.17.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/valgrind/valgrind_3.17.0.bb +1 -1
index d8324f1dc6..4eb948f2db 100644
@@ -136,7 +136,7 @@ RDEPENDS_${PN}-ptest += " bash coreutils file \
    perl-module-file-basename perl-module-file-glob perl-module-getopt-long \
    perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
    perl-module-carp perl-module-symbol \
-   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src"
+   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src gcc-runtime-dbg"
 RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
 
 # One of the tests contains a bogus interpreter path on purpose.
Signature · 1 line
2.31.1
#3 lore raw

Re: [OE-core] [v2 3/3] valgrind: Add libstdc++ debug symbols for ptest

Quoted 3 lines · Khem Raj

[Please note: This e-mail is from an EXTERNAL e-mail address]

new/delete symbols are needed by overloaded-new.post test

this test is passing on master-next on qemux86-64. Is this failure caused by gcc uprev?

Quoted 26 lines
---
  meta/recipes-devtools/valgrind/valgrind_3.17.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/valgrind/valgrind_3.17.0.bb +1 -2
index d8324f1dc6..4eb948f2db 100644
@@ -136,7 +136,7 @@ RDEPENDS_${PN}-ptest += " bash coreutils file \
     perl-module-file-basename perl-module-file-glob perl-module-getopt-long \
     perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
     perl-module-carp perl-module-symbol \
-   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src"
+   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src gcc-runtime-dbg"
  RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
 
  # One of the tests contains a bogus interpreter path on purpose.
--

2.31.1

author
#4 lore raw

Re: [OE-core] [v2 3/3] valgrind: Add libstdc++ debug symbols for ptest

Quoted 9 lines · Yi Fan Yu
Quoted 3 lines · Khem Raj

[Please note: This e-mail is from an EXTERNAL e-mail address]

new/delete symbols are needed by overloaded-new.post test

this test is passing on master-next on qemux86-64. Is this failure caused by gcc uprev?

yes. gcc 11 uses dwarf-5 and its looking for filenames in debug info for libstdc++ which when not found are flagged.

Quoted 26 lines
Quoted 26 lines
---
  meta/recipes-devtools/valgrind/valgrind_3.17.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/valgrind/valgrind_3.17.0.bb +1 -2
index d8324f1dc6..4eb948f2db 100644
@@ -136,7 +136,7 @@ RDEPENDS_${PN}-ptest += " bash coreutils file \
     perl-module-file-basename perl-module-file-glob perl-module-getopt-long \
     perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
     perl-module-carp perl-module-symbol \
-   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src"
+   procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src gcc-runtime-dbg"
  RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
 
  # One of the tests contains a bogus interpreter path on purpose.
--

2.31.1