x86/process: remove unused variable in __switch_to_xtra()
PATCH 1/1 x86/process: remove unused variable in __switch_to_xtra()
After the commit ecc7e37d4dad ("x86/io: Speedup schedule out of I/O bitmap user") and commit 22fe5b0439dd ("x86/ioperm: Move TSS bitmap update to exit to user work"), warning is found:
arch/x86/kernel/process.c: In function ‘__switch_to_xtra’:arch/x86/kernel/process.c:618:31: warning: variable ‘next’ set but not used [-Wunused-but-set-variable]
struct thread_struct *prev, *next;
^~~~
arch/x86/kernel/process.c:618:24: warning: variable ‘prev’ set but not
used [-Wunused-but-set-variable]
struct thread_struct *prev, *next;
^~~~Fix this by removing the unused variable @prev and @next;
--- arch/x86/kernel/process.c | 4 ---- 1 file changed, 4 deletions(-)
arch/x86/kernel/process.c +0 -4
@@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void)void __switch_to_xtra (struct task_struct *prev_p,struct task_struct *next_p) { -struct thread_struct *prev, *next;unsigned long tifp, tifn; - prev = &prev_p->thread; - next = &next_p->thread; - tifn =READ_ONCE (task_thread_info (next_p)->flags); tifp =READ_ONCE (task_thread_info (prev_p)->flags);
Signature · 1 line
2.7.4
Borislav Petkov
maintainerQuoted 28 lines · Yunfeng Ye
After the commit
ecc7e37d4dad("x86/io: Speedup schedule out of I/O bitmap user") and commit22fe5b0439dd("x86/ioperm: Move TSS bitmap update to exit to user work"), warning is found:
arch/x86/kernel/process.c: In function ‘__switch_to_xtra’:arch/x86/kernel/process.c:618:31: warning: variable ‘next’ set but not used [-Wunused-but-set-variable]struct thread_struct *prev, *next; ^~~~ arch/x86/kernel/process.c:618:24: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] struct thread_struct *prev, *next; ^~~~Fix this by removing the unused variable @prev and @next;
Signed-off-by Yunfeng Ye <[email protected]>--- arch/x86/kernel/process.c | 4 ---- 1 file changed, 4 deletions(-)arch/x86/kernel/process.c +0
-0@@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void)void __switch_to_xtra (struct task_struct *prev_p,struct task_struct *next_p)
arch/x86/kernel/process.c void speculation_ctrl_update_current(void) · line 622
Quoted 10 lines
arch/x86/kernel/process.c +0
-4{ -struct thread_struct *prev, *next;unsigned long tifp, tifn; - prev = &prev_p->thread; - next = &next_p->thread; - tifn =READ_ONCE (task_thread_info (next_p)->flags); tifp =READ_ONCE (task_thread_info (prev_p)->flags);
Let me introduce you to your colleague yu kuai:
:-)
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 38 lines · Borislav Petkov
Quoted 37 lines · Yunfeng Ye
After the commit
ecc7e37d4dad("x86/io: Speedup schedule out of I/O bitmap user") and commit22fe5b0439dd("x86/ioperm: Move TSS bitmap update to exit to user work"), warning is found:
arch/x86/kernel/process.c: In function ‘__switch_to_xtra’:arch/x86/kernel/process.c:618:31: warning: variable ‘next’ set but not used [-Wunused-but-set-variable]struct thread_struct *prev, *next; ^~~~ arch/x86/kernel/process.c:618:24: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] struct thread_struct *prev, *next; ^~~~Fix this by removing the unused variable @prev and @next;
Signed-off-by Yunfeng Ye <[email protected]>--- arch/x86/kernel/process.c | 4 ---- 1 file changed, 4 deletions(-)arch/x86/kernel/process.c +0
-4@@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void)void __switch_to_xtra (struct task_struct *prev_p,struct task_struct *next_p) { -struct thread_struct *prev, *next;unsigned long tifp, tifn; - prev = &prev_p->thread; - next = &next_p->thread; - tifn =READ_ONCE (task_thread_info (next_p)->flags); tifp =READ_ONCE (task_thread_info (prev_p)->flags);
Quoted 4 lines
Quoted 1 line
Let me introduce you to your colleague yu kuai:
ok, thanks.