Skip to contentSkip to conversation

tools: ipxe: update for fixing build with GCC10

PATCH In review Olaf Hering 5 participants 9 messages Jan 4, 2021 – Jan 7, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: ipxe: update for fixing build with GCC10

Update to v1.21.1 to fix build in Tumbleweed, which has been broken since months due to lack of new release.

---
 tools/firmware/etherboot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/firmware/etherboot/Makefile +1 -1
index 0de30599bf..ed9e11305f 100644
@@ -10,7 +10,7 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
+IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
 
 IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
 
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Olaf Hering

Update to v1.21.1 to fix build in Tumbleweed, which has been broken since months due to lack of new release.

Quoted 17 lines
---
 tools/firmware/etherboot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/firmware/etherboot/Makefile +1 -1
index 0de30599bf..ed9e11305f 100644
@@ -10,7 +10,7 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
+IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
 
 IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
 
#2 lore raw

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10"):

Quoted 7 lines · Olaf Hering
Quoted 4 lines

Update to v1.21.1 to fix build in Tumbleweed, which has been broken since months due to lack of new release.

...

Quoted 2 lines

tools/firmware/etherboot/Makefile else · line 13

Quoted 2 lines
tools/firmware/etherboot/Makefile +1 -1
-IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
+IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c

Unfortunately this broke the build, but it's not really your fault:

osstest service owner writes ("[xen-unstable-smoke test] 158191: regressions - FAIL"):

Quoted 3 lines

Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64 6 xen-build fail REGR. vs. 158134

--2021-01-06 01:27:19-- http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
Resolving cache (cache)... 172.16.148.6
Connecting to cache (cache)|172.16.148.6|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found

We currently insist on having have a tarball.

That means someone (me, I guess) has to do a "git archive" and put the resulting tarball in the right place on xenbits. Unfortunately this is still manual, but we don't update ipxe very often.

I have made the tarball now.

Ian.

#3 lore raw

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

Quoted 24 lines · Ian Jackson

Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10"):

Quoted 7 lines · Olaf Hering
Quoted 4 lines

Update to v1.21.1 to fix build in Tumbleweed, which has been broken since months due to lack of new release.

...

Quoted 2 lines

tools/firmware/etherboot/Makefile else · line 13

Quoted 2 lines
tools/firmware/etherboot/Makefile +1 -1
-IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
+IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c

Unfortunately this broke the build, but it's not really your fault:

osstest service owner writes ("[xen-unstable-smoke test] 158191: regressions - FAIL"):

Quoted 3 lines

Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64 6 xen-build fail REGR. vs. 158134

--2021-01-06 01:27:19-- http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
Resolving cache (cache)... 172.16.148.6
Connecting to cache (cache)|172.16.148.6|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found

Quoted 6 lines

We currently insist on having have a tarball.

That means someone (me, I guess) has to do a "git archive" and put the resulting tarball in the right place on xenbits. Unfortunately this is still manual, but we don't update ipxe very often.

Wouldn't the build host just fetch from the upstream git tree? That's why I didn't ask you to make a tarball -- I was waiting to see if this could pass osstest before asking.

Quoted 1 line

I have made the tarball now.

Thanks.

Wei.

Quoted 2 lines

Ian.

#4 lore raw

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

Quoted 27 lines · Wei Liu
Quoted 26 lines · Ian Jackson

Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10"):

Quoted 7 lines · Olaf Hering
Quoted 4 lines

Update to v1.21.1 to fix build in Tumbleweed, which has been broken since months due to lack of new release.

...

Quoted 2 lines

tools/firmware/etherboot/Makefile else · line 13

Quoted 2 lines
tools/firmware/etherboot/Makefile +1 -1
-IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
+IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c

Unfortunately this broke the build, but it's not really your fault:

osstest service owner writes ("[xen-unstable-smoke test] 158191: regressions - FAIL"):

Quoted 3 lines

Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64 6 xen-build fail REGR. vs. 158134

--2021-01-06 01:27:19-- http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
Resolving cache (cache)... 172.16.148.6
Connecting to cache (cache)|172.16.148.6|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found

We currently insist on having have a tarball.

Quoted 9 lines
Quoted 4 lines

That means someone (me, I guess) has to do a "git archive" and put the resulting tarball in the right place on xenbits. Unfortunately this is still manual, but we don't update ipxe very often.

Wouldn't the build host just fetch from the upstream git tree? That's why I didn't ask you to make a tarball -- I was waiting to see if this could pass osstest before asking.

Never mind. It seems that I have missed the change of requirement...

Wei.

#5 lore raw

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]"):

Quoted 4 lines · Wei Liu
Quoted 3 lines

Wouldn't the build host just fetch from the upstream git tree? That's why I didn't ask you to make a tarball -- I was waiting to see if this could pass osstest before asking.

The build system's ability to do that has been nobbled in osstest for a very long time.

Quoted 1 line

Never mind. It seems that I have missed the change of requirement...

I don't think there has been a change. But it's been a long time since we did an ipxe update.

Ian.

#6 lore raw

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

In reply to Ian Jackson

Am Wed, 6 Jan 2021 11:23:43 +0000
schrieb Ian Jackson <[email protected]>:

Quoted 1 line

We currently insist on having have a tarball.

Maybe add a comment to IPXE_GIT_TAG which lists the required extra steps.

Olaf

#7 lore raw

[xen-unstable-smoke test] 158191: regressions - FAIL

flight 158191 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/158191/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:

 build-amd64                   6 xen-build                fail REGR. vs. 158134
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 158134

Tests which did not succeed, but are not blocking:

 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
xen edf5b22022aea0a76eaeb36cc060d984340e1e18
baseline version:
xen 7ba2ab495be54f608cb47440e1497b2795bd301a

Last test of basis   158134  2021-01-04 15:01:26 Z    1 days
Failing since        158142  2021-01-05 02:00:25 Z    1 days    7 attempts
Testing same since   158174  2021-01-05 22:00:25 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
Andrew Cooper <[email protected]>
Bertrand Marquis <[email protected]>
Jan Beulich <[email protected]>
Manuel Bouyer <[email protected]>
Marek Marczykowski-Górecki <[email protected]> Olaf Hering <[email protected]>
Roger Pau Monne <[email protected]>
Roger Pau Monné <[email protected]>
Stefano Stabellini <[email protected]>
Wei Liu <[email protected]>

jobs:

 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 

------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

Not pushing.

(No revision log; it would be 432 lines long.)

#8 lore raw

Re: [xen-unstable-smoke test] 158191: regressions - FAIL

Quoted 8 lines · osstest service owner

flight 158191 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/158191/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64 6 xen-build fail REGR. vs. 158134

Perhaps an unwanted effect of c7115531ea8e "tools: ipxe: update for fixing build with GCC10"? Did the build perhaps fetch a pre-cooked tarball before?

Jan

make[6]: Entering directory '/home/osstest/build.158191.build-amd64/xen/tools/firmware/etherboot'

set -e; if ! /usr/bin/wget -c -O _ipxe.tar.gz http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz; then \
	git clone file:////osstest/IPXE-GIT-FORBIDDEN ipxe.git; \
	(cd ipxe.git && git archive --format=tar --prefix=ipxe/ \
	988d2c13cdf0f0b4140685af35ced70ac5b3283c | gzip -n >../_ipxe.tar.gz); \
	rm -rf ipxe.git; \

fi
--2021-01-06 05:12:39-- http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
Resolving cache (cache)... 172.16.148.6
Connecting to cache (cache)|172.16.148.6|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found

2021-01-06 05:12:39 ERROR 404: Not Found.

Cloning into 'ipxe.git'...
fatal: '//osstest/IPXE-GIT-FORBIDDEN' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
make[6]: Leaving directory '/home/osstest/build.158191.build-amd64/xen/tools/firmware/etherboot' make[6]: *** [Makefile:36: ipxe.tar.gz] Error 128