Skip to contentSkip to conversation

tick/broadcast: Remove redundant code in tick_check_new_device()

PATCH New Zhenzhong Duan 1 participant 1 message Nov 14, 2017 Nohz, dynticks support

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tick/broadcast: Remove redundant code in tick_check_new_device()

There is no way a timer used as broadcast clockevent device is also used as percpu tick clockevent device currently.

-v2: remove meaningless description suggested by tglx

---
 kernel/time/tick-common.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
kernel/time/tick-common.c +1 -6
index 49edc1c..9bcc866 100644
@@ -320,13 +320,8 @@ void tick_check_new_device(struct clock_event_device *newdev)
 
 	/*
 	 * Replace the eventually existing device by the new
-	 * device. If the current device is the broadcast device, do
-	 * not give it back to the clockevents layer !
+	 * device.
 	 */
-	if (tick_is_broadcast_device(curdev)) {
-		clockevents_shutdown(curdev);
-		curdev = NULL;
-	}
 	clockevents_exchange_device(curdev, newdev);
 	tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
 	if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
Signature · 1 line
1.7.3