Skip to contentSkip to conversation

net/hns3: fix build warning

PATCH Applied [email protected] 3 participants 3 messages Apr 4, 2023 – Apr 7, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/hns3: fix build warning

From: Jerin Jacob <[email protected]>

aarch64 gcc 12.2.0 build complain with below warning[1]. Move the new_link initialization upwards to fix the warning.

Compiling C object drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be used uninitialized [-Wmaybe-uninitialized]

Fixes 64308555d5bf ("net/hns3: fix link status when port is stopped")
---
 drivers/net/hns3/hns3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/hns3/hns3_ethdev.c +1 -1
index 36896f8989..a872cb8dd7 100644
@@ -2257,6 +2257,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 	struct rte_eth_link new_link;
 	int ret;
 
+	memset(&new_link, 0, sizeof(new_link));
 	/* When port is stopped, report link down. */
 	if (eth_dev->data->dev_started == 0) {
 		new_link.link_autoneg = mac->link_autoneg;
@@ -2280,7 +2281,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 		rte_delay_ms(HNS3_LINK_CHECK_INTERVAL);
 	} while (retry_cnt--);
 
-	memset(&new_link, 0, sizeof(new_link));
 	hns3_setup_linkstatus(eth_dev, &new_link);
 
 out:
Signature · 1 line
2.40.0
Acked-by on v1 1/1
#1 lore raw

Hi Jerin

Many thanks for fixing the warning.

Quoted 9 lines · On 2023/4/4 14:55, [email protected] wrote:

From: Jerin Jacob <[email protected]>

aarch64 gcc 12.2.0 build complain with below warning[1]. Move the new_link initialization upwards to fix the warning.

Compiling C object drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be used uninitialized [-Wmaybe-uninitialized]

It looks like a false positive from the logic of the code. Anyway, this warning can be fixed by this patch, so

Thanks,
Dongdong

Quoted 30 lines
Fixes 64308555d5bf ("net/hns3: fix link status when port is stopped")
---
 drivers/net/hns3/hns3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/hns3/hns3_ethdev.c +1 -1
index 36896f8989..a872cb8dd7 100644
@@ -2257,6 +2257,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 	struct rte_eth_link new_link;
 	int ret;
 
+	memset(&new_link, 0, sizeof(new_link));
 	/* When port is stopped, report link down. */
 	if (eth_dev->data->dev_started == 0) {
 		new_link.link_autoneg = mac->link_autoneg;
@@ -2280,7 +2281,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 		rte_delay_ms(HNS3_LINK_CHECK_INTERVAL);
 	} while (retry_cnt--);
 
-	memset(&new_link, 0, sizeof(new_link));
 	hns3_setup_linkstatus(eth_dev, &new_link);
 
 out:
Applied
#2 lore raw
Quoted 9 lines · Dongdong Liu

Hi Jerin

Many thanks for fixing the warning.

Quoted 5 lines · On 2023/4/4 14:55, [email protected] wrote:

From: Jerin Jacob <[email protected]>

aarch64 gcc 12.2.0 build complain with below warning[1]. Move the new_link initialization upwards to fix the warning.

Quoted 9 lines
Quoted 5 lines

Compiling C object drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be used uninitialized [-Wmaybe-uninitialized]

It looks like a false positive from the logic of the code. Anyway, this warning can be fixed by this patch, so

Agree that it looks false positive.
Moving memset upwards does unnecessary memset for some case but this can be OK for control path function.

Applied to dpdk-next-net/main, thanks.