Skip to contentSkip to conversation

clk: Delete init for local variable "best_crent_rate".

PATCH In review jiping huang 2 participants 3 messages Aug 27, 2024 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: Delete init for local variable "best_crent_rate".

I'm sorry, my last submission may not expressed it clearly, and there \
is an error delete. Therefore, I would like to generate a new patch and \
explanations.
Actually, it is, the local variable 'best_crent_rate' is only used in \
line 2355 for the judgment 'best_crent_rate!=parent ->rate'. However, \
if the "if (clk_core_can_round (core))" branch condition in line 2306 \
is true, the value of the local variable "best_crent_rate" will be \
updated by "best_crent_rate=req.best_crent_rate;" in line 2319, otherwise \
it will be directly returned in the "else if" branch in line 2325 and the \
"else" branch in line 2329.
In summary, it is unnecessary to store the "parent ->rate" value in \
"best_crent_rate" in line 2301.
Thank you for your precious time!

drivers/clk/clk.c +0 -2
index 8cca52be993f..b6ff88f63bc4 100644
@@ -2297,8 +2297,6 @@ static struct clk_core *clk_calc_new_rates(struct clk_core *core,
 
 	/* save parent rate, if it exists */
 	parent = old_parent = core->parent;
-	if (parent)
-		best_parent_rate = parent->rate;
 
 	clk_core_get_boundaries(core, &min_rate, &max_rate);
 
Signature · 1 line
2.34.1
maintainer
#1 lore raw

Quoting jiping huang (2024-08-27 10:21:10)

Quoted 5 lines

I'm sorry, my last submission may not expressed it clearly, and there \
is an error delete. Therefore, I would like to generate a new patch and \
explanations.
Actually, it is, the local variable 'best_crent_rate' is only used in \
line 2355 for the judgment 'best_crent_rate!=parent ->rate'. However, \

Quoted 8 lines

if the "if (clk_core_can_round (core))" branch condition in line 2306 \
is true, the value of the local variable "best_crent_rate" will be \
updated by "best_crent_rate=req.best_crent_rate;" in line 2319, otherwise \
it will be directly returned in the "else if" branch in line 2325 and the \
"else" branch in line 2329.
In summary, it is unnecessary to store the "parent ->rate" value in \
"best_crent_rate" in line 2301.
Thank you for your precious time!

Please read the docs on how to submit patches. Especially the part about describing your change[1]. For example, "best_crent_rate" doesn't exist. Also, look at other commits for guidance on how to write your commit text. Thanks!

[1] https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

#2 lore raw

Oh God, another low-level mistake. Thank you for your help. I will correct my description later.
Thanks!