blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c
PATCH v2 1/1 blk-mq: kill warning when building block/blk-mq-debugfs-zoned.c
Fix the following warning when building block/blk-mq-debugfs-zoned.c:
In file included from block/blk-mq-debugfs-zoned.c:7:block/blk-mq-debugfs.h:24:14: warning: ‘struct blk_mq_hw_ctx’ declared inside parameter list will not be visible outside of this definition or declaration
24 | struct blk_mq_hw_ctx *hctx);
| ^~~~~~~~~~~~~---
V2:
- forward declaration of struct blk_mq_hw_ctx instead of including header, as suggested by Christoph
block/blk-mq-debugfs.h | 2 ++ 1 file changed, 2 insertions(+)
block/blk-mq-debugfs.h +2 -0
@@ -2,6 +2,8 @@#ifndef INT_BLK_MQ_DEBUGFS_H #define INT_BLK_MQ_DEBUGFS_H +struct blk_mq_hw_ctx ; +#ifdef CONFIG_BLK_DEBUG_FS #include <linux/seq_file.h>
Signature · 1 line
2.31.1
Quoted 11 lines · Ming Lei
Fix the following warning when building
block/blk-mq-debugfs-zoned.c:In file included from
block/blk-mq-debugfs-zoned.c:7:block/blk-mq-debugfs.h:24:14: warning: ‘struct blk_mq_hw_ctx’ declared inside parameter list will not be visible outside of this definition or declaration24 | struct blk_mq_hw_ctx *hctx); | ^~~~~~~~~~~~~Cc Christoph Hellwig <[email protected]>Reported-by kernel test robot <[email protected]>Signed-off-by Ming Lei <[email protected]>---
Looks good.
-ck
Looks good,
Quoted 7 lines · Ming Lei
Fix the following warning when building
block/blk-mq-debugfs-zoned.c:In file included from
block/blk-mq-debugfs-zoned.c:7:block/blk-mq-debugfs.h:24:14: warning: ‘struct blk_mq_hw_ctx’ declared inside parameter list will not be visible outside of this definition or declaration24 | struct blk_mq_hw_ctx *hctx); | ^~~~~~~~~~~~~
Quoted 7 lines
Cc Christoph Hellwig <[email protected]>Reported-by kernel test robot <[email protected]>Signed-off-by Ming Lei <[email protected]>---
V2:
- forward declaration of structblk_mq_hw_ctxinstead of including header, as suggested by Christoph
Hello Jens,
This patch looks missed, can you take a look?
Thanks,
Ming