ipv4: Honor "ignore_routes_with_linkdown" sysctl in nexthop selection
Subsystems (3)
Ido Schimmel
maintainerPATCH 1/1 ipv4: Honor "ignore_routes_with_linkdown" sysctl in nexthop selection
Commit 32607a332cfe ("ipv4: prefer multipath nexthop that matches source address") changed IPv4 nexthop selection to prefer a nexthop whose nexthop device is assigned the specified source address for locally generated traffic.
While the selection honors the "fib_multipath_use_neigh" sysctl and will not choose a nexthop with an invalid neighbour, it does not honor the "ignore_routes_with_linkdown" sysctl and can choose a nexthop without a carrier:
$ sysctl net.ipv4.conf.all.ignore_routes_with_linkdown
net.ipv4.conf.all.ignore_routes_with_linkdown = 1
$ ip route show 198.51.100.0/24
198.51.100.0/24
nexthop via 192.0.2.2 dev dummy1 weight 1
nexthop via 192.0.2.18 dev dummy2 weight 1 dead linkdown
$ ip route get 198.51.100.1 from 192.0.2.17
198.51.100.1 from 192.0.2.17 via 192.0.2.18 dev dummy2 uid 0Solve this by skipping over nexthops whose assigned hash upper bound is minus one, which is the value assigned to nexthops that do not have a carrier when the "ignore_routes_with_linkdown" sysctl is set.
In practice, this probably does not matter a lot as the initial route lookup for the source address would not choose a nexthop that does not have a carrier in the first place, but the change does make the code clearer.
--- net/ipv4/fib_semantics.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
net/ipv4/fib_semantics.c +9 -2
@@ -2188,7 +2188,14 @@ void fib_select_multipath(struct fib_result *res, int hash, saddr = fl4 ? fl4->saddr :0 ;change_nexthops (fi) { -if (use_neigh && !fib_good_nh (nexthop_nh)) +int nh_upper_bound; + +/* Nexthops without a carrier are assigned an upper bound of +* minus one when "ignore_routes_with_linkdown" is set. +*/ + nh_upper_bound =atomic_read (&nexthop_nh->fib_nh_upper_bound); +if (nh_upper_bound ==-1 || + (use_neigh && !fib_good_nh (nexthop_nh)))continue ;if (!found) {
@@ -2197,7 +2204,7 @@ void fib_select_multipath(struct fib_result *res, int hash, found = !saddr || nexthop_nh->nh_saddr == saddr; } -if (hash >atomic_read (&nexthop_nh->fib_nh_upper_bound)) +if (hash > nh_upper_bound)continue ;if (!saddr || nexthop_nh->nh_saddr == saddr) {
Signature · 1 line
2.49.0
Quoted 23 lines · Ido Schimmel
Commit
32607a332cfe("ipv4: prefer multipath nexthop that matches source address") changed IPv4 nexthop selection to prefer a nexthop whose nexthop device is assigned the specified source address for locally generated traffic.While the selection honors the "
fib_multipath_use_neigh" sysctl and will not choose a nexthop with an invalid neighbour, it does not honor the "ignore_routes_with_linkdown" sysctl and can choose a nexthop without a carrier:$ sysctl net.ipv4.conf.all.ignore_routes_with_linkdown net.ipv4.conf.all.ignore_routes_with_linkdown = 1 $ ip route show 198.51.100.0/24 198.51.100.0/24 nexthop via 192.0.2.2 dev dummy1 weight 1 nexthop via 192.0.2.18 dev dummy2 weight 1 dead linkdown $ ip route get 198.51.100.1 from 192.0.2.17 198.51.100.1 from 192.0.2.17 via 192.0.2.18 dev dummy2 uid 0Solve this by skipping over nexthops whose assigned hash upper bound is minus one, which is the value assigned to nexthops that do not have a carrier when the "
ignore_routes_with_linkdown" sysctl is set.
Quoted 6 lines
In practice, this probably does not matter a lot as the initial route lookup for the source address would not choose a nexthop that does not have a carrier in the first place, but the change does make the code clearer.
Signed-off-by Ido Schimmel <[email protected]>
Quoted 10 lines
--- net/ipv4/fib_semantics.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)net/ipv4/fib_semantics.c +0
-0@@ -2188,7 +2188,14 @@ void fib_select_multipath(struct fib_result *res, int hash, saddr = fl4 ? fl4->saddr :0 ;
net/ipv4/fib_semantics.c void fib_select_multipath(struct fib_result *res, int hash, · line 2197
Quoted 10 lines
net/ipv4/fib_semantics.c +7
-1change_nexthops (fi) { -if (use_neigh && !fib_good_nh (nexthop_nh)) +int nh_upper_bound; + +/* Nexthops without a carrier are assigned an upper bound of +* minus one when "ignore_routes_with_linkdown" is set. +*/ + nh_upper_bound =atomic_read (&nexthop_nh->fib_nh_upper_bound); + if (nh_upper_bound == -1 ||
Instead of a comment, perhaps a helper function
static bool fib_link_is_down(int nh_upper_bound)
{
return nh_upper_bound == -1;
}or define a negative constant const int NH_HASH_LINKDOWN (-2) and assign that in fib_rebalance and test that here?
But perhaps that's more complexity than it's worth. No strong opinion.
Quoted 16 lines
net/ipv4/fib_semantics.c +2
-1+ (use_neigh && !fib_good_nh(nexthop_nh)))continue ;if (!found) {@@ -2197,7 +2204,7 @@ void fib_select_multipath(struct fib_result *res, int hash, found = !saddr || nexthop_nh->nh_saddr == saddr; } -if (hash >atomic_read (&nexthop_nh->fib_nh_upper_bound)) +if (hash > nh_upper_bound)continue ;if (!saddr || nexthop_nh->nh_saddr == saddr) {Signature · 1 line
2.49.0
Quoted 28 lines · Ido Schimmel
Commit
32607a332cfe("ipv4: prefer multipath nexthop that matches source address") changed IPv4 nexthop selection to prefer a nexthop whose nexthop device is assigned the specified source address for locally generated traffic.While the selection honors the "
fib_multipath_use_neigh" sysctl and will not choose a nexthop with an invalid neighbour, it does not honor the "ignore_routes_with_linkdown" sysctl and can choose a nexthop without a carrier:$ sysctl net.ipv4.conf.all.ignore_routes_with_linkdown net.ipv4.conf.all.ignore_routes_with_linkdown = 1 $ ip route show 198.51.100.0/24 198.51.100.0/24 nexthop via 192.0.2.2 dev dummy1 weight 1 nexthop via 192.0.2.18 dev dummy2 weight 1 dead linkdown $ ip route get 198.51.100.1 from 192.0.2.17 198.51.100.1 from 192.0.2.17 via 192.0.2.18 dev dummy2 uid 0Solve this by skipping over nexthops whose assigned hash upper bound is minus one, which is the value assigned to nexthops that do not have a carrier when the "
ignore_routes_with_linkdown" sysctl is set.In practice, this probably does not matter a lot as the initial route lookup for the source address would not choose a nexthop that does not have a carrier in the first place, but the change does make the code clearer.
Quoted 5 lines
Signed-off-by Ido Schimmel <[email protected]>--- net/ipv4/fib_semantics.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 11 lines · On Wed, 30 Apr 2025 13:02:40 +0300 you wrote:
Commit
32607a332cfe("ipv4: prefer multipath nexthop that matches source address") changed IPv4 nexthop selection to prefer a nexthop whose nexthop device is assigned the specified source address for locally generated traffic.While the selection honors the "
fib_multipath_use_neigh" sysctl and will not choose a nexthop with an invalid neighbour, it does not honor the "ignore_routes_with_linkdown" sysctl and can choose a nexthop without a carrier:[...]
Here is the summary with links:
- [net-next] ipv4: Honor "ignore_routes_with_linkdown" sysctl in nexthop selection
https://git.kernel.org/netdev/net-next/c/836b313a14a3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html