kapm-idled Funny in 2.4.10-ac12
Just taking a walk through apm.c ...
I notice that set_time() calls get_cmos_time() with interrupts disabled, whereas get_time_diff calls it with interrupts enabled.
get_cmos_time is in time.c . It does a bunch of CMOS_READs without taking rtc_lock.
Methinks that the
save_flags(flags); ...; cli(); ...; restore_flags(flags);
constructs in apm.c need some attention.
Thomas
Quoted 6 lines
get_cmos_timeis intime.c. It does a bunch ofCMOS_READswithout takingrtc_lock.Methinks that the
save_flags(flags); ...; cli(); ...; restore_flags(flags);constructs in
apm.cneed some attention.
Well spotted. Yes the CMOS handling does still seem a bit random in places