Skip to contentSkip to conversation

intltool: Adds gettext as a DEPENDS

PATCH In review Alejandro Hernandez 2 participants 4 messages May 22, 2017 – May 23, 2017

lore
Share & tools
lore

Alejandro Hernandez

author
#0 lore raw

PATCH 1/1 intltool: Adds gettext as a DEPENDS

When setting USE_NLS="no" and building systemd-boot (which DEPENDS on intltool), configure fails, complaining about missing gettext:

configure: error: GNU gettext tools not found; required for intltool

This is caused because USE_NLS="no" makes the gettext class add gettext-minimal-native to BASEDEPENDS instead of adding gettext-native.

Since we still would like to set USE_NLS="no" and build systemd-boot, we add gettext-native as a dependency to intltool-native, which makes it available for the configure script of systemd-boot fixing the problem.

[YOCTO #11562]

Signed-off-by Alejandro Hernandez <[email protected]>
---
 meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/intltool/intltool_0.51.0.bb +1 -1
index 551bdf0619a..ecff2faf253 100644
@@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = "https://launchpad.net/intltool/trunk/"
 
 DEPENDS = "libxml-parser-perl-native"
 RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
-DEPENDS_class-native = "libxml-parser-perl-native"
+DEPENDS_class-native = "libxml-parser-perl-native gettext-native"
 
 inherit autotools pkgconfig perlnative
Signature · 1 line
2.12.0
#1 lore raw
Quoted 31 lines · Alejandro Hernandez

When setting USE_NLS="no" and building systemd-boot (which DEPENDS on intltool), configure fails, complaining about missing gettext:

configure: error: GNU gettext tools not found; required for intltool

This is caused because USE_NLS="no" makes the gettext class add gettext-minimal-native to BASEDEPENDS instead of adding gettext-native.

Since we still would like to set USE_NLS="no" and build systemd-boot, we add gettext-native as a dependency to intltool-native, which makes it available for the configure script of systemd-boot fixing the problem.

[YOCTO #11562]

Signed-off-by Alejandro Hernandez <[email protected]>
---
 meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/intltool/intltool_0.51.0.bb +0 -0
index 551bdf0619a..ecff2faf253 100644
@@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = "

https://launchpad.net/intltool/trunk/"

DEPENDS = "libxml-parser-perl-native" RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"

meta/recipes-devtools/intltool/intltool_0.51.0.bb UPSTREAM_CHECK_URI = "https://launchpad.net/intltool/trunk/" · line 19

Quoted 2 lines
meta/recipes-devtools/intltool/intltool_0.51.0.bb +1 -1
-DEPENDS_class-native = "libxml-parser-perl-native"
+DEPENDS_class-native = "libxml-parser-perl-native gettext-native"

This will serialise the build I think it better to add the dep only when NLS is down disabled

Quoted 13 lines

inherit autotools pkgconfig perlnative

--
2.12.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#2 lore raw

Hey Khem,

Quoted 40 lines · Khem Raj

On Mon, May 22, 2017 at 3:25 PM Alejandro Hernandez <[email protected] <mailto:[email protected]>> wrote:

When setting USE_NLS="no" and building systemd-boot (which DEPENDS on intltool), configure fails, complaining about missing gettext:

configure: error: GNU gettext tools not found; required for intltool

This is caused because USE_NLS="no" makes the gettext class add gettext-minimal-native to BASEDEPENDS instead of adding gettext-native.

Since we still would like to set USE_NLS="no" and build systemd-boot, we add gettext-native as a dependency to intltool-native, which makes it
available for the configure script of systemd-boot fixing the problem.

[YOCTO #11562]

Signed-off-by: Alejandro Hernandez <[email protected] <mailto:[email protected]>>
---
meta/recipes-devtools/intltool/intltool_0.51.0.bb
<http://intltool_0.51.0.bb> | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
<http://intltool_0.51.0.bb>
b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
<http://intltool_0.51.0.bb>
index 551bdf0619a..ecff2faf253 100644
--- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
<http://intltool_0.51.0.bb>
+++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
<http://intltool_0.51.0.bb>
@@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = "https://launchpad.net/intltool/trunk/"

Quoted 7 lines

DEPENDS = "libxml-parser-perl-native"
RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
-DEPENDS_class-native = "libxml-parser-perl-native" +DEPENDS_class-native = "libxml-parser-perl-native gettext-native"

This will serialise the build I think it better to add the dep only when NLS is down disabled

I thought about doing so but I couldn't think of a clean way of doing it.

I can't get rid of it on the gettext.bbclass since it would mess up the work on b090fde5c184

What I can do, is set gettext-native as a DEPENDS to systemd-boot which is the one that is actually complaining, this way we would keep returning gettext-minimal-native when USE_NLS="no", but we would also fix the issue, what do you think?

Quoted 14 lines

     inherit autotools pkgconfig perlnative

    --
    2.12.0

    --
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
#3 lore raw
Quoted 53 lines · Alejandro Hernandez

Hey Khem,

On 05/22/2017 05:41 PM, Khem Raj wrote:

Quoted 32 lines · Alejandro Hernandez

When setting USE_NLS="no" and building systemd-boot (which DEPENDS on intltool), configure fails, complaining about missing gettext:

configure: error: GNU gettext tools not found; required for intltool

This is caused because USE_NLS="no" makes the gettext class add gettext-minimal-native to BASEDEPENDS instead of adding gettext-native.

Since we still would like to set USE_NLS="no" and build systemd-boot, we add gettext-native as a dependency to intltool-native, which makes it available for the configure script of systemd-boot fixing the problem.

[YOCTO #11562]

Signed-off-by Alejandro Hernandez <[email protected]>
---
 meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/intltool/intltool_0.51.0.bb +0 -0
index 551bdf0619a..ecff2faf253 100644
@@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI =

"https://launchpad.net/intltool/trunk/"

DEPENDS = "libxml-parser-perl-native" RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"

meta/recipes-devtools/intltool/intltool_0.51.0.bb UPSTREAM_CHECK_URI = "https://launchpad.net/intltool/trunk/" · line 19

Quoted 2 lines
meta/recipes-devtools/intltool/intltool_0.51.0.bb +1 -1
-DEPENDS_class-native = "libxml-parser-perl-native"
+DEPENDS_class-native = "libxml-parser-perl-native gettext-native"

This will serialise the build I think it better to add the dep only when NLS is down disabled

I thought about doing so but I couldn't think of a clean way of doing it.

I can't get rid of it on the gettext.bbclass since it would mess up the work on b090fde5c184

Quoted 5 lines

What I can do, is set gettext-native as a DEPENDS to systemd-boot which is the one that is actually
complaining, this way we would keep returning gettext-minimal-native when USE_NLS="no", but we would
also fix the issue, what do you think?

Looking more closely, I realize this is right fix since all packages that need intltool would invariably need gettext during configure