Skip to contentSkip to conversation

APM driver patch summary

DISCUSSION Thomas Hood 1 participant 1 message Dec 19, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1008737165.1155.0.camel@thanatos

#1 lore raw

Well, I'm not having any problems with the latest "notify listeners before drivers" patch, and it does fix the problems I was having.

I'm not sure that this is an appropriate change for 2.4, but the decision about whether to put it in is up to Stephen. In the meantime I will try to keep the patch up to date as 2.4 kernels are released. Definitely it should go into 2.5 though. (The idle fixes, on the other hand, should go into 2.4.)

I've just spent a couple of hours auditing the code and I haven't found any other problems ( ... not that that proves anything). One little worry: apm_event_handler() seems to assume that it is called once per second, and that it will therefore set APM_STATE_BUSY once every four seconds, as the spec says it should. In fact it gets called a lot more often than that, as this bit of syslog shows:
------------------------------------------------------

Dec 18 18:00:20 thanatos apmd[266]: apmd_call_proxy: executing:
'/etc/apm/apmd_proxy' 'suspend'
Dec 18 18:00:20 thanatos kernel: apm: setting state busy
Dec 18 18:00:21 thanatos last message repeated 7 times

------------------------------------------------------
However, the APM spec does not put a ceiling on how often the state is set to BUSY, so it should be okay.

--
Thomas