replacing strtok() with strsep()
i've decided its high time someone removed every last trace of strtok() from the kernel source (replacing with strsep() for thread safety), so i've decided to do it myself. quite simple stuff, but requires extensive testing to be sure. therefore, i'm not too keen on patching 2.4.x, but instead cleaning out 2.5.x. if someone else is doing this, or has any objections, shout my way please.
cheers,
phil
Quoted 6 lines · Philip Harvey
i've decided its high time someone removed every last trace of
strtok()from the kernel source (replacing withstrsep()for thread safety), so i've decided to do it myself. quite simple stuff, but requires extensive testing to be sure. therefore, i'm not too keen on patching 2.4.x, but instead cleaning out 2.5.x. if someone else is doing this, or has any objections, shout my way please.
Someone (I forget who) took a run-through about 6 months back. AFAIK, they still sit in the last -ac tree, and not all (if any) of them got merged. If I get bored/desperate for patches to merge, I'll resurrect them for -dj. There are some other bits I keep meaning to dig out of Alans old tree, so if you decide to go do this and just bring these in sync for 2.5, I've no problem putting them in -dj until such a time for them to get maintainer-review/testing/merging.
The kernel-janitor list archives should hold copies of some of them. (See the sf page for details)
Dave.
Signature · 2 lines
| Dave Jones. http://www.codemonkey.org.uk | SuSE Labs
Quoted 10 lines · Dave Jones
Someone (I forget who) took a run-through about 6 months back. AFAIK, they still sit in the last -ac tree, and not all (if any) of them got merged. If I get bored/desperate for patches to merge, I'll resurrect them for -dj. There are some other bits I keep meaning to dig out of Alans old tree, so if you decide to go do this and just bring these in sync for 2.5, I've no problem putting them in -dj until such a time for them to get maintainer-review/testing/merging.
The kernel-janitor list archives should hold copies of some of them. (See the sf page for details)
theres some individual patches for single files dating back a while, but nothing comprehensive. i'll start tieing things together for 2.5, perhaps starting with the fs/ subtree which nobody seems to have touched in a while. it would be nice to declare 2.5 a strtok free zone. most people are using strtok to seperate options, using exactly the same syntax. what are your thoughts on creating a strsep() macro to replace them?
-phil