Skip to contentSkip to conversation

kdepimpi: Fix multiline comments

PATCH In review Khem Raj 2 participants 5 messages Feb 21, 2013 – Feb 27, 2013

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 kdepimpi: Fix multiline comments

Makes parsing go through

---
 recipes-qtopia/kdepimpi/kdepimpi-base.inc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
recipes-qtopia/kdepimpi/kdepimpi-base.inc +2 -2
index 27cc237..5d6bb0d 100644
@@ -33,7 +33,7 @@ LIBS+=-lz \
 # That changes will be needed for KMicroMail/PI to get it build with OE libs
 #
 #             LIBS-=-lkmicromailwrapper LIBS+=-lmailwrapper LIBS+=-lopiecore2 \
-
+#
 QMAKE_PROFILES= "all.pro"
 
 SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal libkdepim \
@@ -47,7 +47,7 @@ SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal lib
 #        pwmanager/libcrypt/cipher  \
 #        pwmanager/libcrypt/zlib \
 #        pwmanager/pwmanager \
-
+#
 inherit palmtop
 
 do_configure_prepend() {
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 25 lines · On Wednesday 20 February 2013 23:42:04 Khem Raj wrote:

Makes parsing go through

---
 recipes-qtopia/kdepimpi/kdepimpi-base.inc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/recipes-qtopia/kdepimpi/kdepimpi-base.inc index 27cc237..5d6bb0d 100644

recipes-qtopia/kdepimpi/kdepimpi-base.inc +0 -0
@@ -33,7 +33,7 @@ LIBS+=-lz \
 # That changes will be needed for KMicroMail/PI to get it build with OE

libs #
# LIBS-=-lkmicromailwrapper LIBS+=-lmailwrapper
LIBS+=-lopiecore2 \ -
+#
QMAKE_PROFILES= "all.pro"

SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde
libkcal libkdepim \ @@ -47,7 +47,7 @@ SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal lib # pwmanager/libcrypt/cipher \
# pwmanager/libcrypt/zlib \
# pwmanager/pwmanager \

recipes-qtopia/kdepimpi/kdepimpi-base.inc SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal lib · line 53

Quoted 5 lines
recipes-qtopia/kdepimpi/kdepimpi-base.inc +1 -1
-
+#
 inherit palmtop
 
 do_configure_prepend() {

Thanks, but you already sent a patch for this and I already merged it:

http://cgit.openembedded.org/meta-opie/commit/?id=93df88a1cc88c4db2616b9e31aa13477f2c7f63e

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#2 lore raw

hmmm in angstrom we have been using git://github.com/bluelightning/meta-opie.git
for fetching meta-opie and thats the problem here. I guess above link is not true mirror
therefore we should use git.oe.org ?

Quoted 43 lines · Paul Eggleton
Quoted 25 lines · On Wednesday 20 February 2013 23:42:04 Khem Raj wrote:

Makes parsing go through

---
 recipes-qtopia/kdepimpi/kdepimpi-base.inc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/recipes-qtopia/kdepimpi/kdepimpi-base.inc index 27cc237..5d6bb0d 100644

recipes-qtopia/kdepimpi/kdepimpi-base.inc +0 -0
@@ -33,7 +33,7 @@ LIBS+=-lz \
 # That changes will be needed for KMicroMail/PI to get it build with OE

libs #
# LIBS-=-lkmicromailwrapper LIBS+=-lmailwrapper
LIBS+=-lopiecore2 \ -
+#
QMAKE_PROFILES= "all.pro"

SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde
libkcal libkdepim \ @@ -47,7 +47,7 @@ SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal lib # pwmanager/libcrypt/cipher \
# pwmanager/libcrypt/zlib \
# pwmanager/pwmanager \

recipes-qtopia/kdepimpi/kdepimpi-base.inc SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal lib · line 53

Quoted 5 lines
recipes-qtopia/kdepimpi/kdepimpi-base.inc +1 -1
-
+#
 inherit palmtop
 
 do_configure_prepend() {

Thanks, but you already sent a patch for this and I already merged it:

http://cgit.openembedded.org/meta-opie/commit/?id=93df88a1cc88c4db2616b9e31aa13477f2c7f63e

Cheers,
Paul

--

Paul Eggleton
Intel Open Source Technology Centre

#3 lore raw
Quoted 4 lines · On Tuesday 26 February 2013 15:28:04 Khem Raj wrote:

hmmm in angstrom we have been using
git://github.com/bluelightning/meta-opie.git for fetching meta-opie and thats the problem here. I guess above link is not true mirror therefore we should use git.oe.org ?

Ah, oops... I neglected to push to that repo as well, now I have done so. Mirroring is manual for meta-opie / meta-handheld - maybe it shouldn't be.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#4 lore raw
Quoted 3 lines · Paul Eggleton

Ah, oops... I neglected to push to that repo as well, now I have done so. Mirroring is manual for meta-opie / meta-handheld - maybe it shouldn't be.

we have auto updates to meta-oe and other git trees. May be you can work with Phil to add meta-opie to OE
github mirror as well.