Skip to contentSkip to conversation

iio: adc: exynos: Drop a stray semicolon

PATCH In review [email protected] 2 participants 6 messages Oct 13, 2019 – Oct 18, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/2 iio: adc: exynos: Drop a stray semicolon

From: Jonathan Cameron <[email protected]>

Identified by coccinelle drivers/iio/adc/exynos_adc.c:654:2-3: Unneeded semicolon

---
 drivers/iio/adc/exynos_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/exynos_adc.c +1 -1
index 42a3ced11fbd..b5a497381452 100644
@@ -651,7 +651,7 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
 		input_sync(info->input);
 
 		usleep_range(1000, 1100);
-	};
+	}
 
 	writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
 
Signature · 1 line
2.23.0
author maintainer
#1 lore raw

PATCH 2/2 iio: adc: exynos: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Reduce local boilerplate.
Identified by coccinelle
drivers/iio/adc/exynos_adc.c:792:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

---
 drivers/iio/adc/exynos_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/exynos_adc.c +1 -3
index b5a497381452..2df7d057b249 100644
@@ -769,7 +769,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
 	struct iio_dev *indio_dev = NULL;
-	struct resource	*mem;
 	bool has_ts = false;
 	int ret = -ENODEV;
 	int irq;
@@ -788,8 +787,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource

Hi,

Quoted 25 lines · On 19. 10. 13. 오후 9:35, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduce local boilerplate.
Identified by coccinelle
drivers/iio/adc/exynos_adc.c:792:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

---
 drivers/iio/adc/exynos_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/exynos_adc.c +0 -1
index b5a497381452..2df7d057b249 100644
@@ -769,7 +769,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
 	struct iio_dev *indio_dev = NULL;
-	struct resource	*mem;
 	bool has_ts = false;
 	int ret = -ENODEV;
 	int irq;

drivers/iio/adc/exynos_adc.c static int exynos_adc_probe(struct platform_device *pdev) · line 793

Quoted 9 lines
drivers/iio/adc/exynos_adc.c +1 -2
@@ -788,8 +787,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
 
Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics
author maintainer Applied
#3 lore raw

Re: [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource

Quoted 30 lines · On Mon, 14 Oct 2019 11:18:58 +0900 Chanwoo Choi <[email protected]> wrote:

Hi,

Quoted 27 lines · On 19. 10. 13. 오후 9:35, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduce local boilerplate.
Identified by coccinelle
drivers/iio/adc/exynos_adc.c:792:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

---
 drivers/iio/adc/exynos_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/exynos_adc.c +0 -1
index b5a497381452..2df7d057b249 100644
@@ -769,7 +769,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
 	struct iio_dev *indio_dev = NULL;
-	struct resource	*mem;
 	bool has_ts = false;
 	int ret = -ENODEV;
 	int irq;
@@ -788,8 +787,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
Quoted 10 lines

drivers/iio/adc/exynos_adc.c static int exynos_adc_probe(struct platform_device *pdev) · line 793

Quoted 7 lines
drivers/iio/adc/exynos_adc.c +1 -2
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
 

Applied. Thanks,

Jonathan

Reviewed-by on v1 1/2
#4 lore raw
In reply to [email protected]

Hi,

Quoted 16 lines · On 19. 10. 13. 오후 9:35, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Identified by coccinelle drivers/iio/adc/exynos_adc.c:654:2-3: Unneeded semicolon

---
 drivers/iio/adc/exynos_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/exynos_adc.c +0 -0
index 42a3ced11fbd..b5a497381452 100644

drivers/iio/adc/exynos_adc.c static irqreturn_t exynos_ts_isr(int irq, void *dev_id) · line 657

Quoted 8 lines
drivers/iio/adc/exynos_adc.c +1 -1
@@ -651,7 +651,7 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
 		input_sync(info->input);
 
 		usleep_range(1000, 1100);
-	};
+	}
 
 	writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
 
Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics
author maintainer Applied
#5 lore raw
Quoted 24 lines · On Mon, 14 Oct 2019 11:18:43 +0900 Chanwoo Choi <[email protected]> wrote:

Hi,

Quoted 21 lines · On 19. 10. 13. 오후 9:35, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Identified by coccinelle drivers/iio/adc/exynos_adc.c:654:2-3: Unneeded semicolon

---
 drivers/iio/adc/exynos_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/exynos_adc.c +1 -1
index 42a3ced11fbd..b5a497381452 100644
@@ -651,7 +651,7 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
 		input_sync(info->input);
 
 		usleep_range(1000, 1100);
-	};
+	}
 
Quoted 5 lines

drivers/iio/adc/exynos_adc.c static irqreturn_t exynos_ts_isr(int irq, void *dev_id) · line 657

Quoted 3 lines
drivers/iio/adc/exynos_adc.c +0 -0
 	writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
 

Applied.

Thanks,

Jonathan

Quoted 1 line