Skip to contentSkip to conversation

2.5.9-dj1, fix for make xconfig in drivers/isdn/Config.in

PATCH In review Steven Cole 2 participants 2 messages Apr 24, 2002 – Apr 25, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.5.9-dj1, fix for make xconfig in drivers/isdn/Config.in

I read that some of you got this while doing make xconfig.

[steven@localhost linux-2.5.9-dj1]$ make xconfig
rm -f include/asm
( cd include ; ln -sf asm-i386 asm)
make -C scripts kconfig.tk
make[1]: Entering directory `/home/steven/kernels/linux-2.5.9-dj1/scripts' cat header.tk >> ./kconfig.tk
./tkparse < ../arch/i386/config.in >> kconfig.tk drivers/isdn/Config.in: 10: incorrect argument
make[1]: *** [kconfig.tk] Error 1
make[1]: Leaving directory `/home/steven/kernels/linux-2.5.9-dj1/scripts'
make: *** [xconfig] Error 2

This fix seems to be the obvious one.

Steven

drivers/isdn/Config.in renamed from drivers/isdn/Config.in.orig +1 -1
@@ -7,7 +7,7 @@
 if [ "$CONFIG_NET" != "n" ]; then
    bool 'ISDN support' CONFIG_ISDN_BOOL
 
-   if [ "$CONFIG_ISDN_BOOL" == "y" ]; then
+   if [ "$CONFIG_ISDN_BOOL" = "y" ]; then
       mainmenu_option next_comment
       comment 'Old ISDN4Linux'
 
#1 lore raw
Quoted 14 lines · Steven Cole

I read that some of you got this while doing make xconfig.

[steven@localhost linux-2.5.9-dj1]$ make xconfig
rm -f include/asm
( cd include ; ln -sf asm-i386 asm)
make -C scripts kconfig.tk
make[1]: Entering directory `/home/steven/kernels/linux-2.5.9-dj1/scripts' cat header.tk >> ./kconfig.tk
./tkparse < ../arch/i386/config.in >> kconfig.tk drivers/isdn/Config.in: 10: incorrect argument
make[1]: *** [kconfig.tk] Error 1
make[1]: Leaving directory `/home/steven/kernels/linux-2.5.9-dj1/scripts'
make: *** [xconfig] Error 2

Quoted 1 line

This fix seems to be the obvious one.

This is definitely the right fix, now that I compare what I threw to
the list earlier, to the other Config.in scripts in the tree. Plus, this applies to a vanilla 2.5.10.

Linus, Dave, please consider applying.

BL.

Signature · 4 lines
Brad Littlejohn                         | Email:        [email protected]
Unix Systems Administrator,             |           [email protected]
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF