clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
Subsystems (2)
PATCH 1/1 clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
gpio clock is getting disabled to save power but pclk_cpu is needed for act8865 regulator
--- drivers/clk/rockchip/clk-rk3188.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/rockchip/clk-rk3188.c +1 -0
@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , + "pclk_cpu", };static void __init rk3188_common_clk_init (struct device_node *np)
Signature · 1 line
2.5.0
Heiko Stuebner
maintainerHi,
Am Montag, 17. August 2015, 19:38:22 schrieb Michael Niewoehner:
Quoted 2 lines
gpio clock is getting disabled to save power but
pclk_cpuis needed for act8865 regulator
Please refine the commit message a bit :-) . Something along
pclk_cpu needs to keep running and with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.
and also please add "Linus Walleij <[email protected]>" to the list of recipients. As the gpio clock handling change does go through his tree, the matching critical clock handling should also go through him.
Heiko
Quoted 18 lines
Signed-off-by Michael Niewoehner <[email protected]>--- drivers/clk/rockchip/clk-rk3188.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/rockchip/clk-rk3188.cindex e4f9d47..1c93229 100644drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]__initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , +"pclk_cpu" , };static void __init rk3188_common_clk_init (struct device_node *np)
Hi Heiko,
I merged yours and mine :-)
pclk_cpu needs to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.
---drivers/clk/rockchip/clk-rk3188.c | 1 +
1 file changed, 1 insertion(+)
drivers/clk/rockchip/clk-rk3188.c +0 -0
@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
"aclk_cpu", "aclk_peri", "hclk_peri",
+ "pclk_cpu",
};
static void __init rk3188_common_clk_init(struct device_node *np)
Signature · 7 lines
2.5.0 Am 17.08.2015 um 20:01 schrieb Heiko Stuebner <[email protected]>:
Quoted 39 lines
Hi,
Am Montag, 17. August 2015, 19:38:22 schrieb Michael Niewoehner:
Quoted 2 lines
gpio clock is getting disabled to save power but
pclk_cpuis needed for act8865 regulatorPlease refine the commit message a bit :-) . Something along
pclk_cpuneeds to keep running and with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.and also please add "Linus Walleij <[email protected]>" to the list of recipients. As the gpio clock handling change does go through his tree, the matching critical clock handling should also go through him.
Heiko
Quoted 18 lines
Signed-off-by Michael Niewoehner <[email protected]>---
drivers/clk/rockchip/clk-rk3188.c| 1 +1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/rockchip/clk-rk3188.cindex e4f9d47..1c93229 100644drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]__initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , +"pclk_cpu" , };static void __init rk3188_common_clk_init (struct device_node *np)
Heiko Stuebner
maintainerHi Michael,
need to pick a bit more on your patch submission :-)
Please take a look for example at
http://lists.infradead.org/pipermail/linux-rockchip/2014-November/001043.html
on how a v2 submission needs to look like.
Specifically:
- In most cases not as a reply to a reply to another mail.
- Mail subject: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
Am Montag, 17. August 2015, 20:51:14 schrieb Michael Niewoehner:
Quoted 5 lines
Hi Heiko,
I merged yours and mine :-)
no prose nor empty lines. If necessary such stuff could sit below the "---" which results in it not making it into the actuall commit message.
Quoted 6 lines
pclk_cpuneeds to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.Signed-off-by Michael Niewoehner <[email protected]>---
Here any prose-text you like to add.
Also, changelog:
changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock change in the rockchip pinctrl driver it should go through his tree as well
Quoted 8 lines
drivers/clk/rockchip/clk-rk3188.c| 1 +1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/rockchip/clk-rk3188.cindex e4f9d47..1c93229 100644
drivers/clk/rockchip/clk-rk3188.c static const char *const rk3188_critical_clocks[] · line 714
Quoted 7 lines
drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]__initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , +"pclk_cpu" , };static void __init rk3188_common_clk_init (struct device_node *np)
no quotes of other mails, like the stuff below.
Heiko
Quoted 40 lines
Quoted 40 lines
Hi,
Am Montag, 17. August 2015, 19:38:22 schrieb Michael Niewoehner:
Quoted 2 lines
gpio clock is getting disabled to save power but
pclk_cpuis needed for act8865 regulatorPlease refine the commit message a bit :-) . Something along
pclk_cpuneeds to keep running and with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.and also please add "Linus Walleij <[email protected]>" to the list of recipients. As the gpio clock handling change does go through his tree, the matching critical clock handling should also go through him.
Heiko
Quoted 19 lines
Signed-off-by Michael Niewoehner <[email protected]>---
drivers/clk/rockchip/clk-rk3188.c| 1 +1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/rockchip/clk-rk3188.cindex e4f9d47..1c93229 100644drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]__initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , +"pclk_cpu" , };static void
__initrk3188_common_clk_init(struct device_node *np)
PATCH v2 1/1 clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
pclk_cpu needs to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.
---
Changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock change in the rockchip pinctrl driver it should go through his tree as well
drivers/clk/rockchip/clk-rk3188.c | 1 +
1 file changed, 1 insertion(+)
drivers/clk/rockchip/clk-rk3188.c +0 -0
@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
"aclk_cpu", "aclk_peri", "hclk_peri",
+ "pclk_cpu",
};
static void __init rk3188_common_clk_init(struct device_node *np)
Signature · 1 line
2.5.0
Am Montag, 17. August 2015, 21:50:53 schrieb Michael Niewoehner:
Quoted 5 lines
pclk_cpuneeds to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.Signed-off-by Michael Niewoehner <[email protected]>
Quoted 21 lines
---
Changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock change in the rockchip pinctrl driver it should go through his tree as well
drivers/clk/rockchip/clk-rk3188.c| 1 +1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/rockchip/clk-rk3188.cindex e4f9d47..1c93229 100644drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]__initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , +"pclk_cpu" , };static void __init rk3188_common_clk_init (struct device_node *np)
Quoting Michael Niewoehner (2015-08-17 12:50:53)
Quoted 5 lines
pclk_cpuneeds to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.Signed-off-by Michael Niewoehner <[email protected]>
Patch fails to apply due to a problem with line 15. git format-patch problem?
Regards,
Mike
Quoted 28 lines
---
Changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock change in the rockchip pinctrl driver it should go through his tree as well
drivers/clk/rockchip/clk-rk3188.c| 1 +1 file changed, 1 insertion(+)drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , + "pclk_cpu", };static void __init rk3188_common_clk_init (struct device_node *np)Signature · 6 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Heiko Stuebner
maintainerAm Dienstag, 25. August 2015, 11:59:31 schrieb Michael Turquette:
Quoted 10 lines
Quoting Michael Niewoehner (2015-08-17 12:50:53)
Quoted 5 lines
pclk_cpuneeds to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.Signed-off-by Michael Niewoehner <[email protected]>Patch fails to apply due to a problem with line 15. git format-patch problem?
see comment below. We triggered this problem with a change to the pinctrl driver and another clock-entry to the critical clocks already went into Linus' pinctrl tree. So I guess this patch should probably also go through his tree - or just go in through any tree after 4.3-rc1.
Quoted 29 lines
Regards,
MikeQuoted 25 lines
---
Changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock>
change in the rockchip pinctrl driver it should go through his tree as well
drivers/clk/rockchip/clk-rk3188.c| 1 +1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/rockchip/clk-rk3188.cindex e4f9d47..1c93229 100644drivers/clk/rockchip/clk-rk3188.c +0
-0@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]
__initconst= {>"aclk_cpu", "aclk_peri", "hclk_peri",+ "
pclk_cpu",
};static void
__initrk3188_common_clk_init(struct device_node *np)
PATCH v3 1/1 clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
In reply to Michael Turquettepclk_cpu needs to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.
---
Changes in v3:
- fix git format-patch problem
Changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock change in the rockchip pinctrl driver it should go through his tree as well
drivers/clk/rockchip/clk-rk3188.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/rockchip/clk-rk3188.c +1 -0
@@ -716,6 +716,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , + "pclk_cpu", };static void __init rk3188_common_clk_init (struct device_node *np)
Signature · 1 line
2.5.0
PATCH v3 1/1 clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
Quoting Michael Niewoehner (2015-08-25 13:22:07)
Quoted 6 lines
pclk_cpuneeds to keep running because it is needed for devices like the act8865 regulator but with the recent gpio clock handling this is not always the case anymore. So add it to the list of critical clocks.Signed-off-by Michael Niewoehner <[email protected]>Reviewed-by Heiko Stuebner <[email protected]>
This patch applies cleanly to clk-next, so I guess the patch formatting issues have been resolved ;-)
Note that I did NOT apply this to the clk tree, just locally for testing.
Regards,
Mike
Quoted 33 lines
---
Changes in v3:
- fix git format-patch problemChanges in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock change in the rockchip pinctrl driver it should go through his tree as welldrivers/clk/rockchip/clk-rk3188.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/rockchip/clk-rk3188.c +1
-0@@ -716,6 +716,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {"aclk_cpu" ,"aclk_peri" ,"hclk_peri" , + "pclk_cpu", };static void __init rk3188_common_clk_init (struct device_node *np)Signature · 8 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/