Skip to contentSkip to conversation

[2.4] ATM driver for the Alcatel SpeedTouch USB DSL modem

PATCH In review Luca Barbieri 2 participants 4 messages May 30, 2002

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [2.4] ATM driver for the Alcatel SpeedTouch USB DSL modem

Depends:
- [PATCH] [2.4, 2.5] printk helper functions
- [PATCH] [2.4] Waitable counter structure
- [PATCH] [2.4] ATM SAR support, based on SARlib

Recommends:
- [PATCH] [2.4] [2.5] Fix PPPoATM crash on disconnection (tasklet_disable; kfree(tasklet)) <merged in 2.4.19-pre9>

Look at Configure.help for the description.

This driver is based on the 1.5 driver written and maintained by Johan Verrept.
I sent an older version of this set of patches to him on 16/may/2002. On 20/may/2002 he replied saying that he would look at the patch, but he didn't send me any further messages.
So, since the identity of the maintainer doesn't matter when deciding whether to apply a patch or not, I'm sending this to linux-kernel without waiting for an answer from the 1.5 maintainer in order to save time.

Documentation/Configure.help +42 -0
diff --exclude-from=/home/ldb/src/linux-exclude -u -r -N linux-base/Documentation/Configure.help linux/Documentation/Configure.help
@@ -13824,6 +13824,48 @@
   Say Y here to include additional code to support the Sandisk SDDR-09
   SmartMedia reader in the USB Mass Storage driver.
 
+USB Alcatel SpeedTouch USB DSL modem support
+CONFIG_USB_SPEEDTOUCH
+  Say Y here if you want to connect an Alcatel SpeedTouch USB modem to
+  your computer's USB port.
+
+  This driver provides an ATM interface that uses the modem to
+  transfer data.  You must enable (Y or M in config) ATM (under
+  Networking Options) to use this driver. Information on this API may
+  be found on the WWW at <http://linux-atm.sourceforge.net>.
+
+  This driver is a revised version (that doesn't look much like the
+  original) of Johan Verrept's 1.5 SpeedTouch Driver.
+  Among the improvements of this 2.x branch are:
+  - Much more stability (hopefully); no deadlocks on shutdown
+  - Tons of locking added: SMP should work (not tested, I don't have a
+    suitable machine)
+  - Unlimited number of devices without compile-time configuration
+  - Processing of received data in URB completion handler, by default,
+    or in separate thread if configured at compile time
+  - If using PPPoATM, pppd will notice disconnection (thus you can
+    disable LCP echos and set configure request to 100000000)
+  - Inside the kernel tree
+
+  To use the device you also need a user-mode daemon that downloads
+  the firmware and (re)initializes the modem. Currently the only
+  working one is a closed source one from Alcatel that you can get at
+  <http://www.alcateldsl.com/support.htm>.
+
+  However, there is a lot of hope, since Benoit Papillaut has written
+  an user-mode driver that contains a program that with some
+  modifications can be used to replace the closed source
+  daemon. Anyway, you will still need the Alcatel daemon package to
+  extract the modem firmware from it.
+
+  For more information, see Johan Verrept's webpages at
+  <http://linux-usb.sourceforge.net/SpeedTouch/>.
+
+  This code is also available as a module ( = code which can be
+  inserted in and removed from the running kernel whenever you want).
+  The module will be called speedtouch.o. If you want to compile it as
+  a module, say M here and read <file:Documentation/modules.txt>.
+
 USB Diamond Rio500 support
 CONFIG_USB_RIO500
   Say Y here if you want to connect a USB Rio500 mp3 player to your
drivers/usb/Config.in +1 -0
diff --exclude-from=/home/ldb/src/linux-exclude -u -r -N linux-base/drivers/usb/Config.in linux/drivers/usb/Config.in
@@ -110,5 +110,6 @@
 comment 'USB Miscellaneous drivers'
 dep_tristate '  USB Diamond Rio500 support (EXPERIMENTAL)' CONFIG_USB_RIO500 $CONFIG_USB $CONFIG_EXPERIMENTAL
 dep_tristate '  USB Auerswald ISDN support (EXPERIMENTAL)' CONFIG_USB_AUERSWALD $CONFIG_USB $CONFIG_EXPERIMENTAL
+dep_tristate '  USB Alcatel SpeedTouch USB DSL modem support (needs ATM enabled)' CONFIG_USB_SPEEDTOUCH $CONFIG_USB $CONFIG_ATM
 
 endmenu
drivers/usb/Makefile +1 -0
diff --exclude-from=/home/ldb/src/linux-exclude -u -r -N linux-base/drivers/usb/Makefile linux/drivers/usb/Makefile
@@ -90,6 +90,7 @@
 obj-$(CONFIG_USB_USBDNET)	+= usbdnet.o
 obj-$(CONFIG_USB_USBVISION)     += usbvision.o saa7111-new.o i2c-algo-usb.o
 obj-$(CONFIG_USB_AUERSWALD)	+= auerswald.o
+obj-$(CONFIG_USB_SPEEDTOUCH)	+= speedtouch.o
 
 # Object files in subdirectories
 mod-subdirs	:= serial hcd
drivers/usb/speedtouch.c +1208 -0

1,208 lines not on this page · raw message

#1 lore raw
Quoted 4 lines · Luca Barbieri

Depends:
- [PATCH] [2.4, 2.5] printk helper functions
- [PATCH] [2.4] Waitable counter structure
- [PATCH] [2.4] ATM SAR support, based on SARlib

Because of these dependencies (and the fact that the maintainer doesn't want it added yet) I will not apply this patch.

Quoted 6 lines

Recommends:
- [PATCH] [2.4] [2.5] Fix PPPoATM crash on disconnection (tasklet_disable; kfree(tasklet)) <merged in 2.4.19-pre9>

Look at Configure.help for the description.

Quoted 9 lines

This driver is based on the 1.5 driver written and maintained by Johan Verrept.
I sent an older version of this set of patches to him on 16/may/2002. On 20/may/2002 he replied saying that he would look at the patch, but he didn't send me any further messages.
So, since the identity of the maintainer doesn't matter when deciding whether to apply a patch or not, I'm sending this to linux-kernel without waiting for an answer from the 1.5 maintainer in order to save time.

Sending this to linux-usb-devel might be a better place, instead of bothering linux-kernel.

thanks,

greg k-h

#2 lore raw
Quoted 2 lines

Because of these dependencies (and the fact that the maintainer doesn't want it added yet) I will not apply this patch.

That's ok (right now). Application of it should only be considered after discussion here and after the maintainer responds.

Quoted 2 lines

Sending this to linux-usb-devel might be a better place, instead of bothering linux-kernel.

Should I have sent the first two patches to linux-kernel, the ATM SAR to linux-atm-general and the SpeedTouch driver to linux-usb-devel? How should I have handled the fact that the SpeedTouch and ATM SAR patches depend on main kernel patches and the fact that the SpeedTouch patch includes ATM code (since it is for an ATM device attached to the USB bus)?

#3 lore raw
In reply to Luca Barbieri
Quoted 5 lines · Luca Barbieri
Quoted 2 lines

Because of these dependencies (and the fact that the maintainer doesn't want it added yet) I will not apply this patch.

That's ok (right now). Application of it should only be considered after discussion here and after the maintainer responds.

Quoted 8 lines
Quoted 2 lines

Sending this to linux-usb-devel might be a better place, instead of bothering linux-kernel.

Should I have sent the first two patches to linux-kernel, the ATM SAR to linux-atm-general and the SpeedTouch driver to linux-usb-devel? How should I have handled the fact that the SpeedTouch and ATM SAR patches depend on main kernel patches and the fact that the SpeedTouch patch includes ATM code (since it is for an ATM device attached to the USB bus)?

Well, if you want a ATM patch added, you need to send it to the ATM maintainer (but I don't know if there is one right now or not.) And if you want a USB driver added to the USB tree, you need to send it to the USB maintainer. So cross-posting to all of these lists is probably a good idea :)

greg k-h