eal: use abstracted bit count functions
PATCH 1/1 eal: use abstracted bit count functions
Use DPDK abstracted bitcount functions in rte_bsf and rte_fls inline functions.
Signed-off-by Tyler Retzlaff <[email protected]>
--- lib/eal/include/rte_bitops.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
lib/eal/include/rte_bitops.h +4 -4
@@ -574,7 +574,7 @@static inline uint32_t rte_bsf32 (uint32_t v) { -return (uint32_t )__builtin_ctz (v); +return (uint32_t )rte_ctz32 (v); }/**
@@ -615,7 +615,7 @@static inline uint32_t rte_bsf64 (uint64_t v) { -return (uint32_t )__builtin_ctzll (v); +return (uint32_t )rte_ctz64 (v); }/**
@@ -656,7 +656,7 @@static inline uint32_t rte_fls_u32 (uint32_t x) { -return (x ==0 ) ?0 :32 -__builtin_clz (x); +return (x ==0 ) ?0 :32 -rte_clz32 (x); }/**
@@ -674,7 +674,7 @@static inline uint32_t rte_fls_u64 (uint64_t x) { -return (x ==0 ) ?0 :64 -__builtin_clzll (x); +return (x ==0 ) ?0 :64 -rte_clz64 (x); }/*********** Macros to work with powers of 2 ********/
Signature · 1 line
1.8.3.1
PATCH v2 1/1 eal: use abstracted bit count functions
Use DPDK abstracted bitcount functions instead of gcc __builtin_'s
Signed-off-by Tyler Retzlaff <[email protected]>
--- lib/eal/common/malloc_elem.c | 2 +- lib/eal/common/rte_service.c | 4 ++-- lib/eal/include/rte_bitops.h | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-)
lib/eal/common/malloc_elem.c +1 -1
@@ -386,7 +386,7 @@return 0 ;/* Find next power of 2 > size. */ - log2 =sizeof (size) *8 -__builtin_clzl (size); + log2 =sizeof (size) *8 -rte_clz64 (size);/* Compute freelist index, based on log2(size). */ index = (log2 - MALLOC_MINSIZE_LOG2 + MALLOC_LOG2_INCREMENT - 1) /
lib/eal/common/rte_service.c +2 -2
@@ -505,8 +505,8 @@ struct core_state {if (service_mask ==0 )continue ; - start_id =__builtin_ctzl (service_mask); - end_id =64 -__builtin_clzl (service_mask); + start_id =rte_ctz64 (service_mask); + end_id =64 -rte_clz64 (service_mask);for (i = start_id; i < end_id; i++) {/* return value ignored as no change to code flow */
lib/eal/include/rte_bitops.h +4 -4
@@ -574,7 +574,7 @@static inline uint32_t rte_bsf32 (uint32_t v) { -return (uint32_t )__builtin_ctz (v); +return (uint32_t )rte_ctz32 (v); }/**
@@ -615,7 +615,7 @@static inline uint32_t rte_bsf64 (uint64_t v) { -return (uint32_t )__builtin_ctzll (v); +return (uint32_t )rte_ctz64 (v); }/**
@@ -656,7 +656,7 @@static inline uint32_t rte_fls_u32 (uint32_t x) { -return (x ==0 ) ?0 :32 -__builtin_clz (x); +return (x ==0 ) ?0 :32 -rte_clz32 (x); }/**
@@ -674,7 +674,7 @@static inline uint32_t rte_fls_u64 (uint64_t x) { -return (x ==0 ) ?0 :64 -__builtin_clzll (x); +return (x ==0 ) ?0 :64 -rte_clz64 (x); }/*********** Macros to work with powers of 2 ********/
Signature · 1 line
1.8.3.1
Thomas Monjalon
Applied16/10/2023 04:06, Tyler Retzlaff:
Quoted 3 lines
Use DPDK abstracted bitcount functions instead of gcc __builtin_'s
Signed-off-by Tyler Retzlaff <[email protected]>
Applied, thanks.