Skip to contentSkip to conversation

page-writeback.c compile warning fix

PATCH In review Robert Love 2 participants 2 messages Jul 23, 2002 Page cache

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 page-writeback.c compile warning fix

Andrew and Linus,

Compile of mm/page-writeback.c gives a warning of undefined use of "writeback_backing_dev()".

Patch is against 2.5.27, please apply.

Robert Love

include/linux/backing-dev.h +2 -0
diff -urN linux-2.5.27/include/linux/backing-dev.h linux/include/linux/backing-dev.h
@@ -26,5 +26,7 @@
 int writeback_acquire(struct backing_dev_info *bdi);
 int writeback_in_progress(struct backing_dev_info *bdi);
 void writeback_release(struct backing_dev_info *bdi);
+void writeback_backing_dev(struct backing_dev_info *bdi, int *nr_to_write,
+	enum writeback_sync_modes sync_mode, unsigned long *older_than_this);
 
 #endif		/* _LINUX_BACKING_DEV_H */
#1 lore raw
Quoted 6 lines · Robert Love

Andrew and Linus,

Compile of mm/page-writeback.c gives a warning of undefined use of "writeback_backing_dev()".

Yeah, sorry. I missed a file when generating the diff. I have this in the pending pile:

 writeback.h |    5 +++++
 1 files changed, 5 insertions(+)
include/linux/writeback.h renamed from include/linux/writeback.h~writeback-warning +5 -0
@@ -8,6 +8,8 @@
 #ifndef WRITEBACK_H
 #define WRITEBACK_H
 
+struct backing_dev_info;
+
 extern spinlock_t inode_lock;
 extern struct list_head inode_in_use;
 extern struct list_head inode_unused;
@@ -38,6 +40,9 @@ void wake_up_inode(struct inode *inode);
 void __wait_on_inode(struct inode * inode);
 void sync_inodes_sb(struct super_block *, int wait);
 void sync_inodes(int wait);
+void writeback_backing_dev(struct backing_dev_info *bdi, int *nr_to_write,
+			enum writeback_sync_modes sync_mode,
+			unsigned long *older_than_this);
 
 /* writeback.h requires fs.h; it, too, is not included from here. */
 static inline void wait_on_inode(struct inode *inode)

.