Skip to contentSkip to conversation

fix busted pr_info conversion in kernel/workqueue.c

PATCH New Valdis Kletnieks 1 participant 1 message May 27, 2014 Workqueue

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix busted pr_info conversion in kernel/workqueue.c

commit 2d916033a318d7e763eb099c69600d5dcd1ccb6b

Author: Fabian Frederick <[email protected]>
Date:   Mon May 12 13:59:35 2014 -0400

kernel/workqueue.c: pr_warning/pr_warn & printk/pr_info

This commit did an incorrect printk->pr_info conversion. If we were converting to pr_info() we should lose the log_level parameter. The problem is that this is called (indirectly) by show_regs_print_info(), which is called with various log_levels (from _INFO clear to _EMERG). So we leave it as a printk() call so the desired log_level is applied.

Not a full revert, as the other half of the patch is correct.

kernel/workqueue.c renamed from kernel/workqueue.c.dist +1 -1
@@ -4440,7 +4440,7 @@ void print_worker_info(const char *log_l
 		probe_kernel_read(desc, worker->desc, sizeof(desc) - 1);
 
 	if (fn || name[0] || desc[0]) {
-		pr_info("%sWorkqueue: %s %pf", log_lvl, name, fn);
+		printk("%sWorkqueue: %s %pf", log_lvl, name, fn);
 		if (desc[0])
 			pr_cont(" (%s)", desc);
 		pr_cont("\n");