Skip to contentSkip to conversation

2.5.33 PNPBIOS does not compile

DISCUSSION Nicholas Miell 2 participants 2 messages Sep 1, 2002 Pnp support

lore
Share & tools
lore
#0 lore raw

pnpbios_core.c: In function `call_pnp_bios':
pnpbios_core.c:167: invalid lvalue in unary &' pnpbios_core.c:167: invalid lvalue in unary &' pnpbios_core.c:169: invalid lvalue in unary &' pnpbios_core.c:169: invalid lvalue in unary &' pnpbios_core.c: In function `pnpbios_init':
pnpbios_core.c:1276: invalid lvalue in unary &' pnpbios_core.c:1276: invalid lvalue in unary &' pnpbios_core.c:1277: invalid lvalue in unary &' pnpbios_core.c:1277: invalid lvalue in unary &' pnpbios_core.c:1278: invalid lvalue in unary &' pnpbios_core.c:1278: invalid lvalue in unary &' make[2]: *** [pnpbios_core.o] Error 1
make[2]: Target `first_rule' not remade because of errors. make[1]: *** [pnp] Error 2

... which is the result of the expansion of the Q_SET_SEL and Q2_SET_SEL macros.

My guess is that changing the macros so that they use set_limit instead of _set_limit is what broke things, but I don't understand any of this x86 segmentation voodoo, so I'm not touching it.

#1 lore raw
Quoted 16 lines · Nicholas Miell

pnpbios_core.c: In function `call_pnp_bios':
pnpbios_core.c:167: invalid lvalue in unary &' pnpbios_core.c:167: invalid lvalue in unary &' pnpbios_core.c:169: invalid lvalue in unary &' pnpbios_core.c:169: invalid lvalue in unary &' pnpbios_core.c: In function `pnpbios_init':
pnpbios_core.c:1276: invalid lvalue in unary &' pnpbios_core.c:1276: invalid lvalue in unary &' pnpbios_core.c:1277: invalid lvalue in unary &' pnpbios_core.c:1277: invalid lvalue in unary &' pnpbios_core.c:1278: invalid lvalue in unary &' pnpbios_core.c:1278: invalid lvalue in unary &' make[2]: *** [pnpbios_core.o] Error 1
make[2]: Target `first_rule' not remade because of errors. make[1]: *** [pnp] Error 2

Quoted 2 lines

... which is the result of the expansion of the Q_SET_SEL and Q2_SET_SEL macros.

Yes, this should fix the problem.

drivers/pnp/pnpbios_core.c +2 -2
diff --exclude-from=/home/ldb/src/linux-exclude -urNdp linux-2.5.32/drivers/pnp/pnpbios_core.c linux-2.5.32_pnpbelow/drivers/pnp/pnpbios_core.c
@@ -127,11 +127,11 @@ __asm__(
 
 #define Q_SET_SEL(cpu, selname, address, size) \
 set_base(cpu_gdt_table[cpu][(selname) >> 3], __va((u32)(address))); \
-set_limit(&cpu_gdt_table[cpu][(selname) >> 3], size)
+set_limit(cpu_gdt_table[cpu][(selname) >> 3], size)
 
 #define Q2_SET_SEL(cpu, selname, address, size) \
 set_base(cpu_gdt_table[cpu][(selname) >> 3], (u32)(address)); \
-set_limit(&cpu_gdt_table[cpu][(selname) >> 3], size)
+set_limit(cpu_gdt_table[cpu][(selname) >> 3], size)
 
 /*
  * At some point we want to use this stack frame pointer to unwind