dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases
Subsystems (3)
PATCH 1/1 dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/dma/tegra210-adma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/tegra210-adma.c +2 -1
@@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) ret =pm_runtime_get_sync (tdc2dev (tdc));if (ret <0 ) {free_irq (tdc->irq, tdc); +pm_runtime_put (tdc2dev (tdc));return ret; }
@@ -870,7 +871,7 @@ static int tegra_adma_probe(struct platform_device *pdev) ret =pm_runtime_get_sync (&pdev->dev);if (ret <0 ) - goto rpm_disable; + goto rpm_put; ret =tegra_adma_init (tdma);if (ret)
Signature · 1 line
2.17.1
Jon Hunter
maintainerQuoted 23 lines · Navid Emamdoost
Calling
pm_runtime_get_syncincrements the counter even in case of failure, causing incorrect ref count. Callpm_runtime_putifpm_runtime_get_syncfails.Signed-off-by Navid Emamdoost <[email protected]>--- drivers/dma/tegra210-adma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/dma/tegra210-adma.c +1
-0@@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) ret =pm_runtime_get_sync (tdc2dev (tdc));if (ret <0 ) {free_irq (tdc->irq, tdc); +pm_runtime_put (tdc2dev (tdc));return ret; }
drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 877
Quoted 8 lines
drivers/dma/tegra210-adma.c +1
-1@@ -870,7 +871,7 @@ static int tegra_adma_probe(struct platform_device *pdev) ret =pm_runtime_get_sync (&pdev->dev);if (ret <0 ) - goto rpm_disable; + goto rpm_put; ret =tegra_adma_init (tdma);if (ret)
The label rpm_disable should now be removed. You should also update the subject-prefix to be [PATCH V2] to make it clear that this is the updated patch.
Jon
Signature · 1 line
nvpublic