Skip to contentSkip to conversation

2.5.3[3,4] Preemption problem

DISCUSSION Paolo Ciarrocchi 2 participants 3 messages Sep 9, 2002 – Sep 10, 2002

lore
Share & tools
lore
#0 lore raw

Hi all,

$ shutdown -h now

...
...
Halting system...
Shutting down devices
Power down.
note: halt[15347] exited with preempt_count 1

With 2.5.33 and 2.5.34.
Let me know is you need further information.

Ciao,
Paolo

Signature · 4 lines
Get your free email from www.linuxmail.org 


Powered by Outblaze
#1 lore raw
Quoted 4 lines · Paolo Ciarrocchi

Halting system...
Shutting down devices
Power down.
note: halt[15347] exited with preempt_count 1

Note the "note" - this is just advisory and is not harmful. :)

Somewhere in the shutdown logic a lock (probably the BKL) is not released (and why not, we are shutting down?). I'll see if I can find it...

Robert Love

#2 lore raw
In reply to Paolo Ciarrocchi
Quoted 4 lines · Paolo Ciarrocchi

Halting system...
Shutting down devices
Power down.
note: halt[15347] exited with preempt_count 1

I cooked up a patch... does this solve the problem (no more spurious warning on reboot)?

Patch is against 2.5.34.

Robert Love

kernel/sys.c +3 -1
diff -urN linux-2.5.34/kernel/sys.c linux/kernel/sys.c
@@ -316,7 +316,7 @@
 
 	/* For safety, we require "magic" arguments. */
 	if (magic1 != LINUX_REBOOT_MAGIC1 ||
-	    (magic2 != LINUX_REBOOT_MAGIC2 && magic2 != LINUX_REBOOT_MAGIC2A &&
+	   (magic2 != LINUX_REBOOT_MAGIC2 && magic2 != LINUX_REBOOT_MAGIC2A &&
 			magic2 != LINUX_REBOOT_MAGIC2B))
 		return -EINVAL;
 
@@ -344,6 +344,7 @@
 		device_shutdown();
 		printk(KERN_EMERG "System halted.\n");
 		machine_halt();
+		unlock_kernel();
 		do_exit(0);
 		break;
 
@@ -353,6 +354,7 @@
 		device_shutdown();
 		printk(KERN_EMERG "Power down.\n");
 		machine_power_off();
+		unlock_kernel();
 		do_exit(0);
 		break;