Skip to contentSkip to conversation

onfigs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

PATCH Superseded Roberto Medina 2 participants 9 messages Aug 11, 2023 – Aug 12, 2023

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover onfigs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

v3 -> v2:
* Several fixes after reviews from Thomas Petazzoni.
* Add myself to the DEVELOPERS file.
* Remove the binutils version from the defconfig file.
* Set custom version of Linux to 6.1.45.
* Ext2 size needs to be increased a little to produce the final image.
* Fix the tag for TFA to v2.9 instead of v2.9.0.
* Set custom version of U-Boot to 2022.04.
* Remove U-Boot host tools.

v2 -> v1:
* Use a more recent version of U-boot.
* Built-tested by Kilian Zinnecker.

Roberto Medina (1):
configs/roc_rk3399_pc: Bring back and update the configuration for the
rockchip rk3399 built by firefly.

 DEVELOPERS                                |  4 +++
 board/firefly/roc-rk3399-pc/extlinux.conf |  4 +++
 board/firefly/roc-rk3399-pc/genimage.cfg  | 22 ++++++++++++
 board/firefly/roc-rk3399-pc/post-build.sh |  5 +++
 board/firefly/roc-rk3399-pc/readme.txt    | 40 +++++++++++++++++++++
 configs/roc_pc_rk3399_defconfig           | 42 +++++++++++++++++++++++
 6 files changed, 117 insertions(+)
 create mode 100644 board/firefly/roc-rk3399-pc/extlinux.conf
 create mode 100644 board/firefly/roc-rk3399-pc/genimage.cfg
 create mode 100755 board/firefly/roc-rk3399-pc/post-build.sh
 create mode 100644 board/firefly/roc-rk3399-pc/readme.txt
 create mode 100644 configs/roc_pc_rk3399_defconfig
Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH v3 1/1 configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

* Uses a version 2.9 of TF-A which solves the building issue for this board.
* Increase the size of the ext2 partition to be able to create the final image.
* Bump and set the U-Boot version that was used for this configuration.
* Bump and set the version of Linux to 6.1.45.
* Some minor fixes in the post-build.sh script using shellcheck.

---
 DEVELOPERS                                |  4 +++
 board/firefly/roc-rk3399-pc/extlinux.conf |  4 +++
 board/firefly/roc-rk3399-pc/genimage.cfg  | 22 ++++++++++++
 board/firefly/roc-rk3399-pc/post-build.sh |  5 +++
 board/firefly/roc-rk3399-pc/readme.txt    | 40 +++++++++++++++++++++
 configs/roc_pc_rk3399_defconfig           | 42 +++++++++++++++++++++++
 6 files changed, 117 insertions(+)
 create mode 100644 board/firefly/roc-rk3399-pc/extlinux.conf
 create mode 100644 board/firefly/roc-rk3399-pc/genimage.cfg
 create mode 100755 board/firefly/roc-rk3399-pc/post-build.sh
 create mode 100644 board/firefly/roc-rk3399-pc/readme.txt
 create mode 100644 configs/roc_pc_rk3399_defconfig
DEVELOPERS +4 -0
index 6ffa3ee693..5ebabd01cb 100644
@@ -2546,6 +2546,10 @@ F:	package/mhz/
 N:	Robert Rose <[email protected]>
 F:	package/grpc/
 
+N:	Roberto Medina <[email protected]>
+F:	configs/roc_pc_rk3399_defconfig
+F:	board/firefly/roc-rk3399
+
 N:	Rodrigo Rebello <[email protected]>
 F:	package/chocolate-doom/
 F:	package/irssi/
board/firefly/roc-rk3399-pc/extlinux.conf new file +4 -0
new file mode 100644
index 0000000000..50a358fadc
@@ -0,0 +1,4 @@
+label RK3399RocPC linux
+  kernel /boot/Image
+  devicetree /boot/rk3399-roc-pc.dtb
+  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk0p1 rootwait
board/firefly/roc-rk3399-pc/genimage.cfg new file +22 -0
new file mode 100644
index 0000000000..966c869273
@@ -0,0 +1,22 @@
+image sdcard.img {
+	hdimage {
+	}
+
+	partition u-boot-tpl-spl-dtb {
+		in-partition-table = "no"
+		image = "idbloader.img"
+		offset = 32K
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot.itb"
+		offset = 8M
+		size = 30M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
board/firefly/roc-rk3399-pc/post-build.sh new file +5 -0
new file mode 100755
index 0000000000..d84a5da0b0
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname "$0")"
+
+install -m 0644 -D "$BOARD_DIR"/extlinux.conf "$TARGET_DIR"/boot/extlinux/extlinux.conf
board/firefly/roc-rk3399-pc/readme.txt new file +40 -0
new file mode 100644
index 0000000000..8a6f1cdee6
@@ -0,0 +1,40 @@
+Libre Computer Board ROC-RK3399-PC
+===================================
+
+Build:
+
+  $ make roc_pc_rk3399_defconfig
+  $ make
+
+Files created in output directory
+=================================
+
+output/images
+
+├── bl31.elf
+├── idbloader.img
+├── Image
+├── rk3399-roc-pc.dtb
+├── rootfs.ext2
+├── rootfs.ext4 -> rootfs.ext2
+├── rootfs.tar
+├── sdcard.img
+├── u-boot.bin
+└── u-boot.itb
+
+Creating bootable SD card:
+==========================
+
+Simply invoke (as root)
+
+sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
+
+Where X is your SD card device
+
+Serial console
+--------------
+
+Baudrate for this board is 1500000
+
+Wiki link:
+https://wiki.amarulasolutions.com/bsp/rockchip/rk3399/roc-rk3399-pc.html
configs/roc_pc_rk3399_defconfig new file +42 -0

42 lines not on this page · raw message

Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

Hello Roberto,

here are a few things, which could be improved:

[--SNIP--]

DEVELOPERS F: package/mhz/ · line 2551

Quoted 11 lines
DEVELOPERS +3 -0
index 6ffa3ee693..5ebabd01cb 100644
@@ -2546,6 +2546,10 @@ F:	package/mhz/
 N:	Robert Rose <[email protected]>
 F:	package/grpc/
 
+N:	Roberto Medina <[email protected]>
+F:	configs/roc_pc_rk3399_defconfig
+F:	board/firefly/roc-rk3399

I think when it comes to repositories (i.e., board/firefly/roc-rk3399) it is best practice to add a trailing space. I guess this way one can easily distinguish directories from single files.

[--SNIP--]

In the defconfig:

DEVELOPERS F: package/mhz/ · line 2553

Quoted 2 lines
DEVELOPERS +2 -0
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"

I think 2022.04 is actually the current default version of buildroot. So unless you have reason to freeze it to this version on purpose (e.g., because older and newer versions are known to be not working with this board - which I don't believe is the case) you could simply omit these two lines.

[--SNIP--]

Best regards,
Kilian Zinnecker

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

Hello Roberto,

Quoted 9 lines
Quoted 9 lines
DEVELOPERS +0 -0
index 6ffa3ee693..5ebabd01cb 100644
@@ -2546,6 +2546,10 @@ F:	package/mhz/
 
 N:	Robert Rose <[email protected]>
 F:	package/grpc/
 
Quoted 7 lines

DEVELOPERS F: package/mhz/ · line 2551

Quoted 3 lines
DEVELOPERS +3 -0
+N:	Roberto Medina <[email protected]>
+F:	configs/roc_pc_rk3399_defconfig
+F:	board/firefly/roc-rk3399

I think when it comes to repositories (i.e., board/firefly/roc-rk3399) it is best practice to add a trailing space. I guess this way one can easily distinguish directories from single files.

... a trailing slash instead of a trailing space, of course ...

Best regards,
Kilian

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

In reply to Kilian Zinnecker via buildroot

Hi Kilian,

Thanks for reviewing as usual.

Quoted 8 lines · Kilian Zinnecker
Quoted 8 lines
DEVELOPERS +0 -0
index 6ffa3ee693..5ebabd01cb 100644
@@ -2546,6 +2546,10 @@ F:	package/mhz/
  N:	Robert Rose <[email protected]>
  F:	package/grpc/
 
Quoted 7 lines

DEVELOPERS F: package/mhz/ · line 2551

Quoted 3 lines
DEVELOPERS +3 -0
+N:	Roberto Medina <[email protected]>
+F:	configs/roc_pc_rk3399_defconfig
+F:	board/firefly/roc-rk3399

I think when it comes to repositories (i.e., board/firefly/roc-rk3399) it is best practice to add a trailing space. I guess this way one can easily distinguish directories from single files.

Noted for the trailing slash.

Quoted 7 lines

DEVELOPERS F: package/mhz/ · line 2553

Quoted 2 lines
DEVELOPERS +2 -0
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"

I think 2022.04 is actually the current default version of buildroot. So unless you have reason to freeze it to this version on purpose (e.g., because older and newer versions are known to be not working with this board - which I don't believe is the case) you could simply omit these two lines.

Actually in v2 of this patch, Thomas requested to set a fixed version for U-Boot (mail from 08/08). Which made sense to me as TFA and Linux have a fixed version as well.

Best,
Roberto
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

Hello Robert,

[--SNIP--]

Quoted 9 lines
Quoted 8 lines

configs/roc_pc_rk3399_defconfig line 30

Quoted 2 lines
configs/roc_pc_rk3399_defconfig new file +2 -0
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"

I think 2022.04 is actually the current default version of buildroot. So unless you have reason to freeze it to this version on purpose (e.g., because older and newer versions are known to be not working with this board - which I don't believe is the case) you could simply omit these two lines.

Quoted 3 lines

Actually in v2 of this patch, Thomas requested to set a fixed version for U-Boot (mail from 08/08). Which made sense to me as TFA and Linux have a fixed version as well.

Ah, I see, makes sense ... then never mind my comment :)

Best regards,
Kilian

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#6 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

Quoted 5 lines · On Fri, 11 Aug 2023 23:59:11 +0200 Kilian Zinnecker via buildroot…
Quoted 3 lines

Actually in v2 of this patch, Thomas requested to set a fixed version for U-Boot (mail from 08/08). Which made sense to me as TFA and Linux have a fixed version as well.

Ah, I see, makes sense ... then never mind my comment :)

Correct, our convention in defconfigs is that the version of the Linux kernel and bootloader/firmware should be fixed. Indeed, we want the defconfigs to be known working configurations, that have been tested on hardware. If we let them the default/latest Linux/U-Boot version, it means this version gets auto-updated, without the defconfig maintainer necessarily checking that it is still works OK on HW.

So: policy is to use fixed version for Linux kernel and bootloaders in defconfigs.

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#7 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

In reply to Roberto Medina

Hello Roberto,

I've applied your patch to our next branch, with some very minor updates.

First, I simplified the commit title to:

configs/roc_rk3388_pc: new defconfig

See below for more comments.

Quoted 7 lines · On Fri, 11 Aug 2023 18:25:38 +0200 Roberto Medina <[email protected]> wrote:

* Uses a version 2.9 of TF-A which solves the building issue for this board.
* Increase the size of the ext2 partition to be able to create the final image.
* Bump and set the U-Boot version that was used for this configuration.
* Bump and set the version of Linux to 6.1.45.
* Some minor fixes in the post-build.sh script using shellcheck.

These details are the details of the changes between the v2 and v3 of your patch, so they do not belong to the commit log, but they should go...

Quoted 5 lines

---

.... here.

Quoted 18 lines
 DEVELOPERS                                |  4 +++
 board/firefly/roc-rk3399-pc/extlinux.conf |  4 +++
 board/firefly/roc-rk3399-pc/genimage.cfg  | 22 ++++++++++++
 board/firefly/roc-rk3399-pc/post-build.sh |  5 +++
 board/firefly/roc-rk3399-pc/readme.txt    | 40 +++++++++++++++++++++
 configs/roc_pc_rk3399_defconfig           | 42 +++++++++++++++++++++++
 6 files changed, 117 insertions(+)
 create mode 100644 board/firefly/roc-rk3399-pc/extlinux.conf
 create mode 100644 board/firefly/roc-rk3399-pc/genimage.cfg
 create mode 100755 board/firefly/roc-rk3399-pc/post-build.sh
 create mode 100644 board/firefly/roc-rk3399-pc/readme.txt
 create mode 100644 configs/roc_pc_rk3399_defconfig
DEVELOPERS +0 -0
index 6ffa3ee693..5ebabd01cb 100644

DEVELOPERS F: package/mhz/ · line 2551

Quoted 6 lines
DEVELOPERS +3 -0
@@ -2546,6 +2546,10 @@ F:	package/mhz/
 N:	Robert Rose <[email protected]>
 F:	package/grpc/
 
+N:	Roberto Medina <[email protected]>
+F:	configs/roc_pc_rk3399_defconfig
+F:	board/firefly/roc-rk3399

Alphabetic ordering was not correct here. And I added the final slash for the directory, as suggested by Kilian.

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#8 lore raw

Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

Hi Thomas,

Quoted 1 line · Thomas Petazzoni

I've applied your patch to our next branch, with some very minor updates.

Woops, I was just working on a v4 when you applied I believe. Thank you for the changes.

Best,
Roberto
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot