Skip to contentSkip to conversation

arcnet/com20020: add LEDS_CLASS dependency

PATCH Applied Arnd Bergmann 2 participants 2 messages Nov 3, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arcnet/com20020: add LEDS_CLASS dependency

The newly added led trigger support in the com20020-pci driver causes build errors when CONFIG_LEDS_CLASS is disabled:

drivers/built-in.o: In function `com20020pci_probe':
(.text+0x185dc4): undefined reference to devm_led_classdev_register' (.text+0x185dd8): undefined reference to devm_led_classdev_register'

This adds a Kconfig dependency to prevent the invalid configurations. Other drivers appear to be split 50:50 between 'select' and 'depends on' for this symbol, I picked 'depends on' as I could not find a common policy and it generally causes fewer problems.

Fixes 8890624a4e8c ("arcnet: com20020-pci: add led trigger support")

---
Found on ARM randconfig build tests

drivers/net/arcnet/Kconfig +1 -0
index 2a9c3c3abe9b..39bd16f3f86d 100644
@@ -103,6 +103,7 @@ config ARCNET_RIM_I
 
 config ARCNET_COM20020
 	tristate "ARCnet COM20020 chipset driver"
+	depends on LEDS_CLASS
 	help
 	  This is the driver for the new COM20020 chipset. It supports such
 	  things as promiscuous mode, so packet sniffing is possible, and
maintainer Applied
#1 lore raw

From: Arnd Bergmann <[email protected]>
Date: Tue, 03 Nov 2015 14:51:29 +0100

Quoted 7 lines

The newly added led trigger support in the com20020-pci driver causes build errors when CONFIG_LEDS_CLASS is disabled:

drivers/built-in.o: In function `com20020pci_probe':
(.text+0x185dc4): undefined reference to devm_led_classdev_register' (.text+0x185dd8): undefined reference to devm_led_classdev_register'

Quoted 7 lines

This adds a Kconfig dependency to prevent the invalid configurations. Other drivers appear to be split 50:50 between 'select' and 'depends on' for this symbol, I picked 'depends on' as I could not find a common policy and it generally causes fewer problems.

Fixes 8890624a4e8c ("arcnet: com20020-pci: add led trigger support")

Applied.