Skip to contentSkip to conversation

Revert "CodeSamples: Add -fcommon to GCC_ARGS"

PATCH Applied Akira Yokosawa 2 participants 2 messages Jan 6, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "CodeSamples: Add -fcommon to GCC_ARGS"

This reverts commit c1f3367e5701333dd9c2bdd629754d5278b66d2a.

Commit ca0fdef62907 ("CodeSamples: Add #ifndef SUBOBJ to api-pthreads.h") resolved root cause of build failures that commit c1f3367e5701 had worked around.

The band-aid fix can be reverted now.

---
 CodeSamples/datastruct/Issaquah/Makefile | 1 -
 CodeSamples/datastruct/hash/Makefile     | 1 -
 CodeSamples/defer/Makefile               | 1 -
 3 files changed, 3 deletions(-)
CodeSamples/datastruct/Issaquah/Makefile +0 -1
index ca379b3e..d3a5fcb2 100644
@@ -32,7 +32,6 @@ endif
 
 include $(top)/recipes.mk
 
-GCC_ARGS += -fcommon
 LURCU_SIG := $(shell pkg-config --libs liburcu-signal 2>/dev/null)
 
 # NOTE:  For decent scalability on update-side tests as of early 2015,
CodeSamples/datastruct/hash/Makefile +0 -1
index 5f3d740c..a84499eb 100644
@@ -32,7 +32,6 @@ endif
 
 include $(top)/recipes.mk
 
-GCC_ARGS += -fcommon
 LURCU_SIG := $(shell pkg-config --libs liburcu-signal 2>/dev/null)
 
 hash_bkt: hash_bkt.c ../../api.h hashtorture.h
CodeSamples/defer/Makefile +0 -1
index 0cb77122..69516958 100644
@@ -61,7 +61,6 @@ endif
 
 include $(top)/recipes.mk
 
-GCC_ARGS += -fcommon
 LURCU_SIG := $(shell pkg-config --libs liburcu-signal 2>/dev/null)
 
 # Note that bug_srcu_a is disabled until completed.

base-commit: 6081ef4580d7495727eeb87beb93b3b0dedf0139

Signature · 1 line
2.34.1
#1 lore raw
Quoted 9 lines · Akira Yokosawa

This reverts commit c1f3367e5701333dd9c2bdd629754d5278b66d2a.

Commit ca0fdef62907 ("CodeSamples: Add #ifndef SUBOBJ to api-pthreads.h") resolved root cause of build failures that commit c1f3367e5701 had worked around.

The band-aid fix can be reverted now.

Queued, thank you!

Thanx, Paul

Quoted 47 lines
---
 CodeSamples/datastruct/Issaquah/Makefile | 1 -
 CodeSamples/datastruct/hash/Makefile     | 1 -
 CodeSamples/defer/Makefile               | 1 -
 3 files changed, 3 deletions(-)
CodeSamples/datastruct/Issaquah/Makefile +0 -1
index ca379b3e..d3a5fcb2 100644
@@ -32,7 +32,6 @@ endif
 
 include $(top)/recipes.mk
 
-GCC_ARGS += -fcommon
 LURCU_SIG := $(shell pkg-config --libs liburcu-signal 2>/dev/null)
 
 # NOTE:  For decent scalability on update-side tests as of early 2015,
CodeSamples/datastruct/hash/Makefile +0 -1
index 5f3d740c..a84499eb 100644
@@ -32,7 +32,6 @@ endif
 
 include $(top)/recipes.mk
 
-GCC_ARGS += -fcommon
 LURCU_SIG := $(shell pkg-config --libs liburcu-signal 2>/dev/null)
 
 hash_bkt: hash_bkt.c ../../api.h hashtorture.h
CodeSamples/defer/Makefile +0 -1
index 0cb77122..69516958 100644
@@ -61,7 +61,6 @@ endif
 
 include $(top)/recipes.mk
 
-GCC_ARGS += -fcommon
 LURCU_SIG := $(shell pkg-config --libs liburcu-signal 2>/dev/null)
 
 # Note that bug_srcu_a is disabled until completed.

base-commit: 6081ef4580d7495727eeb87beb93b3b0dedf0139

Signature · 1 line
2.34.1