printks in drivers/scsi/hosts.c missing return
PATCH 1/1 printks in drivers/scsi/hosts.c missing return
Linus is away so I am just throwing this out on lkml...
Trivial but annoying: two printk() calls in drivers/scsi/hosts.c are missing '\n'
Also, for some reason I have not yet investigated, shost_tp->name is NULL here. This should not be, eh? If it can be, we should do something to tidy up the printing of it.
Patch is against 2.5.51.
Robert Love
drivers/scsi/hosts.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/hosts.c +2 -2
@@ -488,14 +488,14 @@if (!shost_tp->max_sectors) {printk (KERN_WARNING "scsi HBA driver %s didn't set max_sectors, " -"please fix the template" , shost_tp->name); +"please fix the template\n" , shost_tp->name); shost_tp->max_sectors =1024 ; }if (!shost_tp->release) {printk (KERN_WARNING "scsi HBA driver %s didn't set a release method, " -"please fix the template" , shost_tp->name); +"please fix the template\n" , shost_tp->name); shost_tp->release = &scsi_host_legacy_release; }