remove error message on illegal ioctl
PATCH 1/1 remove error message on illegal ioctl
Linus is away so I am just throwing this out on lkml..
This error message is uber annoying and needs to go. Non-root can flood the console with this junk on invalid SCSI CD-ROM ioctl(), and that is exactly what gnome-cd does.
An illegal ioctl() returns an error to the program. That is sufficient
- we do not need KERN_ERROR warnings all over the place. Especially when any user can cause them at any rate.
This patch, against 2.5.51, removes the message.
Robert Love
drivers/scsi/sr_ioctl.c | 3 --- 1 files changed, 3 deletions(-)
drivers/scsi/sr_ioctl.c +0 -3
@@ -156,9 +156,6 @@ err = -ENOMEDIUM ;break ;case ILLEGAL_REQUEST : -if (!cgc->quiet) -printk (KERN_ERR "%s: CDROM (ioctl) reports ILLEGAL " -"REQUEST.\n" , cd->cdi.name); err = -EIO ;if (SRpnt->sr_sense_buffer[12 ] ==0x20 && SRpnt->sr_sense_buffer[13 ] ==0x00 )