epoll: don't printk pointer value

Davide,

I really cannot think of a good reason why eventpoll_init() should print a pointer value to user-space - especially the value of current?

I do not think this is good practice and someone might even consider it a security hole. Personally, I would prefer to remove the "successfully initialized" message altogether, but at the very least can we not print current's address?

Robert Love

 fs/eventpoll.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -urN linux-2.5.51/fs/eventpoll.c linux/fs/eventpoll.c
@@ -1573,7 +1573,7 @@
 	if (IS_ERR(eventpoll_mnt))
 		goto eexit_4;
 
-	printk(KERN_INFO "[%p] eventpoll: successfully initialized.\n", current);
+	printk(KERN_INFO "eventpoll: successfully initialized.\n", current);
 
 	return 0;
 

You're still passing current as an argument to the printk.

Bill

Ah crap. That is what I get for not testing it... nothing is too trivial, boys and girls.

Thanks, Bill.

Robert Love

 fs/eventpoll.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -urN linux-2.5.51/fs/eventpoll.c linux/fs/eventpoll.c
@@ -1573,7 +1573,7 @@
 	if (IS_ERR(eventpoll_mnt))
 		goto eexit_4;
 
-	printk(KERN_INFO "[%p] eventpoll: successfully initialized.\n", current);
+	printk(KERN_INFO "eventpoll: successfully initialized.\n");
 
 	return 0;
 

So I would prefer...

Robert Love

 fs/eventpoll.c |    2 --
 1 files changed, 2 deletions(-)

diff -urN linux-2.5.51/fs/eventpoll.c linux/fs/eventpoll.c
@@ -1573,8 +1573,6 @@
 	if (IS_ERR(eventpoll_mnt))
 		goto eexit_4;
 
-	printk(KERN_INFO "[%p] eventpoll: successfully initialized.\n", current);
-
 	return 0;
 
 eexit_4:

Fine by me. I just notice the format string business.

Bill

It's ok Robert, it was used for debugging purposes and now it can be completely removed ( the whole printk() ). I'll post a patch to Linus that removes the printk() ...

- Davide