Skip to contentSkip to conversation

net/ice: fix unmatched integer type

PATCH Applied Ting Xu 4 participants 4 messages Jul 7, 2021 Network drivers

lore
Share & tools
lore

Ting Xu

author
#0 lore raw

PATCH 1/1 net/ice: fix unmatched integer type

This patch fixed the unmatched interger type issue in the comparison, which causing compilation failure on RHEL.

Fixes 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
---
 drivers/net/ice/ice_dcf_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_dcf_sched.c +1 -1
index 4371bbc820..aeb1afbe85 100644
@@ -350,7 +350,7 @@ ice_dcf_node_add(struct rte_eth_dev *dev, uint32_t node_id,
 			return -EINVAL;
 		}
 		/* check the vsi node id */
-		if (node_id > tc_nb * hw->num_vfs) {
+		if (node_id > (uint32_t)(tc_nb * hw->num_vfs)) {
 			error->type = RTE_TM_ERROR_TYPE_NODE_ID;
 			error->message = "too large VSI id";
 			return -EINVAL;
Signature · 1 line
2.17.1
Tested-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Ting Xu
Sent: Wednesday, July 7, 2021 12:51 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; NBU-Contact-Thomas Monjalon <[email protected]>; Ting Xu <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/ice: fix unmatched integer type

Quoted 8 lines

This patch fixed the unmatched interger type issue in the comparison, which causing compilation failure on RHEL.

Fixes 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")

---

Thanks,
Ali

#2 lore raw

07/07/2021 12:36, Ali Alnubani:

Quoted 6 lines

From: Ting Xu

Quoted 5 lines

This patch fixed the unmatched interger type issue in the comparison, which causing compilation failure on RHEL.

Fixes 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")

No need of Cc stable because the issue is only in the current branch.

Quoted 3 lines
Quoted 1 line

Applied with failure message, thanks.

https://git.dpdk.org/dpdk/commit/?id=83fa21405

Applied
#3 lore raw
In reply to Ali Alnubani
Quoted 23 lines

-----Original Message-----
From: Ali Alnubani <[email protected]>
Sent: Wednesday, July 7, 2021 6:36 PM
To: Xu, Ting <[email protected]>; [email protected]
Cc: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] net/ice: fix unmatched integer type

Quoted 12 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Ting Xu
Sent: Wednesday, July 7, 2021 12:51 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; NBU-Contact-Thomas Monjalon <[email protected]>; Ting Xu <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/ice: fix unmatched integer type

This patch fixed the unmatched interger type issue in the comparison, which causing compilation failure on RHEL.

Quoted 8 lines
Quoted 6 lines
Fixes 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in

DCF")
Cc: [email protected]

---

Applied to dpdk-next-net-intel.

Thanks
Qi

Quoted 3 lines

Thanks,
Ali