Skip to contentSkip to conversation

nouveau: remove pointless assignment

PATCH Dave Jones 2 participants 2 messages Sep 17, 2013 – Sep 19, 2013

Subsystems (3)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

self-assignment of a variable doesn't make a lot of sense.

drivers/gpu/drm/nouveau/nouveau_bo.c +1 -1
index 755c38d..d0a737c 100644
@@ -982,7 +982,7 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int evict, bool intr,
 		     bool no_wait_gpu, struct ttm_mem_reg *new_mem)
 {
 	struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
-	struct nouveau_channel *chan = chan = drm->ttm.chan;
+	struct nouveau_channel *chan = drm->ttm.chan;
 	struct nouveau_bo *nvbo = nouveau_bo(bo);
 	struct ttm_mem_reg *old_mem = &bo->mem;
 	int ret;
#1 lore raw

----- Original Message -----

Quoted 7 lines

From: "Dave Jones" <[email protected]>
To: "Linux Kernel" <[email protected]>
Cc: [email protected], [email protected]
Sent: Wednesday, 18 September, 2013 7:26:34 AM
Subject: nouveau: remove pointless assignment

self-assignment of a variable doesn't make a lot of sense.

Thanks, search-and-replace left-over, pulled into my tree.

Ben.

Quoted 19 lines
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -1
index 755c38d..d0a737c 100644
@@ -982,7 +982,7 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int
 evict, bool intr,
 		     bool no_wait_gpu, struct ttm_mem_reg *new_mem)
 {
 	struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
-	struct nouveau_channel *chan = chan = drm->ttm.chan;
+	struct nouveau_channel *chan = drm->ttm.chan;
 	struct nouveau_bo *nvbo = nouveau_bo(bo);
 	struct ttm_mem_reg *old_mem = &bo->mem;

int ret;