Skip to contentSkip to conversation

IPSec protocol application order

PATCH In review Tom Lendacky 3 participants 4 messages Feb 19, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IPSec protocol application order

The IPSec RFC (2401) and IPComp RFC (3173) specify the order in which the COMP, ESP and AH protocols must be applied when being applied in transport mode. Specifically, COMP must be applied first, then ESP and then AH. Also, transport mode protocols must be applied before tunnel mode protocols.

Here is a patch that creates the xfrm_tmpl structures in the order required by the RFCs. The patch requires that the application order of new transformations/protocols be specified for transport mode in order to have an xfrm_tmpl structure created. If this is not desired, an additional transport mode loop can be placed ahead of the COMP/ESP/AH transport mode loops that creates xfrm_tmpl structures for protocols other than COMP/ESP/AH.

Tom

net/key/af_key.c +50 -4
@@ -1562,12 +1562,58 @@
 parse_ipsecrequests(struct xfrm_policy *xp, struct sadb_x_policy *pol)
 {
 	int err;
-	int len = pol->sadb_x_policy_len*8 - sizeof(struct sadb_x_policy);
-	struct sadb_x_ipsecrequest *rq = (void*)(pol+1);
+	int len;
+	struct sadb_x_ipsecrequest *rq;
 
+	/* The order of template creation is important (RFC2401/RFC3173):
+		Transport templates first
+			COMP then
+			ESP then
+			AH then
+		Tunnel templates in any order */
+	len = pol->sadb_x_policy_len*8 - sizeof(struct sadb_x_policy);
+	rq = (void*)(pol+1);
 	while (len >= sizeof(struct sadb_x_ipsecrequest)) {
-		if ((err = parse_ipsecrequest(xp, rq)) < 0)
-			return err;
+		if (rq->sadb_x_ipsecrequest_mode == IPSEC_MODE_TRANSPORT &&
+		    rq->sadb_x_ipsecrequest_proto == IPPROTO_COMP) {
+			if ((err = parse_ipsecrequest(xp, rq)) < 0)
+				return err;
+		}
+		len -= rq->sadb_x_ipsecrequest_len;
+		rq = (void*)((u8*)rq + rq->sadb_x_ipsecrequest_len);
+	}
+	
+	len = pol->sadb_x_policy_len*8 - sizeof(struct sadb_x_policy);
+	rq = (void*)(pol+1);
+	while (len >= sizeof(struct sadb_x_ipsecrequest)) {
+		if (rq->sadb_x_ipsecrequest_mode == IPSEC_MODE_TRANSPORT &&
+		    rq->sadb_x_ipsecrequest_proto == IPPROTO_ESP) {
+			if ((err = parse_ipsecrequest(xp, rq)) < 0)
+				return err;
+		}
+		len -= rq->sadb_x_ipsecrequest_len;
+		rq = (void*)((u8*)rq + rq->sadb_x_ipsecrequest_len);
+	}
+	
+	len = pol->sadb_x_policy_len*8 - sizeof(struct sadb_x_policy);
+	rq = (void*)(pol+1);
+	while (len >= sizeof(struct sadb_x_ipsecrequest)) {
+		if (rq->sadb_x_ipsecrequest_mode == IPSEC_MODE_TRANSPORT &&
+		    rq->sadb_x_ipsecrequest_proto == IPPROTO_AH) {
+			if ((err = parse_ipsecrequest(xp, rq)) < 0)
+				return err;
+		}
+		len -= rq->sadb_x_ipsecrequest_len;
+		rq = (void*)((u8*)rq + rq->sadb_x_ipsecrequest_len);
+	}
+	
+	len = pol->sadb_x_policy_len*8 - sizeof(struct sadb_x_policy);
+	rq = (void*)(pol+1);
+	while (len >= sizeof(struct sadb_x_ipsecrequest)) {
+		if (rq->sadb_x_ipsecrequest_mode != IPSEC_MODE_TRANSPORT) {
+			if ((err = parse_ipsecrequest(xp, rq)) < 0)
+				return err;
+		}
 		len -= rq->sadb_x_ipsecrequest_len;
 		rq = (void*)((u8*)rq + rq->sadb_x_ipsecrequest_len);
 	}
#1 lore raw
Quoted 5 lines · Tom Lendacky

The IPSec RFC (2401) and IPComp RFC (3173) specify the order in which the COMP, ESP and AH protocols must be applied when being applied in transport mode. Specifically, COMP must be applied first, then ESP and then AH. Also, transport mode protocols must be applied before tunnel mode protocols.

Did you even read the email from Alexey yesterday that described why none of this is a kernel issue and we merely do exactly what the user application tells us to do when it uploads key configuration?

Just like you aparently ignored his email, I will ignore your patch.

#2 lore raw
In reply to Tom Lendacky
Quoted 6 lines · Tom Lendacky

The IPSec RFC (2401) and IPComp RFC (3173) specify the order in which the COMP, ESP and AH protocols must be applied when being applied in transport mode. Specifically, COMP must be applied first, then ESP and then AH. Also, transport mode protocols must be applied before tunnel mode protocols.

Quoted 7 lines

Here is a patch that creates the xfrm_tmpl structures in the order required by the RFCs. The patch requires that the application order of new transformations/protocols be specified for transport mode in order to have an xfrm_tmpl structure created. If this is not desired, an additional transport mode loop can be placed ahead of the COMP/ESP/AH transport mode loops that creates xfrm_tmpl structures for protocols other than COMP/ESP/AH.

hmmm... do you really need to duplicate all that code, just to define the order?

#3 lore raw

From: Jeff Garzik <[email protected]>
Date: Wed, 19 Feb 2003 16:29:50 -0500

hmmm... do you really need to duplicate all that code, just to define the order?

It's not even a kernel issue as Alexey and myself said in other emails, the kernel merely does what the user application asks it to do