Skip to contentSkip to conversation

CPCI stopped building

DISCUSSION Rusty Lynch 3 participants 3 messages Feb 24, 2003

lore
Share & tools
lore
#0 lore raw

Attempting to turn on cpci support on the latest kernel breaks the build. The problem is that pci_is_dev_in_use() has been removed, but cpci_hotplug_pci.c still calls the non-existant function in unconfigure_visit_pci_dev_phase1().

It looks like pci_dev_driver(dev) can be used in replacement (since that is what driver/pci/hotplug.c is now doing in pci_remove_device_safe(), but I haven't taken the time to really understand what is happening.

--rustyl

Here is the changeset comment:

ChangeSet 1.1002.8.3 2003/02/21 13:44:13 [email protected]
[PATCH] try_module_get(THIS_MODULE) is bogus

In most cases the fix is to add an struct module * member to the operations vector instead and manipulate the refcounts in the callers context.

For the ALSA cases it was completly superflous (when will people get it that using an exported symbol will make it's module unloadable?..)
drivers/pci/hotplug.c 1.11 2003/02/21 11:43:17 [email protected]
try_module_get(THIS_MODULE) is bogus

#1 lore raw
Quoted 8 lines · Rusty Lynch

Attempting to turn on cpci support on the latest kernel breaks the build. The problem is that pci_is_dev_in_use() has been removed, but cpci_hotplug_pci.c still calls the non-existant function in unconfigure_visit_pci_dev_phase1().

It looks like pci_dev_driver(dev) can be used in replacement (since that is what driver/pci/hotplug.c is now doing in pci_remove_device_safe(), but I haven't taken the time to really understand what is happening.

Yes, Christoph sent me this patch a few days ago, and I noticed it just got into the the tree. I'm makeing a lot of pci hotplug core and driver cleanups right now, and will handle this one too.

thanks,

greg k-h

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 5 lines · Rusty Lynch

Attempting to turn on cpci support on the latest kernel breaks the build. The problem is that pci_is_dev_in_use() has been removed, but cpci_hotplug_pci.c still calls the non-existant function in unconfigure_visit_pci_dev_phase1().

Quoted 7 lines
Quoted 3 lines

It looks like pci_dev_driver(dev) can be used in replacement (since that is what driver/pci/hotplug.c is now doing in pci_remove_device_safe(), but I haven't taken the time to really understand what is happening.

Yes, Christoph sent me this patch a few days ago, and I noticed it just got into the the tree. I'm makeing a lot of pci hotplug core and driver cleanups right now, and will handle this one too.

That's great, thanks. As I mentioned previously on pcihpd-discuss, I've got a couple of small cPCI fixes that I'll re-diff and post after what's in your patch queue has landed.

Scott

Signature · 4 lines
Scott Murray
SOMA Networks, Inc.
Toronto, Ontario
e-mail: [email protected]