Skip to contentSkip to conversation

2.5.63 Nasssty little hobbitsses making ssso many sspelling misstakesses!

PATCH In review Steven Cole 2 participants 3 messages Feb 27, 2003

Subsystems (10)
Networking Network drivers VFS SCSI +6 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.5.63 Nasssty little hobbitsses making ssso many sspelling misstakesses!

This patch fixes:

addresss    -> address    where there was a simple typo.
addresss    -> addresses  where the plural of address was meant.
accesss     -> access
accesssing  -> accessing
progresss   -> progress
Messsage    -> Message
endaineesss -> endianess  two fixes in this one
processsed  -> processed
asssembler  -> assembler
Reasssign   -> Reassign

permisssions -> permissions
asssociated -> associated

This was diffed against the current 2.5 tree.

Steven

 arch/sparc64/kernel/traps.c                 |    2 +-
 drivers/acorn/block/mfmhd.c                 |    2 +-
 drivers/ide/ide-floppy.c                    |    2 +-
 drivers/net/e1000/e1000_hw.c                |    2 +-
 drivers/net/irda/ali-ircc.c                 |    2 +-
 drivers/net/rclanmtl.c                      |   20 ++++++++++----------
 drivers/net/sk98lin/skxmac2.c               |    2 +-
 drivers/net/wan/pc300_drv.c                 |    2 +-
 drivers/scsi/aic7xxx/aicasm/aicasm.c        |    2 +-
 drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c |    2 +-
 drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h |    2 +-
 drivers/scsi/constants.c                    |    2 +-
 drivers/scsi/nsp32_debug.c                  |    2 +-
 drivers/scsi/pcmcia/nsp_debug.c             |    2 +-
 fs/ChangeLog                                |    2 +-
 fs/freevxfs/vxfs_inode.c                    |    2 +-
 fs/ntfs/ChangeLog                           |    2 +-
 include/net/sctp/user.h                     |    8 ++++----
 18 files changed, 30 insertions(+), 30 deletions(-)
arch/sparc64/kernel/traps.c +1 -1
diff -ur 2.5-current/arch/sparc64/kernel/traps.c linux/arch/sparc64/kernel/traps.c
@@ -764,7 +764,7 @@
 } cheetah_error_table[] = {
 	{	CHAFSR_PERR,	"System interface protocol error"			},
 	{	CHAFSR_IERR,	"Internal processor error"				},
-	{	CHAFSR_ISAP,	"System request parity error on incoming addresss"	},
+	{	CHAFSR_ISAP,	"System request parity error on incoming address"	},
 	{	CHAFSR_UCU,	"Uncorrectable E-cache ECC error for ifetch/data"	},
 	{	CHAFSR_UCC,	"SW Correctable E-cache ECC error for ifetch/data"	},
 	{	CHAFSR_UE,	"Uncorrectable system bus data ECC error for read"	},
drivers/acorn/block/mfmhd.c +1 -1
diff -ur 2.5-current/drivers/acorn/block/mfmhd.c linux/drivers/acorn/block/mfmhd.c
@@ -728,7 +728,7 @@
 		};
 		/* Potentially this means that we've done; but we might be doing
 		   a partial access, (over two cylinders) or we may have a number
-		   of fragments in an image file.  First let's deal with partial accesss
+		   of fragments in an image file.  First let's deal with partial access
 		 */
 		if (PartFragRead) {
 			/* Yep - a partial access */
drivers/ide/ide-floppy.c +1 -1
diff -ur 2.5-current/drivers/ide/ide-floppy.c linux/drivers/ide/ide-floppy.c
@@ -1584,7 +1584,7 @@
 /*
 ** Get ATAPI_FORMAT_UNIT progress indication.
 **
-** Userland gives a pointer to an int.  The int is set to a progresss
+** Userland gives a pointer to an int.  The int is set to a progress
 ** indicator 0-65536, with 65536=100%.
 **
 ** If the drive does not support format progress indication, we just check
drivers/net/e1000/e1000_hw.c +1 -1
diff -ur 2.5-current/drivers/net/e1000/e1000_hw.c linux/drivers/net/e1000/e1000_hw.c
@@ -2793,7 +2793,7 @@
  * hw - Struct containing variables accessed by shared code 
  *
  * Places the MAC address in receive address register 0 and clears the rest
- * of the receive addresss registers. Clears the multicast table. Assumes
+ * of the receive address registers. Clears the multicast table. Assumes
  * the receiver is in reset when the routine is called.
  *****************************************************************************/
 void
drivers/net/irda/ali-ircc.c +1 -1
diff -ur 2.5-current/drivers/net/irda/ali-ircc.c linux/drivers/net/irda/ali-ircc.c
@@ -1783,7 +1783,7 @@
 	MessageCount = inb(iobase+ FIR_LSR)&0x07;
 	
 	if (MessageCount > 0)	
-		IRDA_DEBUG(0, "%s(), Messsage count = %d,\n", __FUNCTION__ , MessageCount);	
+		IRDA_DEBUG(0, "%s(), Message count = %d,\n", __FUNCTION__ , MessageCount);	
 		
 	for (i=0; i<=MessageCount; i++)
 	{
drivers/net/rclanmtl.c +10 -10
diff -ur 2.5-current/drivers/net/rclanmtl.c linux/drivers/net/rclanmtl.c
@@ -818,7 +818,7 @@
 	p_atu->EtherMacLow = 0;	/* first zero return data */
 	p_atu->EtherMacHi = 0;
 
-	off = p_atu->InQueue;	/* get addresss of message */
+	off = p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -880,7 +880,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -925,7 +925,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -965,7 +965,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -1079,7 +1079,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -1271,7 +1271,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -1381,7 +1381,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -1502,7 +1502,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -1561,7 +1561,7 @@
 	if (pPab == NULL)
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
-	off = pPab->p_atu->InQueue;	/* get addresss of message */
+	off = pPab->p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
@@ -1608,7 +1608,7 @@
 		return RC_RTN_ADPTR_NOT_REGISTERED;
 
 	p_atu = pPab->p_atu;
-	off = p_atu->InQueue;	/* get addresss of message */
+	off = p_atu->InQueue;	/* get address of message */
 
 	if (0xFFFFFFFF == off)
 		return RC_RTN_FREE_Q_EMPTY;
drivers/net/sk98lin/skxmac2.c +1 -1
diff -ur 2.5-current/drivers/net/sk98lin/skxmac2.c linux/drivers/net/sk98lin/skxmac2.c
@@ -169,7 +169,7 @@
  *	fix: AutoNegDone bug
  *
  *	Revision 1.19  1998/10/29 10:14:43  malthoff
- *	Add endainesss comment for reading/writing MAC addresses.
+ *	Add endianess comment for reading/writing MAC addresses.
  *
  *	Revision 1.18  1998/10/28 07:48:55  cgoos
  *	Fix: ASS somtimes signaled although link is up.
drivers/net/wan/pc300_drv.c +1 -1
diff -ur 2.5-current/drivers/net/wan/pc300_drv.c linux/drivers/net/wan/pc300_drv.c
@@ -1447,7 +1447,7 @@
  * Description:	In the remote loopback mode the clock and data recovered
  *		from the line inputs RL1/2 or RDIP/RDIN are routed back
  *		to the line outputs XL1/2 or XDOP/XDON via the analog
- *		transmitter. As in normal mode they are processsed by
+ *		transmitter. As in normal mode they are processed by
  *		the synchronizer and then sent to the system interface.
  *----------------------------------------------------------------------------
  */
drivers/scsi/aic7xxx/aicasm/aicasm.c +1 -1
diff -ur 2.5-current/drivers/scsi/aic7xxx/aicasm/aicasm.c linux/drivers/scsi/aic7xxx/aicasm/aicasm.c
@@ -1,5 +1,5 @@
 /*
- * Aic7xxx SCSI host adapter firmware asssembler
+ * Aic7xxx SCSI host adapter firmware assembler
  *
  * Copyright (c) 1997, 1998, 2000, 2001 Justin T. Gibbs.
  * Copyright (c) 2001, 2002 Adaptec Inc.
drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c +1 -1
diff -ur 2.5-current/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c linux/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c
@@ -1,5 +1,5 @@
 /*
- * Aic7xxx SCSI host adapter firmware asssembler symbol table implementation
+ * Aic7xxx SCSI host adapter firmware assembler symbol table implementation
  *
  * Copyright (c) 1997 Justin T. Gibbs.
  * Copyright (c) 2002 Adaptec Inc.
drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h +1 -1
diff -ur 2.5-current/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h linux/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h
@@ -1,5 +1,5 @@
 /*
- * Aic7xxx SCSI host adapter firmware asssembler symbol table definitions
+ * Aic7xxx SCSI host adapter firmware assembler symbol table definitions
  *
  * Copyright (c) 1997 Justin T. Gibbs.
  * Copyright (c) 2002 Adaptec Inc.
drivers/scsi/constants.c +1 -1
diff -ur 2.5-current/drivers/scsi/constants.c linux/drivers/scsi/constants.c
@@ -36,7 +36,7 @@
 #if (CONSTANTS & CONST_COMMAND)
 static const char * group_0_commands[] = {
 /* 00-03 */ "Test Unit Ready", "Rezero Unit", unknown, "Request Sense",
-/* 04-07 */ "Format Unit", "Read Block Limits", unknown, "Reasssign Blocks",
+/* 04-07 */ "Format Unit", "Read Block Limits", unknown, "Reassign Blocks",
 /* 08-0d */ "Read (6)", unknown, "Write (6)", "Seek (6)", unknown, unknown,
 /* 0e-12 */ unknown, "Read Reverse", "Write Filemarks", "Space", "Inquiry",  
 /* 13-16 */ "Verify", "Recover Buffered Data", "Mode Select", "Reserve",
drivers/scsi/nsp32_debug.c +1 -1
diff -ur 2.5-current/drivers/scsi/nsp32_debug.c linux/drivers/scsi/nsp32_debug.c
@@ -13,7 +13,7 @@
 
 static const char * group_0_commands[] = {
 /* 00-03 */ "Test Unit Ready", "Rezero Unit", unknown, "Request Sense",
-/* 04-07 */ "Format Unit", "Read Block Limits", unknown, "Reasssign Blocks",
+/* 04-07 */ "Format Unit", "Read Block Limits", unknown, "Reassign Blocks",
 /* 08-0d */ "Read (6)", unknown, "Write (6)", "Seek (6)", unknown, unknown,
 /* 0e-12 */ unknown, "Read Reverse", "Write Filemarks", "Space", "Inquiry",  
 /* 13-16 */ unknown, "Recover Buffered Data", "Mode Select", "Reserve",
drivers/scsi/pcmcia/nsp_debug.c +1 -1
diff -ur 2.5-current/drivers/scsi/pcmcia/nsp_debug.c linux/drivers/scsi/pcmcia/nsp_debug.c
@@ -15,7 +15,7 @@
 
 static const char * group_0_commands[] = {
 /* 00-03 */ "Test Unit Ready", "Rezero Unit", unknown, "Request Sense",
-/* 04-07 */ "Format Unit", "Read Block Limits", unknown, "Reasssign Blocks",
+/* 04-07 */ "Format Unit", "Read Block Limits", unknown, "Reassign Blocks",
 /* 08-0d */ "Read (6)", unknown, "Write (6)", "Seek (6)", unknown, unknown,
 /* 0e-12 */ unknown, "Read Reverse", "Write Filemarks", "Space", "Inquiry",  
 /* 13-16 */ unknown, "Recover Buffered Data", "Mode Select", "Reserve",
fs/ChangeLog +1 -1
diff -ur 2.5-current/fs/ChangeLog linux/fs/ChangeLog
@@ -41,7 +41,7 @@
 		Moved the check for sticky bit here.
 	* affs/{inode,namei}.c:
 		All AFFS directories have sticky semantics (i.e. non-owner
-		having write permisssions on directory can unlink/rmdir/rename
+		having write permissions on directory can unlink/rmdir/rename
 		only the files he owns), but AFFS didn't set S_ISVTX on them.
 		Fixed. NB: maybe this behaviour should be controlled by mount
 		option. Obvious values being 'sticky' (current behaviour),
fs/freevxfs/vxfs_inode.c +1 -1
diff -ur 2.5-current/fs/freevxfs/vxfs_inode.c linux/fs/freevxfs/vxfs_inode.c
@@ -285,7 +285,7 @@
  * *ip:			VFS inode
  *
  * Description:
- *  vxfs_put_fake_inode frees all data asssociated with @ip.
+ *  vxfs_put_fake_inode frees all data associated with @ip.
  */
 void
 vxfs_put_fake_inode(struct inode *ip)
fs/ntfs/ChangeLog +1 -1
diff -ur 2.5-current/fs/ntfs/ChangeLog linux/fs/ntfs/ChangeLog
@@ -749,7 +749,7 @@
 	  by the kernel.
 
 	The driver is now actually useful! Yey. (-: It undoubtedly has got bugs
-	though and it doesn't implement accesssing compressed files yet. Also,
+	though and it doesn't implement accessing compressed files yet. Also,
 	accessing files with attribute list attributes is not implemented yet
 	either. But for small or simple file systems it should work and allow
 	you to list directories, use stat on directory entries and the file
include/net/sctp/user.h +4 -4
diff -ur 2.5-current/include/net/sctp/user.h linux/include/net/sctp/user.h
@@ -100,13 +100,13 @@
 #define SCTP_SOCKOPT_BINDX_REM	SCTP_SOCKOPT_BINDX_REM
 	SCTP_SOCKOPT_PEELOFF, 	/* peel off association. */
 #define SCTP_SOCKOPT_PEELOFF	SCTP_SOCKOPT_PEELOFF
-	SCTP_GET_PEER_ADDRS_NUM, 	/* Get number of peer addresss. */
+	SCTP_GET_PEER_ADDRS_NUM, 	/* Get number of peer addresses. */
 #define SCTP_GET_PEER_ADDRS_NUM	SCTP_GET_PEER_ADDRS_NUM
-	SCTP_GET_PEER_ADDRS, 	/* Get all peer addresss. */
+	SCTP_GET_PEER_ADDRS, 	/* Get all peer addresses. */
 #define SCTP_GET_PEER_ADDRS	SCTP_GET_PEER_ADDRS
-	SCTP_GET_LOCAL_ADDRS_NUM, 	/* Get number of local addresss. */
+	SCTP_GET_LOCAL_ADDRS_NUM, 	/* Get number of local addresses. */
 #define SCTP_GET_LOCAL_ADDRS_NUM	SCTP_GET_LOCAL_ADDRS_NUM
-	SCTP_GET_LOCAL_ADDRS, 	/* Get all local addresss. */
+	SCTP_GET_LOCAL_ADDRS, 	/* Get all local addresses. */
 #define SCTP_GET_LOCAL_ADDRS	SCTP_GET_LOCAL_ADDRS
 };
 
#1 lore raw
Quoted 3 lines · Steven Cole

This patch fixes:

[Many typoes all over the place]

I have't followed this much, but there are some lessons from the comments on this (and previous patches):

- "isn't" (and such) get better changed to "is not", as 's give grief (at least in .S files)
- I wouldn't bother too much on broken editors that don't understand 's in comments or strings
- It would be better for you to tackle _all_ typoes in one area, get them fixed by the maintainer, then move on. Patches that change lines under the maintainers/other patches aren't wellcome, as they break the patches (and if they don't fix the code, people _will_ bitch at whoever integrates them)

Yes, I know this is a lot of work. But as it stands, it is a lot of _wasted_ work if the patches aren't being integrated.

Thanks!

Signature · 4 lines
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
#2 lore raw
Quoted 10 lines · Horst von Brand
Quoted 3 lines · Steven Cole

This patch fixes:

[Many typoes all over the place]

I have't followed this much, but there are some lessons from the comments on this (and previous patches):

- "isn't" (and such) get better changed to "is not", as 's give grief (at least in .S files)

That problem is understood and is why my patch which changed "its" to "it's" used "it is" in the two files where that was an issue. One was a .c file with in-line assembly.

Quoted 3 lines

- I wouldn't bother too much on broken editors that don't understand 's in comments or strings
- It would be better for you to tackle _all_ typoes in one area, get them

Better for some.

Quoted 4 lines

fixed by the maintainer, then move on. Patches that change lines under the maintainers/other patches aren't wellcome, as they break the patches (and if they don't fix the code, people _will_ bitch at whoever integrates them)

I can certainly back off on these fixes or do it the way you suggest if it's causing people any grief. Your request is the second in this area and being an impediment to progress is the opposite of my intention.

Quoted 5 lines

Yes, I know this is a lot of work. But as it stands, it is a lot of _wasted_ work if the patches aren't being integrated.

Thanks!

If "the patches" in the above are my patches, then that's my problem. If "the patches" in the above are yours and others patches, then the problem is more generic. These typo fixes have a fairly low intrinsic value, but the issue you raise is important.

I've seen several instances where real fixes have gotten integrated, only to be inadvertently backed out by a subsequent unrelated patch to the same file from another maintainer who had not recently resynced his tree with Linus. A generic solution to that problem would have considerable value. If we all used Bitkeeper, maybe we wouldn't have these prob...(just kidding about BK, no flames please).

Steven